-
Notifications
You must be signed in to change notification settings - Fork 887
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
WIP: Redirect .onion URLs to a private window with Tor, if possible.
fix brave/brave-browser#806 - If there is no private window with Tor open, fail. => TODO: This should fail noisily, beyond a console message. => One may be tempted to just create a private window with Tor, but: . This is not obviously easy to do here. . Users may not be happy if simply clicking a link can have the effect of using Tor when they didn't intend. - If there is a private window with Tor open, create a new tab to load the page. => User expectations around onion services are likely to be that they provide anonymity, so opening them in the non-anonymous window may be surprising. => It is not clear how easy it would be to load in a non-Tor window and ensure that everything is nevertheless loaded through Tor -- and likewise links from it, &c.
- Loading branch information
1 parent
c9adcb3
commit c7951e2
Showing
2 changed files
with
26 additions
and
5 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters