Provide link for keyboard shortcuts (for extensions) in brave://setti…

…ngs/extensions Fixes brave/brave-browser#4024
brave · Mar 2, 2020 · 635c3e7 · 635c3e7
1 parent a77449e
commit 635c3e7
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 0 deletions.
diff --git a/browser/resources/settings/brave_default_extensions_page/brave_default_extensions_page.html b/browser/resources/settings/brave_default_extensions_page/brave_default_extensions_page.html
@@ -117,6 +117,11 @@
         label="$i18n{manageExtensionsLabel}" on-click="openExtensionsPage_">
       </cr-link-row>
     </div>
+    <div class="settings-row" id="manageKeyboardShortcutsRow">
+      <cr-link-row icon-class="icon-external"
+        label="$i18n{keyboardShortcuts}" on-click="openKeyboardShortcutsPage_">
+      </cr-link-row>
+    </div>
     <div class="settings-row" id="getMoreExtensionsRow">
       <cr-link-row
         label="$i18n{getMoreExtensionsLabel}"

diff --git a/browser/resources/settings/brave_default_extensions_page/brave_default_extensions_page.js b/browser/resources/settings/brave_default_extensions_page/brave_default_extensions_page.js
@@ -37,6 +37,7 @@ Polymer({
     this.onHangoutsEnabledChange_ = this.onHangoutsEnabledChange_.bind(this)
     this.onIPFSCompanionEnabledChange_ = this.onIPFSCompanionEnabledChange_.bind(this)
     this.openExtensionsPage_ = this.openExtensionsPage_.bind(this)
+    this.openKeyboardShortcutsPage_ = this.openKeyboardShortcutsPage_.bind(this)
     this.restartBrowser_ = this.restartBrowser_.bind(this)
     this.onTorEnabledChange_ = this.onTorEnabledChange_.bind(this)
 
@@ -93,6 +94,10 @@ Polymer({
     window.open("chrome://extensions", "_self");
   },
 
+  openKeyboardShortcutsPage_: function() {
+    window.open("chrome://extensions/shortcuts", "_self");
+  },
+
   openWebStoreUrl_: function() {
     window.open(loadTimeData.getString('getMoreExtensionsUrl'));
   },

diff --git a/chromium_src/chrome/browser/ui/webui/settings/settings_localized_strings_provider.cc b/chromium_src/chrome/browser/ui/webui/settings/settings_localized_strings_provider.cc
@@ -165,6 +165,8 @@ void BraveAddCommonStrings(content::WebUIDataSource* html_source,
       IDS_SETTINGS_RELAUNCH_BUTTON_LABEL},
     {"manageExtensionsLabel",
       IDS_SETTINGS_MANAGE_EXTENSIONS_LABEL},
+    {"keyboardShortcuts",
+      IDS_EXTENSIONS_SIDEBAR_KEYBOARD_SHORTCUTS},
     {"getMoreExtensionsLabel",
       IDS_BRAVE_SETTINGS_GET_MORE_EXTENSIONS_LABEL},
     {"getMoreExtensionsSubLabel",