Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Desktop] Use first name instead of full name in Rewards panel #9909

Closed
jonathansampson opened this issue May 22, 2020 · 1 comment · Fixed by brave/brave-core#5646
Closed

[Desktop] Use first name instead of full name in Rewards panel #9909

jonathansampson opened this issue May 22, 2020 · 1 comment · Fixed by brave/brave-core#5646
Assignees
@NejcZdovc
Labels
feature/rewards priority/P2 A bad problem. We might uplift this to the next planned release. privacy QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Milestone
1.11.x - Release #1

Comments

@jonathansampson
Copy link
Contributor

Description

Brave Rewards presently displays the users full name so they are able to distinguish between connected accounts. The full name is not likely necessary, as the first name alone should suffice.

image

Brave version (brave://version info)

1.9.72
@jonathansampson jonathansampson added privacy feature/rewards priority/P2 A bad problem. We might uplift this to the next planned release. labels May 22, 2020
@NejcZdovc NejcZdovc self-assigned this May 25, 2020
@NejcZdovc NejcZdovc added this to the 1.11.x - Nightly milestone May 25, 2020
@NejcZdovc NejcZdovc mentioned this issue May 25, 2020
Merged
32 tasks
NejcZdovc added a commit to brave/brave-core that referenced this issue May 26, 2020
@NejcZdovc
Use first name instead of full name in rewards uphold
e90090d 
Resolves brave/brave-browser#9909
@kjozwiak
Copy link
Member

kjozwiak commented Jun 16, 2020 •
edited by LaurenWags
Loading

Verification PASSED on macOS 10.15.5 x64 using the following build:

Brave | 1.11.64 Chromium: 83.0.4103.97 (Official Build) dev (64-bit)
-- | --
Revision | 326d148b9655369b86498d9ecca39f63dd2bdd2d-refs/branch-heads/4103@{#657}
OS | macOS Version 10.15.5 (Build 19F101)
1.10.90 CR: 83.0.4103.97 (Old) 1.11.64 CR: 83.0.4103.97 (New)
Screen Shot 2020-06-15 at 11 38 05 PM Screen Shot 2020-06-15 at 11 35 03 PM

Verification passed on


Brave | 1.11.65 Chromium: 83.0.4103.97 (Official Build) dev (64-bit)
-- | --
Revision | 326d148b9655369b86498d9ecca39f63dd2bdd2d-refs/branch-heads/4103@{#657}
OS | Windows 10 OS Version 1903 (Build 18362.30)

image

Verified passed with

Brave	1.11.84 Chromium: 83.0.4103.116 (Official Build) dev (64-bit)
Revision	8f0c18b4dca9b6699eb629be0f51810c24fb6428-refs/branch-heads/4103@{#716}
OS	Linux

Screen Shot 2020-07-01 at 12 21 48 PM

@rebron rebron changed the title Use First Name Instead of Full Name in Rewards [Desktop] Use First Name Instead of Full Name in Rewards Jul 14, 2020
@rebron rebron changed the title [Desktop] Use First Name Instead of Full Name in Rewards [Desktop] Use first name instead of full name in Rewards Jul 14, 2020
@rebron rebron changed the title [Desktop] Use first name instead of full name in Rewards [Desktop] Use first name instead of full name in Rewards panel Jul 15, 2020
@LaurenWags LaurenWags mentioned this issue Jul 15, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@NejcZdovc NejcZdovc

Labels
feature/rewards priority/P2 A bad problem. We might uplift this to the next planned release. privacy QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Projects
None yet
Milestone
1.11.x - Release #1
Development

Successfully merging a pull request may close this issue.

Use first name instead of full name in rewards uphold brave/brave-core
5 participants
@jonathansampson @kjozwiak @NejcZdovc @LaurenWags @GeetaSarvadnya