Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove bookmark icon from top sites #9672

Closed
rebron opened this issue May 7, 2020 · 5 comments · Fixed by brave/brave-core#5490
Closed

Remove bookmark icon from top sites #9672

rebron opened this issue May 7, 2020 · 5 comments · Fixed by brave/brave-core#5490

Comments

@rebron
Copy link
Collaborator

rebron commented May 7, 2020

Description

In preparation for giving users the ability to edit top sites, remove the bookmark icon to remove the icon clutter on top sites. This will also improve perf on the new tab page as we're not needing to check for bookmarked sites.

Steps to Reproduce

  1. Go to brave://newtab
  2. Ensure you have top sites.
  3. Hover over a tile and notice bookmark icon.
  4. Expected result is that bookmark icon is no longer there.

Actual result:

screen_shot_2020-05-07_at_8 19 51_am

Expected result:

screen_shot_2020-05-07_at_12 37 02

Future direction where we're only displaying one icon to edit or remove top sites.
Screen Shot 2020-05-07 at 8 20 46 AM

Reproduces how often:

Easily.

Brave version (brave://version info)

Version/Channel Information:

  • Can you reproduce this issue with the current release? Yes
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the dev channel? Yes
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? n/a
  • Does the issue resolve itself when disabling Brave Rewards? n/a
  • Is the issue reproducible on the latest version of Chrome? n/a

Miscellaneous Information:

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented May 26, 2020

Verification passed on


Brave | 1.10.71 Chromium: 81.0.4044.138 (Official Build) dev (64-bit)
-- | --
Revision | 8c6c7ba89cc9453625af54f11fd83179e23450fa-refs/branch-heads/4044@{#999}
OS | Windows 10 OS Version 1803 (Build 17134.1006)

  • Verified STR from the description
    Clean install
    image
  • Installed 1.9.x added few top tiles and bookmarked them in NTP, upgraded to 1.10.x and verified that the bookmark icon is no longer displayed for top tiles
    image

@LaurenWags
Copy link
Member

Removing QA Pass-Win64 as this will need to be rechecked on 1.9.x once uplift is approved and merged.

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented May 28, 2020

Verification passed on


Brave | 1.9.76 Chromium: 81.0.4044.138 (Official Build) (64-bit)
-- | --
Revision | 8c6c7ba89cc9453625af54f11fd83179e23450fa-refs/branch-heads/4044@{#999}
OS | Windows 10 OS Version 1803 (Build 17134.1006)

  • Verified STR from the description

Clean profile:
Verified bookmark icon is no longer displayed for top tiles
image

Upgraded profile:
Install 1.9.72 add few top tiles in NTP and bookmark them and upgrade profile to 1.9.76 and verified that bookmark icon is no longer displayed for top tiles

1.9.72
image

1.9.76
image


Verified passed with

Brave | 1.9.76 Chromium: 81.0.4044.138 (Official Build) (64-bit)
-- | --
Revision | 8c6c7ba89cc9453625af54f11fd83179e23450fa-refs/branch-heads/4044@{#999}
OS | macOS Version 10.14.6 (Build 18G3020)
  • Verified STR from description for both clean and upgrade profiles.

Clean profile:
Added top site tiles, confirmed no bookmark icon. Confirmed still able to pin, delete, and undo delete of sites:
Screen Shot 2020-05-28 at 11 13 07 AM

Upgrade profile:
Used 1.9.72 to add top site tiles. Marked some as pinned and bookmarked via icon on tile:
Screen Shot 2020-05-28 at 10 48 40 AM
Screen Shot 2020-05-28 at 10 48 57 AM
Screen Shot 2020-05-28 at 10 48 17 AM

Updated to 1.9.76. Confirmed bookmark icon no longer displayed on top site tiles. Confirmed still able to pin, delete, undo delete of tiles:
Screen Shot 2020-05-28 at 10 50 48 AM
Screen Shot 2020-05-28 at 10 50 54 AM
Screen Shot 2020-05-28 at 10 51 00 AM
Screen Shot 2020-05-28 at 10 51 06 AM

Verification passed on

Brave 1.9.76 Chromium: 81.0.4044.138 (Official Build) (64-bit)
Revision 8c6c7ba89cc9453625af54f11fd83179e23450fa-refs/branch-heads/4044@{#999}
OS Ubuntu 18.04 LTS

Verified test plan from the description

Before upgrade
image
After upgrade
image

Verified bookmark icon no longer displayed on top site tiles. Confirmed still able to pin, delete, undo delete of tiles.

Clean install:
image

@rebron rebron changed the title remove bookmark icon from top sites Remove bookmark icon from top sites May 29, 2020
@suryaceg
Copy link

suryaceg commented Jun 1, 2020

It's still appearing. Please see.

image

Uploading image.png…

@bsclifton
Copy link
Member

@suryaceg what version of Brave are you using? It should be 1.9.76 or newer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants