Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

top site tile does not correctly reflect that site is bookmarked on upgrade #9459

Closed
LaurenWags opened this issue Apr 24, 2020 · 2 comments
Closed

Comments

@LaurenWags
Copy link
Member

Description

Found while testing #2971

If one of your top site tiles is bookmarked on 1.7.x and you upgrade to 1.8.x, the bookmark icon is not filled in on 1.8.x, although the site is actually bookmarked.

Steps to Reproduce

  1. Using 1.7.x have a profile with history and at least one top site tile bookmarked.
  2. Update to 1.8.x.

Actual result:

Tile does not indicate that the site is bookmarked but it is.
Screen Shot 2020-04-24 at 4 39 24 PM
Screen Shot 2020-04-24 at 4 39 34 PM

Expected result:

Tile should indicate that the site is bookmarked as it does in 1.7.x.
Screen Shot 2020-04-24 at 4 38 57 PM
Screen Shot 2020-04-24 at 4 39 09 PM

Reproduces how often:

easily

Brave version (brave://version info)

Brave 1.8.82 Chromium: 81.0.4044.113 (Official Build) dev (64-bit)
Revision e3225dafb0475864a1812a374d73a92e391635ac-refs/branch-heads/4044@{#936}
OS macOS Version 10.14.6 (Build 18G3020)

Version/Channel Information:

  • Can you reproduce this issue with the current release? n/a
  • Can you reproduce this issue with the beta channel? yes
  • Can you reproduce this issue with the dev channel? yes
  • Can you reproduce this issue with the nightly channel? unsure

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

cc @brave/legacy_qa @rebron @cezaraugusto @bsclifton

@rebron
Copy link
Collaborator

rebron commented May 7, 2020

Loosely related to #9481.

@bsclifton
Copy link
Member

Closing as wontfix since bookmark icon is removed with #9672

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants