Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add check to ensure token pref wipe on successful revocation (Binance widget) #9438

Closed
ryanml opened this issue Apr 24, 2020 · 0 comments
Closed

Add check to ensure token pref wipe on successful revocation (Binance widget) #9438

ryanml opened this issue Apr 24, 2020 · 0 comments
Assignees
@ryanml
Labels
feature/widgets OS/Desktop QA/No release-notes/exclude tests
Milestone
1.10.x - Release

Comments

@ryanml
Copy link
Contributor

ryanml commented Apr 24, 2020

Item #1 per: https://github.com/brave/security/issues/127#issuecomment-618140258

A simple check to should be added to the existing test condition for a successful revocation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ryanml ryanml

Labels
feature/widgets OS/Desktop QA/No release-notes/exclude tests
Projects
None yet
Milestone
1.10.x - Release
Development

Successfully merging a pull request may close this issue.

Adds check for empty token prefs on successful revocation (Binance widget) brave/brave-core
3 participants
@bbondy @rebron @ryanml