Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android] don't copy resources into chrome res dir #8995

Closed
bridiver opened this issue Apr 2, 2020 · 3 comments · Fixed by brave/brave-core#5147
Closed

[Android] don't copy resources into chrome res dir #8995

bridiver opened this issue Apr 2, 2020 · 3 comments · Fixed by brave/brave-core#5147

Comments

@bridiver
Copy link
Contributor

bridiver commented Apr 2, 2020

We currently copy a lot of resources from brave/android/java/res to chrome/android/java/res and we should not be doing things like if we can avoid it

@bridiver bridiver added QA/Yes OS/Android Fixes related to Android browser functionality labels Apr 2, 2020
@bridiver bridiver self-assigned this Apr 2, 2020
@bridiver
Copy link
Contributor Author

bridiver commented Apr 2, 2020

For QA - not sure if there's anything special you need to do because a normal QA pass should find any issues, but examples of resources would be things like the new tab page layout (which I spot checked). @SergeyZhukovsky may have some other suggestions to check

@GeetaSarvadnya
Copy link

@SergeyZhukovsky General testing would be fine or do you have any specific test plan for this issue?

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented May 22, 2020

Verification passed on Samsung Galaxy J3 version 5.1.1 running BraveModernarm.apk 1.9.74


Verification passed on BraveModernarm v1.9.74 on Samsung Galaxy Tab S5e (Android 9.0)


Verification passed on Asus Zenfone (x86) with Android 6 running BraveModernx86.apk 1.9.74

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants