Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add source to monthly statement #8986

Closed
LaurenWags opened this issue Apr 2, 2020 · 2 comments · Fixed by brave/brave-core#5210
Closed

add source to monthly statement #8986

LaurenWags opened this issue Apr 2, 2020 · 2 comments · Fixed by brave/brave-core#5210

Comments

@LaurenWags
Copy link
Member

Description

If a transaction (such as AC) is split between VG and Uphold funds, source should be shown on Monthly statement.

Example: #8828

Steps to Reproduce

  1. Enable rewards
  2. Claim grant (20 BAT)
  3. Connect KYC uphold
  4. Set AC to 50 BAT and add verified publishers to AC table
  5. Wait for AC to be triggered
  6. Look at Monthly Statement

Actual result:

two lines for AC, does not indicate source of each
uphold-vg-split

Expected result:

we should add the source for each line

Reproduces how often:

easily

Brave version (brave://version info)

Brave 1.7.82 Chromium: 80.0.3987.162 (Official Build) dev (64-bit)
Revision f2c5dd6138153bb0658091205bd1a1717f16081a-refs/branch-heads/3987@{#1034}
OS macOS Version 10.14.6 (Build 18G3020)

Version/Channel Information:

  • Can you reproduce this issue with the current release? n/a
  • Can you reproduce this issue with the beta channel? yes
  • Can you reproduce this issue with the dev channel? yes
  • Can you reproduce this issue with the nightly channel? yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

cc @NejcZdovc @jenn-rhim @mandar-brave per our conversations

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented May 4, 2020

Verification passed on

Brave 1.9.52 Chromium: 81.0.4044.129 (Official Build) dev (64-bit)
Revision 3d71af9f5704a40b85806f4d08925db24605ba25-refs/branch-heads/4044@{#979}
OS Windows 10 OS Version 1803 (Build 17134.1006)

Verification passed on

Brave 1.9.62 Chromium: 81.0.4044.138 (Official Build) dev (64-bit)
Revision 8c6c7ba89cc9453625af54f11fd83179e23450fa-refs/branch-heads/4044@{#999}
OS Ubuntu 18.04 LTS

image


Verified passed with

Brave | 1.9.70 Chromium: 81.0.4044.138 (Official Build) (64-bit)
-- | --
Revision | 8c6c7ba89cc9453625af54f11fd83179e23450fa-refs/branch-heads/4044@{#999}
OS | macOS Version 10.14.6 (Build 18G3020)

Note - due to issue on Uphold sandbox env, the uphold portion of my AC did not complete. Per discussion, I have tested this issue w/o the Uphold portion. If error is resolved prior to release, I will retest this scenario.

8986

@LaurenWags

This comment has been minimized.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment