Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove publisher channel id containing landing TLD+1 for ad notification confirmations #8833

Closed
tmancey opened this issue Mar 24, 2020 · 1 comment · Fixed by brave/brave-core#5033
Closed

Remove publisher channel id containing landing TLD+1 for ad notification confirmations #8833

tmancey opened this issue Mar 24, 2020 · 1 comment · Fixed by brave/brave-core#5033
Assignees
@tmancey
Labels
bug feature/ads priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-Plan-Specified QA/Yes release-notes/exclude
Milestone
1.7.x - Release

Comments

@tmancey
Copy link
Contributor

tmancey commented Mar 24, 2020 •
edited by kjozwiak
Loading

Description

Remove publisher channel id for ad notification confirmations

Steps to Reproduce

  1. View an ad notification

Some more QAing info can be found via brave/brave-core#5033 (comment).

Actual result:

Expected result:

channelId should not be sent to the POST /v1/confirmation/{confirmation_id}/{credential} end-point

Reproduces how often:

Easily reproduced

Brave version (brave://version info)

Version/Channel Information:

  • Can you reproduce this issue with the current release? No
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the dev channel?
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:
@tmancey tmancey self-assigned this Mar 24, 2020
@tmancey tmancey added this to the 1.8.x - Nightly milestone Mar 24, 2020
@tmancey tmancey mentioned this issue Mar 24, 2020
Merged
32 tasks
@tmancey tmancey added the priority/P1 A very extremely bad problem. We might push a hotfix for it. label Mar 24, 2020
@tmancey tmancey mentioned this issue Mar 24, 2020
Merged
4 tasks
@tmancey tmancey added QA/Yes release/blocking priority/P3 The next thing for us to work on. It'll ride the trains. and removed priority/P1 A very extremely bad problem. We might push a hotfix for it. release/blocking labels Mar 24, 2020
@tmancey tmancey changed the title Remove publisher channel id for ad notification confirmations Remove publisher channel id containing landing TLD+1 for ad notification confirmations Mar 24, 2020
@tmancey tmancey added priority/P2 A bad problem. We might uplift this to the next planned release. and removed priority/P3 The next thing for us to work on. It'll ride the trains. labels Mar 24, 2020
@kjozwiak
Copy link
Member

kjozwiak commented Mar 31, 2020 •
edited by GeetaSarvadnya
Loading

Verification PASSED on macOS 10.15.3 x64 Catalina using the following build:

Brave | 1.7.79 Chromium: 80.0.3987.149 (Official Build) dev (64-bit)
-- | --
Revision | 5f4eb224680e5d7dca88504586e9fd951840cac6-refs/branch-heads/3987_137@{#16}
OS | macOS Version 10.15.3 (Build 19D76)
  • ensured that ads were being displayed every ~12min when Maximum number of ads displayed was set to 5 ads per hour
  • ensured Ad notifications received this month was correctly being incremented
  • ensured that ads are being added into the 7-day Ads History without any issues
  • ensured that view, clicked, landed, dismiss all worked as expected and "channelId": wasn't being used in the Body: of POST /v1/confirmation/{confirmation_id}/{credential}
[40584:775:0331/163215.313780:INFO:confirmations_impl.cc(1141)] Confirm ad:
  creativeInstanceId: 42b66e18-dc36-46f6-85ee-7c27a69413d2
  creativeSetId: 5796c957-c494-4e95-b2f0-b6b7f138b7e8
  category: arts & entertainment
  targetUrl: https://track.fiverr.com/visit/?bta=75548&nci=6969
  confirmationType: view
[40584:775:0331/163215.313805:INFO:redeem_token.cc(57)] Redeem
[40584:775:0331/163215.313822:INFO:confirmations_impl.cc(743)] Saving confirmations state
[40584:775:0331/163215.314253:INFO:redeem_token.cc(107)] CreateConfirmation
[40584:775:0331/163215.314269:INFO:redeem_token.cc(109)] POST /v1/confirmation/{confirmation_id}/{credential}
[40584:775:0331/163215.314277:INFO:redeem_token.cc(112)] URL Request:
[40584:775:0331/163215.314286:INFO:redeem_token.cc(115)]   URL: https://ads-serve.brave.com/v1/confirmation/2667188b-9723-43a8-a968-e94d817c37af/eyJwYXlsb2FkIjoie1wiYmxpbmRlZFBheW1lbnRUb2tlblwiOlwiSmd5WTJkSVJCUFVxVHR4V0dKWitBNExieDJuSmZDRTI4SnZ1ZytNSkVraz1cIixcImNyZWF0aXZlSW5zdGFuY2VJZFwiOlwiNDJiNjZlMTgtZGMzNi00NmY2LTg1ZWUtN2MyN2E2OTQxM2QyXCIsXCJwYXlsb2FkXCI6e30sXCJ0eXBlXCI6XCJ2aWV3XCJ9Iiwic2lnbmF0dXJlIjoiTVRUZFpjMVlGMFFaUTNEcE1tV3h0THJwY0tYdG9qMy9hR2RkaHI2YjNqWmRXbWpGOWFEbndKOUh5NlVDV2plWjd1NEV3N2ZPSTFNWTA4UHp3eWp1TFE9PSIsInQiOiJJUWNEcjZ1M2lxTUwzYXZOWG9JOE9VZmVKRyt2c3Vrbi9TVDZubEVSSUxQL25GYklJOUFmT1FlWG9pNmw1R2ZVbTcvMzlEN0FtaGhwUW0yRXR3YUZnQT09In0=
[40584:775:0331/163215.314302:INFO:redeem_token.cc(123)]   Body: {"blindedPaymentToken":"JgyY2dIRBPUqTtxWGJZ+A4Lbx2nJfCE28Jvug+MJEkk=","creativeInstanceId":"42b66e18-dc36-46f6-85ee-7c27a69413d2","payload":{},"type":"view"}
[40584:775:0331/163215.314311:INFO:redeem_token.cc(126)]   Headers:
[40584:775:0331/163215.314318:INFO:redeem_token.cc(128)]     accept: application/json
[40584:775:0331/163215.314324:INFO:redeem_token.cc(132)]   Content_type: application/json
[40584:775:0331/163215.314350:INFO:refill_tokens.cc(50)] Refill
[40584:775:0331/163215.314360:INFO:refill_tokens.cc(75)] RequestSignedTokens
[40584:775:0331/163215.314367:INFO:refill_tokens.cc(78)] No need to refill tokens as we already have 49 unblinded tokens which is above the minimum threshold of 20

[40584:775:0331/163220.071731:INFO:confirmations_impl.cc(1141)] Confirm ad:
  creativeInstanceId: 42b66e18-dc36-46f6-85ee-7c27a69413d2
  creativeSetId: 5796c957-c494-4e95-b2f0-b6b7f138b7e8
  category: arts & entertainment
  targetUrl: https://track.fiverr.com/visit/?bta=75548&nci=6969
  confirmationType: click
[40584:775:0331/163220.071778:INFO:redeem_token.cc(57)] Redeem
[40584:775:0331/163220.071804:INFO:confirmations_impl.cc(743)] Saving confirmations state
[40584:775:0331/163220.072365:INFO:redeem_token.cc(107)] CreateConfirmation
[40584:775:0331/163220.072384:INFO:redeem_token.cc(109)] POST /v1/confirmation/{confirmation_id}/{credential}
[40584:775:0331/163220.072393:INFO:redeem_token.cc(112)] URL Request:
[40584:775:0331/163220.072401:INFO:redeem_token.cc(115)]   URL: https://ads-serve.brave.com/v1/confirmation/57a07be2-2967-426e-a93d-8262eaee59e0/eyJwYXlsb2FkIjoie1wiYmxpbmRlZFBheW1lbnRUb2tlblwiOlwiZEttV09udmI1QlF4MUFwbTR4WGd6Y3l6UjRXU0dBcjBzRCtYWXlTalRoMD1cIixcImNyZWF0aXZlSW5zdGFuY2VJZFwiOlwiNDJiNjZlMTgtZGMzNi00NmY2LTg1ZWUtN2MyN2E2OTQxM2QyXCIsXCJwYXlsb2FkXCI6e30sXCJ0eXBlXCI6XCJjbGlja1wifSIsInNpZ25hdHVyZSI6IjRuOEJNNzNGdmhUdmZacHVqRUtNWFJjSXlyOW1YU1VwdGg5bWgzRFRncVQ5VTNHZ0hwdEVwOStMWVlRZ25YaWF4QmZkd2p4ZVhmZmQ5d0s2TGY2NVNRPT0iLCJ0IjoiNWo1c1dNaFVoUzlVZWJzL1czRDFwMHZSb0VIQ2poK1kxYW96VEUzTGNRK3BiamlydDg3TWR6WVdXUDhkcTVpeXRLSmN6U2FDZWorWk5HK1ZFU21qY3c9PSJ9
[40584:775:0331/163220.072417:INFO:redeem_token.cc(123)]   Body: {"blindedPaymentToken":"dKmWOnvb5BQx1Apm4xXgzcyzR4WSGAr0sD+XYySjTh0=","creativeInstanceId":"42b66e18-dc36-46f6-85ee-7c27a69413d2","payload":{},"type":"click"}
[40584:775:0331/163220.072426:INFO:redeem_token.cc(126)]   Headers:
[40584:775:0331/163220.072433:INFO:redeem_token.cc(128)]     accept: application/json
[40584:775:0331/163220.072440:INFO:redeem_token.cc(132)]   Content_type: application/json
[40584:775:0331/163220.072464:INFO:refill_tokens.cc(50)] Refill
[40584:775:0331/163220.072480:INFO:refill_tokens.cc(75)] RequestSignedTokens
[40584:775:0331/163220.072492:INFO:refill_tokens.cc(78)] No need to refill tokens as we already have 48 unblinded tokens which is above the minimum threshold of 20

[40584:775:0331/165812.132046:INFO:confirmations_impl.cc(1141)] Confirm ad:
  creativeInstanceId: dcf95fe1-cca8-42fd-bb05-f24cf6cc2bfb
  creativeSetId: 5796c957-c494-4e95-b2f0-b6b7f138b7e8
  category: arts & entertainment
  targetUrl: https://track.fiverr.com/visit/?bta=75548&nci=6968
  confirmationType: dismiss
[40584:775:0331/165812.132082:INFO:redeem_token.cc(57)] Redeem
[40584:775:0331/165812.132105:INFO:confirmations_impl.cc(743)] Saving confirmations state
[40584:775:0331/165812.132688:INFO:redeem_token.cc(107)] CreateConfirmation
[40584:775:0331/165812.132711:INFO:redeem_token.cc(109)] POST /v1/confirmation/{confirmation_id}/{credential}
[40584:775:0331/165812.132723:INFO:redeem_token.cc(112)] URL Request:
[40584:775:0331/165812.132738:INFO:redeem_token.cc(115)]   URL: https://ads-serve.brave.com/v1/confirmation/06dad817-9b4e-4b3e-add5-73f9ef960f68/eyJwYXlsb2FkIjoie1wiYmxpbmRlZFBheW1lbnRUb2tlblwiOlwiUHFiTXpKaFE3aWNPY1pZM1B6M1l6M0FGdUtsSlJqUm52b3ZxRkRYQXpFND1cIixcImNyZWF0aXZlSW5zdGFuY2VJZFwiOlwiZGNmOTVmZTEtY2NhOC00MmZkLWJiMDUtZjI0Y2Y2Y2MyYmZiXCIsXCJwYXlsb2FkXCI6e30sXCJ0eXBlXCI6XCJkaXNtaXNzXCJ9Iiwic2lnbmF0dXJlIjoiWjBPUFJDZENLd2NHOVNoYkF0Skk1Qk1aQ2ZwN29LUUNnQTNxK3NNMnJKVlk5K2FjNUtRTFdrdk42bE9UMHF0UXQ2eEhtNHBEVlBlK3JEM28yVTE0eUE9PSIsInQiOiJXUlF6OXpZUVhrOHFKU3dlOVBRSXZ0dG0yODg3NDNCV0Y5NWNoQ2ZiaGY5cHRsWEY3STBsTWVObVd0V2k0YVNHcXRzWXc2bG5UdTNaK0JoKzkxaENkdz09In0=
[40584:775:0331/165812.132760:INFO:redeem_token.cc(123)]   Body: {"blindedPaymentToken":"PqbMzJhQ7icOcZY3Pz3Yz3AFuKlJRjRnvovqFDXAzE4=","creativeInstanceId":"dcf95fe1-cca8-42fd-bb05-f24cf6cc2bfb","payload":{},"type":"dismiss"}
[40584:775:0331/165812.132774:INFO:redeem_token.cc(126)]   Headers:
[40584:775:0331/165812.132784:INFO:redeem_token.cc(128)]     accept: application/json
[40584:775:0331/165812.132793:INFO:redeem_token.cc(132)]   Content_type: application/json
[40584:775:0331/165812.132824:INFO:refill_tokens.cc(50)] Refill
[40584:775:0331/165812.132840:INFO:refill_tokens.cc(75)] RequestSignedTokens
[40584:775:0331/165812.132850:INFO:refill_tokens.cc(78)] No need to refill tokens as we already have 45 unblinded tokens which is above the minimum threshold of 20
[40585:775:0331/165812.147410:INFO:ad_notifications.cc(310)] Successfully saved notifications state

[40584:775:0331/172651.531354:INFO:confirmations_impl.cc(1141)] Confirm ad:
  creativeInstanceId: 17eff3b0-9b33-4d3a-ad22-7d685168edbd
  creativeSetId: b0bcf11e-04ca-4c72-a624-dd4b9e6dab82
  category: technology & computing
  targetUrl: https://get-express-vpns.com/ca/?trvid=10135&trvx=159e78e2&var1=xxx
  confirmationType: landed
[40584:775:0331/172651.531400:INFO:redeem_token.cc(57)] Redeem
[40584:775:0331/172651.531432:INFO:confirmations_impl.cc(743)] Saving confirmations state
[40584:775:0331/172651.532303:INFO:redeem_token.cc(107)] CreateConfirmation
[40584:775:0331/172651.532340:INFO:redeem_token.cc(109)] POST /v1/confirmation/{confirmation_id}/{credential}
[40584:775:0331/172651.532357:INFO:redeem_token.cc(112)] URL Request:
[40584:775:0331/172651.532373:INFO:redeem_token.cc(115)]   URL: https://ads-serve.brave.com/v1/confirmation/5e378e3a-d260-45bd-a8e9-acf5d2e0b3b1/eyJwYXlsb2FkIjoie1wiYmxpbmRlZFBheW1lbnRUb2tlblwiOlwiN0E5cGtmRmdaVEhYVGNyUHJ4ODdWcFdHcEdpZmExcER2dFJnUnZabEFrUT1cIixcImNyZWF0aXZlSW5zdGFuY2VJZFwiOlwiMTdlZmYzYjAtOWIzMy00ZDNhLWFkMjItN2Q2ODUxNjhlZGJkXCIsXCJwYXlsb2FkXCI6e30sXCJ0eXBlXCI6XCJsYW5kZWRcIn0iLCJzaWduYXR1cmUiOiIvQXNFMUtuS090eGEzVkIwY0tSSWp5WjR5dFpEeXpBMWJKcWVUNkZwclBXRGc1L0hucVZMVFlqc3Jwd29hVU1pa2dYUzZrUi9IYXBzMCtqaE5WdTI0QT09IiwidCI6InBRandrL09GVTI1RWw5dmpuSkhLSWpCditjdmpNeW5JeUQzYURoQklnM0Q1VkhpQlpRLy90V0lWeGNpd1NvaEUrcXV4UkN5YW9sMWxJTFJENVkzR01BPT0ifQ==
[40584:775:0331/172651.532402:INFO:redeem_token.cc(123)]   Body: {"blindedPaymentToken":"7A9pkfFgZTHXTcrPrx87VpWGpGifa1pDvtRgRvZlAkQ=","creativeInstanceId":"17eff3b0-9b33-4d3a-ad22-7d685168edbd","payload":{},"type":"landed"}
[40584:775:0331/172651.532423:INFO:redeem_token.cc(126)]   Headers:
[40584:775:0331/172651.532440:INFO:redeem_token.cc(128)]     accept: application/json
[40584:775:0331/172651.532462:INFO:redeem_token.cc(132)]   Content_type: application/json
[40584:775:0331/172651.532530:INFO:refill_tokens.cc(50)] Refill
[40584:775:0331/172651.532548:INFO:refill_tokens.cc(75)] RequestSignedTokens
[40584:775:0331/172651.532559:INFO:refill_tokens.cc(78)] No need to refill tokens as we already have 42 unblinded tokens which is above the minimum threshold of 20

Screen Shot 2020-03-31 at 5 42 54 PM

Verification passed on

Brave 1.7.79 Chromium: 80.0.3987.149 (Official Build) dev (64-bit)
Revision 5f4eb224680e5d7dca88504586e9fd951840cac6-refs/branch-heads/3987_137@{#16}
OS Ubuntu 18.04 LTS
  • ensured that ads were being displayed every ~12min when Maximum number of ads displayed was set to 5 ads per hour
  • ensured Ad notifications received this month was correctly being incremented
  • ensured that ads are being added into the 7-day Ads History without any issues
  • ensured that view, clicked, landed, dismiss all worked as expected and "channelId": wasn't being used in the Body: of POST /v1/confirmation/{confirmation_id}/{credential}
    Example:
[27944:27944:0401/045719.432732:INFO:ads_service_impl.cc(2136)] AdsService Event Log: {"data":{"type":"confirmation","timestamp":"2020-04-01T04:57:19Z","creativeInstanceId":"632b8b68-f6d6-4e8e-ac04-5a4e462aa9dd","confirmationType":"view"}}
[27977:27977:0401/045719.433015:INFO:confirmations_impl.cc(1141)] Confirm ad:
  creativeInstanceId: 632b8b68-f6d6-4e8e-ac04-5a4e462aa9dd
  creativeSetId: b2054163-9998-4b88-aa0c-9939f55d414a
  category: arts & entertainment
  targetUrl: https://travala.com/
  confirmationType: view
[27977:27977:0401/045719.433172:INFO:redeem_token.cc(57)] Redeem
[27977:27977:0401/045719.433199:INFO:confirmations_impl.cc(743)] Saving confirmations state
[27978:1:0401/045719.433940:INFO:client.cc(668)] Successfully saved client state
[27977:27977:0401/045719.434776:INFO:redeem_token.cc(107)] CreateConfirmation
[27977:27977:0401/045719.434798:INFO:redeem_token.cc(109)] POST /v1/confirmation/{confirmation_id}/{credential}
[27977:27977:0401/045719.434804:INFO:redeem_token.cc(112)] URL Request:
[27977:27977:0401/045719.434811:INFO:redeem_token.cc(115)]   URL: https://ads-serve.bravesoftware.com/v1/confirmation/f8e1a0b1-ec74-4dba-b34a-81561f291b22/eyJwYXlsb2FkIjoie1wiYmxpbmRlZFBheW1lbnRUb2tlblwiOlwicUFPVFBaMWxQeVBmZWI1ek1zTjJsQ2QzV29qK2pJMUNUNHlhOFVQMXdIdz1cIixcImNyZWF0aXZlSW5zdGFuY2VJZFwiOlwiNjMyYjhiNjgtZjZkNi00ZThlLWFjMDQtNWE0ZTQ2MmFhOWRkXCIsXCJwYXlsb2FkXCI6e30sXCJ0eXBlXCI6XCJ2aWV3XCJ9Iiwic2lnbmF0dXJlIjoiL3hrQWJOREtDT1BPQTFPQjY3MkdVUW9IcjFRTUNSN0dmSTg4cVFkU2REeG9QQXF5V1ZZQnR6WDNOQy9SZ21NSDJNNkQ5UGVlbUFvNU5QWXZYemZ0K0E9PSIsInQiOiJwcTluRjdmQW9ua1MzNFF6VHRLYUM3ekw5ZW5xSDhheHdBRmNoekRKWXZFVXNUbE0xbHhBV1RscGV1OGEyWDBuaUs3cWRwSWFLMTZvQVI4dmZma0ZzQT09In0=
[27977:27977:0401/045719.434825:INFO:redeem_token.cc(123)]   Body: {"blindedPaymentToken":"qAOTPZ1lPyPfeb5zMsN2lCd3Woj+jI1CT4ya8UP1wHw=","creativeInstanceId":"632b8b68-f6d6-4e8e-ac04-5a4e462aa9dd","payload":{},"type":"view"}

Verification passed on

Brave 1.7.79 Chromium: 80.0.3987.149 (Official Build) dev (64-bit)
Revision 5f4eb224680e5d7dca88504586e9fd951840cac6-refs/branch-heads/3987_137@{#16}
OS Windows 10 OS Version 1803 (Build 17134.1006)
  • ensured that ads were being displayed every ~12min when Maximum number of ads displayed was set to 5 ads per hour
  • ensured Ad notifications received this month was correctly being incremented
  • ensured that ads are being added into the 7-day Ads History without any issues
  • ensured that view, clicked, landed, dismiss all worked as expected and "channelId": wasn't being used in the Body: of POST /v1/confirmation/{confirmation_id}/{credential}

Example:

[18752:15856:0401/103017.664:INFO:confirmations_impl.cc(1141)] Confirm ad:
  creativeInstanceId: 2395abb3-33c8-44ab-a3c1-384cd6f568eb
  creativeSetId: 656240d9-40bf-4187-a4fe-0cea8d4d186b
  category: arts & entertainment
  targetUrl: https://proton.go2cloud.org/aff_c?offer_id=15&aff_id=1397
  confirmationType: view
[18752:15856:0401/103017.664:INFO:redeem_token.cc(57)] Redeem
[18752:15856:0401/103017.664:INFO:confirmations_impl.cc(743)] Saving confirmations state
[18752:15856:0401/103017.665:INFO:redeem_token.cc(107)] CreateConfirmation
[18752:15856:0401/103017.665:INFO:redeem_token.cc(109)] POST /v1/confirmation/{confirmation_id}/{credential}
[18752:15856:0401/103017.665:INFO:redeem_token.cc(112)] URL Request:
[18752:15856:0401/103017.665:INFO:redeem_token.cc(115)]   URL: https://ads-serve.brave.com/v1/confirmation/89b12bdf-d81c-4468-9275-ac90d857908d/eyJwYXlsb2FkIjoie1wiYmxpbmRlZFBheW1lbnRUb2tlblwiOlwiaktzLytzbURnTzRLdE8zMXBQL0wyV1lYU04wSmx4K1ZuK3BtWHpkbE1Gcz1cIixcImNyZWF0aXZlSW5zdGFuY2VJZFwiOlwiMjM5NWFiYjMtMzNjOC00NGFiLWEzYzEtMzg0Y2Q2ZjU2OGViXCIsXCJwYXlsb2FkXCI6e30sXCJ0eXBlXCI6XCJ2aWV3XCJ9Iiwic2lnbmF0dXJlIjoiTEtRTnlJTFI0aS91VU1oRS9WdVBmSHd2NEgwYTVheGZnME9NK0h6ZHlZa3pwQUpKM2ZUQU1aUndDNHVPZ0IxK1JaZnpYelNjRURSanB4Z25UbDUvZFE9PSIsInQiOiJwWTFNY1VObERPZUFGaWZWT1lDRkJxb1lBb0N5SzRRVzhvL3VjakMvSGZxU3ZPMHZnOHovc3ZZa0kxa3RQU2phT2VCRWIzOEgvVGR0WHZZVFhmZjVrdz09In0=
[18752:15856:0401/103017.665:INFO:redeem_token.cc(123)]   Body: {"blindedPaymentToken":"jKs/+smDgO4KtO31pP/L2WYXSN0Jlx+Vn+pmXzdlMFs=","creativeInstanceId":"2395abb3-33c8-44ab-a3c1-384cd6f568eb","payload":{},"type":"view"}
[18752:15856:0401/103017.665:INFO:redeem_token.cc(126)]   Headers:
[18752:15856:0401/103017.665:INFO:redeem_token.cc(128)]     accept: application/json
[18752:15856:0401/103017.665:INFO:redeem_token.cc(132)]   Content_type: application/json
[18752:15856:0401/103017.665:INFO:refill_tokens.cc(50)] Refill
[18752:15856:0401/103017.665:INFO:refill_tokens.cc(75)] RequestSignedTokens
[18752:15856:0401/103017.665:INFO:refill_tokens.cc(78)] No need to refill tokens as we already have 49 unblinded tokens which is above the minimum threshold of 20

tmancey pushed a commit that referenced this issue Apr 9, 2020
@kjozwiak
Merge pull request #5034 from /issues/8833-1.7.x
ef3d8f6 
Fixes remove publisher channel id containing landing TLD+1 for ad notification confirmations - 1.7.x
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tmancey tmancey

Labels
bug feature/ads priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-Plan-Specified QA/Yes release-notes/exclude
Projects
None yet
Milestone
1.7.x - Release
5 participants
@tmancey @kjozwiak @rebron @btlechowski @GeetaSarvadnya