Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tokens are not successfully unblinded #8207

Closed
NejcZdovc opened this issue Feb 12, 2020 · 2 comments · Fixed by brave/brave-core#4602
Closed

Tokens are not successfully unblinded #8207

NejcZdovc opened this issue Feb 12, 2020 · 2 comments · Fixed by brave/brave-core#4602

Comments

@NejcZdovc
Copy link
Contributor

NejcZdovc commented Feb 12, 2020

Description

Steps to Reproduce

  1. Enable rewards
  2. Close rewards tab and close the browser
  3. Get payment ID and add multiple grants that has legacy flag set to true
  4. Start the browser and immediately open the panel, and reopen it multiple times right one after another

QA Note: Because the above is going to be really hard to reproduce, we'll run through the STR that @NejcZdovc provided via brave/brave-core#4602. We'll also send the RC to several users that were affected by the issue to make sure that they're able to recover their BAT before releasing.

Actual result:

Balance is not correct (unblinded token table is not populated correctly)

Expected result:

Balance should be correct (all tokens should be converted)

Reproduces how often:

hard as you need to be really fast for step 3

Brave version (brave://version info)

1.3.x

Version/Channel Information:

  • Can you reproduce this issue with the current release?
  • Can you reproduce this issue with the beta channel?
  • Can you reproduce this issue with the dev channel?
  • Can you reproduce this issue with the nightly channel?

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

@kjozwiak
Copy link
Member

Should be able to QA this once we get 1.3.116 which as been started 👍

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Feb 18, 2020

Verification passed on

Brave 1.3.116 Chromium: 80.0.3987.106 (Official Build) (64-bit)
Revision f68069574609230cf9b635cd784cfb1bf81bb53a-refs/branch-heads/3987@{#882}
OS Windows 10 OS Version 1803 (Build 17134.1006)
[ REQUEST ]
> url: https://grant.rewards.bravesoftware.com/v1/promotions/reportclobberedclaims
> method: UrlMethod::POST
> content: {"claimIds":["73fee529-42cb-496e-ad8a-89531f58b646"]}
> contentType: application/json; charset=utf-8
[ END REQUEST ]
  • ensured that both the promotion and promotion_creds tables were empty in publisher_info_db once the browser was restarted.

Verified passed with

Brave 1.3.117 Chromium: 80.0.3987.106 (Official Build) (64-bit)
Revision f68069574609230cf9b635cd784cfb1bf81bb53a-refs/branch-heads/3987@{#882}
OS macOS Version 10.14.6 (Build 18G3020)
[ REQUEST ]
> url: https://grant.rewards.bravesoftware.com/v1/promotions/reportclobberedclaims
> method: UrlMethod::POST
> content: {"claimIds":["55130647-b217-4b33-8dc7-64b662eb2348"]}
> contentType: application/json; charset=utf-8
[ END REQUEST ]
  • Verified that both the promotion and promotion_creds tables were empty in publisher_info_db once the browser was restarted.

Verification PASSED on Mint 19.1 x64 using the following build:

Brave 1.3.116 Chromium: 80.0.3987.106 (Official Build) (64-bit)
Revision f68069574609230cf9b635cd784cfb1bf81bb53a-refs/branch-heads/3987@{#882}
OS Linux (Mint 19.1 x64)

Ensured that the following request was being made once publisher_info_db was corrupted as per the STR:

[ RESPONSE - OnClaimTokens ]
> time: 1582075108
> result: Success
> http code: 200
> response: {"claimId":"70330129-56d3-488d-a5e5-0142dd430e30"}
[ REQUEST ]
> url: https://grant.rewards.brave.software/v1/promotions/reportclobberedclaims
> method: UrlMethod::POST
> content: {"claimIds":["70330129-56d3-488d-a5e5-0142dd430e30"]}
> contentType: application/json; charset=utf-8
[ END REQUEST ]
  • Verified that both the promotion and promotion_creds tables were empty in publisher_info_db once the browser was restarted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment