Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewards settings in BR panel is not accessible in 0.70.x and above #6336

Closed
GeetaSarvadnya opened this issue Oct 7, 2019 · 3 comments · Fixed by brave/brave-core#3631
Closed

Comments

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Oct 7, 2019

Description

Rewards settings button is not accessible in 0.70.x and above versions

Steps to Reproduce

  1. Clean profile 0.70.109
  2. Join rewards
  3. Turn OFF brave rewards switch in the rewards settings page
  4. Verify wallet with existing KYC'd uphold account
  5. Navigate to brave://rewards page
  6. Open the BR panel and click on the Rewards settings
  7. Click on Rewards settings don't open brave://rewards page in a new tab
  8. Open a new tab, click on BR panel click on Rewards Settings in BR panel
  9. brave://rewards page isn't opened in a new tab

Actual result:

Click on Rewards settings don't open brave://rewards page in a new tab
image

Expected result:

Click on Rewards settings should open brave://rewards page in a new tab

Reproduces how often:

Always

Brave version (brave://version info)

Brave 0.70.109 Chromium: 77.0.3865.90 (Official Build) beta (64-bit)
Revision 58c425ba843df2918d9d4b409331972646c393dd-refs/branch-heads/3865@{#830}
OS Windows 10 OS Version 1803 (Build 17134.1006)

Version/Channel Information:

  • Can you reproduce this issue with the current release? No
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the dev channel? Yes
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards? NA
  • Is the issue reproducible on the latest version of Chrome? NA

Miscellaneous Information:

cc: @mandar-brave @NejcZdovc @brave/legacy_qa

@GeetaSarvadnya GeetaSarvadnya changed the title Rewards settings in BR panel is not accessible in 0.70.x Rewards settings in BR panel is not accessible in 0.70.x and above Oct 7, 2019
@LaurenWags
Copy link
Member

Reproduced on macOS

Brave 0.70.110 Chromium: 77.0.3865.90 (Official Build) beta (64-bit)
Revision 58c425ba843df2918d9d4b409331972646c393dd-refs/branch-heads/3865@{#830}
OS macOS Version 10.13.6 (Build 17G5019)

Using these STR:

  1. Clean profile on above build
  2. Enable Rewards
  3. Navigate to brave://rewards (when Rewards are ON, the Rewards Settings button in the panel works.
  4. Disable Rewards and close tab.
  5. Open a new tab.
  6. Click on BAT logo.
  7. Click on Rewards Settings in panel.
    --> Nothing happens.

@btlechowski
Copy link

Reproduced on Ubuntu

Brave 0.70.109 Chromium: 77.0.3865.90 (Official Build) beta (64-bit)
Revision 58c425ba843df2918d9d4b409331972646c393dd-refs/branch-heads/3865@{#830}
OS Ubuntu 18.04 LTS

@GeetaSarvadnya
Copy link
Author

GeetaSarvadnya commented Oct 17, 2019

Verification passed on

Brave 0.70.118 Chromium: 78.0.3904.50 (Official Build) (64-bit)
Revision 2accdc52c79976e264cd2694df6db31d1fccd8e8-refs/branch-heads/3904@{#658}
OS Windows 10 OS Version 1803 (Build 17134.1006)

Verification passed on

Brave 0.70.118 Chromium: 78.0.3904.50 (Official Build) (64-bit)
Revision 2accdc52c79976e264cd2694df6db31d1fccd8e8-refs/branch-heads/3904@{#658}
OS Ubuntu 18.04 LTS

Verified passed with

Brave 0.70.119 Chromium: 78.0.3904.50 (Official Build) (64-bit)
Revision 2accdc52c79976e264cd2694df6db31d1fccd8e8-refs/branch-heads/3904@{#658}
OS macOS Version 10.13.6 (Build 17G5019)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment