certain upgrades are notifying users that Ads are available - follow up to 5434

[LaurenWags]

Description

Found while testing #5434

Certain upgrades are prompting users that 'Brave Ads have arrived'.

This is similar to, but not the same as #4383.

Steps to Reproduce

pre req: be in one of the original Ad regions (US, UK, CAN, FR, GER)

1. Install 0.63.55
2. Enable Rewards
3. Disable Ads only
4. Upgrade on test channel to 0.69.131

Also experienced this when starting with version 0.66.101. Probably applies to other versions as well.

Actual result:

Prompted about Brave Ads have arrived! on BAT logo.

Expected result:

No prompt until #4383 implemented. Even then, seems like a slightly different notification is expected with that issue.

Reproduces how often:

easily

Brave version (brave://version info)

Brave	0.69.131 Chromium: 77.0.3865.90 (Build ufficiale) (a 64 bit)
Revisione	58c425ba843df2918d9d4b409331972646c393dd-refs/branch-heads/3865@{#830}
Sistema operativo	macOS Versione 10.13.6 (Build 17G5019)

Version/Channel Information:

• Can you reproduce this issue with the current release? 0.68.x no, 0.69.x yes
• Can you reproduce this issue with the beta channel? unsure
• Can you reproduce this issue with the dev channel? unsure
• Can you reproduce this issue with the nightly channel? unsure

Other Additional Information:

• Does the issue resolve itself when disabling Brave Shields? n/a
• Does the issue resolve itself when disabling Brave Rewards? probably
• Is the issue reproducible on the latest version of Chrome? n/a

Miscellaneous Information:

cc @brave/legacy_qa @rebron

[btlechowski]

Reproduced on Ubuntu

Brave	0.63.55 Chromium: 74.0.3729.131 (Official Build) (64-bit)
Revision	518a41c1fa7ce1c8bb5e22346e82e42b4d76a96f-refs/branch-heads/3729@{#954}
OS	Ubuntu 18.04 LTS

Brave	0.69.131 Chromium: 77.0.3865.90 (Official Build) (64-bit)
Revision	58c425ba843df2918d9d4b409331972646c393dd-refs/branch-heads/3865@{#830}
OS	Ubuntu 18.04 LTS

[GeetaSarvadnya]

Reproduced in Windows 10 x64 - 0.69.135

• Upgraded build from 0.64.77 to 0.69.135
• Upgraded build from 0.69.132 to 0.69.135
  

[LaurenWags]

Reproduced on macOS:

• Upgraded build from 0.64.77 to 0.69.135
• Upgraded build from 0.69.132 to 0.69.135

[GeetaSarvadnya]

This is reproducible even if browser is restarted. STR is mentioned below:

1. Clean profile 0.70.116
2. Enable rewards
3. Turn off Ads switch
4. Exit and relaunch the browser
5. Enable Ads notification is shown on BAT logo

0.64.77 - Not Reproducible
0.63.55 - Not Reproducible
0.65.121 - Not Reproducible
0.66.101 - Not Reproducible
0.67.125 - Not Reproducible
0.68.142 - Not Reproducible
0.69.135 - Reproducible
0.70.116 - Reproducible

[btlechowski]

Reproduced on

Brave	0.72.103 Chromium: 78.0.3904.50 (Official Build) nightly (64-bit)
Revision	2accdc52c79976e264cd2694df6db31d1fccd8e8-refs/branch-heads/3904@{#658}
OS	Linux

1. Installed 0.69.x.
2. Enabled rewards
3. Disabled ads
4. Upgraded to 0.72.x
   

[tmancey]

@LaurenWags Can this issue please be retested as part of #6612 when merged

[GeetaSarvadnya]

The issue is still reproducible in Windows 10 x64 - 0.71.111 followed the STR from #6270 (comment)

[tmancey]

@GeetaSarvadnya 6612 was only just merged to nightly. Please test in latest nightly with 6612. Thanks

[btlechowski]

@tmancey The issue is still reproducible

Brave	1.2.11 Chromium: 78.0.3904.108 (Official Build) dev (64-bit)
Revision	4b26898a39ee037623a72fcfb77279fce0e7d648-refs/branch-heads/3904@{#889}
OS	Ubuntu 18.04 LTS

Used test plan from #6270 (comment)

[btlechowski]

@tmancey decided that the issue found by @GeetaSarvadnya in #6270 (comment) merits its own ticket. Logged #7133

[tmancey]

Closing issue for retesting as @btlechowski has created #7133 for an edge case. However once users are running a build with #6612 on-boarding will be shown for users who have ads switched-off as part of the migration