Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Welcome Screens are too tall for small screens #5950

Closed
bradleyrichter opened this issue Sep 9, 2019 · 2 comments · Fixed by brave/brave-core#3529
Closed

Welcome Screens are too tall for small screens #5950

bradleyrichter opened this issue Sep 9, 2019 · 2 comments · Fixed by brave/brave-core#3529
Assignees
Labels
about-pages/welcome onboarding Front-end related to helping a new user learn about features within the browser. priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-Plan-Specified QA/Yes release-notes/include

Comments

@bradleyrichter
Copy link

Remove top margin on the right place to reduce stackup height.

image

@rebron rebron added the onboarding Front-end related to helping a new user learn about features within the browser. label Sep 9, 2019
@btlechowski
Copy link

This is very annoying issue which prevents using brave://welcome page on small screens. The reason is that bottom navbar is not visible.

image

Tested on

Brave 0.69.128 Chromium: 77.0.3865.75 (Official Build) (64-bit)
Revision 201e747d032611c5f2785cae06e894cf85be7f8a-refs/branch-heads/3865@{#776}
OS Ubuntu 18.04 LTS

@btlechowski
Copy link

btlechowski commented Oct 9, 2019

Verification passed on

Brave 0.70.110 Chromium: 77.0.3865.90 (Official Build) beta (64-bit)
Revision 58c425ba843df2918d9d4b409331972646c393dd-refs/branch-heads/3865@{#830}
OS Ubuntu 18.04 LTS

welcome page fits small screen
image
Scrollbar is shown when needed
image

Verified passed with

Brave 0.70.111 Chromium: 77.0.3865.90 (Official Build) beta (64-bit)
Revision 58c425ba843df2918d9d4b409331972646c393dd-refs/branch-heads/3865@{#830}
OS macOS Version 10.13.6 (Build 17G5019)
  • Confirmed that when I resize my window to be small the scroll bar appears when needed. Scrollbar is not displayed when window is large enough.

Screen Shot 2019-10-09 at 11 53 44 AM

Screen Shot 2019-10-09 at 11 53 58 AM

Verification passed on

Brave 0.70.116 Chromium: 77.0.3865.90 (Official Build) beta (64-bit)
Revision 58c425ba843df2918d9d4b409331972646c393dd-refs/branch-heads/3865@{#830}
OS Windows 10 OS Version 1803 (Build 17134.1006)
  • Confirmed that when I resize my window to be small the scroll bar appears when needed. Scrollbar is not displayed when window is large enough.

image

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
about-pages/welcome onboarding Front-end related to helping a new user learn about features within the browser. priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-Plan-Specified QA/Yes release-notes/include
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants