Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

URL doesn't update after closing Verify modal #5771

Closed
LaurenWags opened this issue Aug 22, 2019 · 1 comment · Fixed by brave/brave-core#3337
Closed

URL doesn't update after closing Verify modal #5771

LaurenWags opened this issue Aug 22, 2019 · 1 comment · Fixed by brave/brave-core#3337

Comments

@LaurenWags
Copy link
Member

LaurenWags commented Aug 22, 2019

Description

When accessing the user wallet onboarding/verify modal from the rewards panel (accessed via BAT logo), the URL remains brave://rewards#verify. After closing the modal I expected it to go back to brave://rewards. This doesn't happen if you access the modal from brave://rewards page itself.

Steps to Reproduce

  1. Clean install 0.69.x
  2. Enable Rewards
  3. Navigate to brave://rewards
  4. Access onboarding verify modal (click on Verify Wallet, Add Funds, Withdraw Funds, or (verify) in wallet pane footer.
  5. Modal is displayed, URL shown still says brave://rewards.
  6. Close this page, open a new page.
  7. Click on BAT logo, click on Verify Wallet or Add Funds.
  8. brave://rewards/#verify is opened. Close the modal. URL remains brave://rewards/#verify.

Actual result:

verify-URL

Screen Shot 2019-08-22 at 5 54 57 PM

Expected result:

Screen Shot 2019-08-22 at 5 55 21 PM

Reproduces how often:

easily

Brave version (brave://version info)

Brave 0.69.113 Chromium: 76.0.3809.100 (Official Build) beta (64-bit)
Revision ed9d447d30203dc5069e540f05079e493fc1c132-refs/branch-heads/3809@{#990}
OS Mac OS X

Version/Channel Information:

  • Can you reproduce this issue with the current release? n/a
  • Can you reproduce this issue with the beta channel? yes
  • Can you reproduce this issue with the dev channel? unsure
  • Can you reproduce this issue with the nightly channel? unsure

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? n/a
  • Does the issue resolve itself when disabling Brave Rewards? n/a
  • Is the issue reproducible on the latest version of Chrome? n/a

Miscellaneous Information:

cc @mandar-brave

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Oct 7, 2019

Verification passed on

Brave 0.70.109 Chromium: 77.0.3865.90 (Official Build) beta (64-bit)
Revision 58c425ba843df2918d9d4b409331972646c393dd-refs/branch-heads/3865@{#830}
OS Windows 10 OS Version 1803 (Build 17134.1006)
  • Verified the STR from the description

Verified passed with

Brave 0.70.109 Chromium: 77.0.3865.90 (Official Build) beta (64-bit)
Revision 58c425ba843df2918d9d4b409331972646c393dd-refs/branch-heads/3865@{#830}
OS macOS Version 10.13.6 (Build 17G5019)

Verification passed on

Brave 0.70.109 Chromium: 77.0.3865.90 (Official Build) beta (64-bit)
Revision 58c425ba843df2918d9d4b409331972646c393dd-refs/branch-heads/3865@{#830}
OS Ubuntu 18.04 LTS

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment