-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Developer tool doesn't load with remote devices in brave-browser (Desktop) #5640
Comments
@GeetaSarvadnya this may be intentional @pilgrim-brave would this be happening because remote debugging was disabled with #1736 ? |
Very likely. |
We want to re-enable this by proxy. Does this sound ok? @diracdeltas |
How to Clean or upgraded profile????? |
Any idea when we can get this feature back? Removing this is an absolute dealbreaker for most developers (including myself). I feel like this was disabled for no good reason. At least let us decide if we want to download an extra package from Google but have it disabled by default. |
@jumde this would be a great one for you to check out, when you have cycles 😄 (noticed you had already self-assigned). I think the big problem was that files are being fetched remotely. We can likely proxy those... and/or we could put this feature behind a flag PR that disabled this: brave/brave-core#790 |
Please re-enable remote debug 😢 |
@rebron i think we should re-enable this with proxy (sorry for the delay) |
actually enabling behind a flag would be fine if this is easier |
I am a developer and will be switching back to chrome till there is a way for me to re-enable this. This breaks the Lighthouse Audit for me and who knows what else. I had previously been recommending Brave to other developers but not anymore. When I'm developing, I can't risk any issues coming from my tools and making debugging even more complicated. |
This is an absolute deal breaker for any developer. Will be moving back to chrome and not recommending brave to any more developers till we can re-enable this. |
+1. Please bring this feature back. |
Taking a look at this now... I believe we'll be able to add a config flag for this (defaulted to OFF) which allows you to opt-in to the feature. I can make sure a clear log happens in case it's disabled (to make it more obvious). We'll need to have this go through security review too |
Default for this is FALSE (meaning remote debugging is disabled). Setting is global (using local_state), not per-profile. Fixes brave/brave-browser#5640 Fixes brave/brave-browser#3199
Fixed! Will be in our next Nightly (1.3, which is due to ship Feb 4th). We may uplift to 1.2 (Dev, shipping Jan 6th) if there's enough support for it and if no problems are discovered 😄 |
I confirm that this works with Nightly 1.33.3 against a WebView running in React Native on a Nexus 6P device. Thank you! |
Adding |
Fixed in 1.2; waiting for a new BETA build before it can be tested again |
Should be fixed in 1.2.30. |
Verification passed on
Verified using test plan from brave/brave-core#4044 for this issue. Verification passed on
Verified passed with
|
Checked it at Version 1.20.103 Chromium: 88.0.4324.152 (Official Build) (64-bit) Plus not able to find |
@vivek-np Please use
If you use same CR version on Desktop and Android you may not get this message above |
@GeetaSarvadnya i am not getting this option. while chrome tabs are able to inspect |
Test plan
See brave/brave-core#4044
Description
Developer tool doesn't load with remote devices in brave-browser (Desktop). Verified couple of brave versions, the issue persists on all the versions including latest released version.
0.67.125
- Dev tool doesn't load with remote devices0.66.101
- Dev tool doesn't load with remote devices0.65.121
- Dev tool doesn't load with remote devicesSteps to Reproduce
brave://inspect#devices
in Desktopinspect
under the device name in desktopActual result:
Developer tool window launches but never loads
Expected result:
Should load developer tool with remote devices
Reproduces how often:
Always
Brave version (brave://version info)
All brave versions
Version/Channel Information:
Other Additional Information:
Miscellaneous Information:
@brave/legacy_qa
The text was updated successfully, but these errors were encountered: