-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
twitter banner/tipping mismatch issues #5580
Comments
Reproduced this several on
Other examples: |
Not able to recreate on
I have a feeling this is because my linux build is too slow and problem is most likely race condition from Is issue reproduced if 10-15s of wait time is held between page navigation? |
I reproduced one of the cases several times using the following STR @jdkuki:
You'll notice the following: Sending a tip in this state will send the tip my way and not @mandar-brave. However, all the UI components look like the funds should be going to @mandar-brave. You can tell that the tipping banner has 5, 10, 20 BAT listed which is incorrect as @mandar-brave has 1, 5, 10 BAT set. |
@jdkuki Definitely make sure you're signed in on Twitter, as I suspect this problem is tied to new Twitter and you have to be signed in to get that. |
@NejcZdovc @jdkuki I think there's a disconnect when we're saving the publisher info so that we end up with the media key pointing to the wrong user ID. I noticed that there are two ways to call |
Was not able to reproduce exactly but have this issue:
Looks like BAT panel / page browsing doesn't create If you click an inline tip button for user, then go back to their profile page and click panel button, correct info shows up. |
thanks @jdkuki - do you believe the issue above can potentially be causing the issue here? |
not 100% sure but seems like two sides of the same coin |
Reviewed this on a call with @NejcZdovc Unable to reproduce with
But able to easily reproduce with
We should check 0.69.x when Chromium 77 lands in that branch, see if the issue still reproduces. |
@LaurenWags mind going through the above and see if you can reproduce using Used both
I also made sure that the Twitter ID's are correctly being added into the DB via:
Ensured the Twitter's ID are correctly being added in |
Unable to reproduce with
|
thank you are for really pushing hard on testing this one. Will close it for now and let's reopen it if we still have problems |
Description
Sometimes when tipping a Twitter user, there is a mismatch of information on the tip banner, the thank you banner, and if applicable, pending contributions (potentially tips panel as well).
Steps to Reproduce
Actual result:
Gif picks up from step 8 above:
Note that when the tip banner displays, there's a mix of info for
bcrypt
andtorproject
. After tipping when the thank you banner comes up, it saysbcrypt
but you were trying to tiptorproject
.When you go to pending contributions table and click on the sites, it looks like
bcrypt
is listed, however when you click on the site in the table, you see your own info. (bcrypt
was who I tipped in step 5 btw)Expected result:
All info on tipping banner, thank you banner, and pending contributions (or actual tip table), should be for the intended recipient.
Reproduces how often:
easily
Brave version (brave://version info)
Version/Channel Information:
Other Additional Information:
Miscellaneous Information:
cc @mandar-brave @NejcZdovc @brave/legacy_qa
The text was updated successfully, but these errors were encountered: