Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make component updater compatible with NetworkService #5007

Closed
iefremov opened this issue Jun 21, 2019 · 2 comments · Fixed by brave/brave-core#3068
Closed

Make component updater compatible with NetworkService #5007

iefremov opened this issue Jun 21, 2019 · 2 comments · Fixed by brave/brave-core#3068
Labels
feature/updater priority/P1 A very extremely bad problem. We might push a hotfix for it. QA/Test-Plan-Specified QA/Yes

Comments

@iefremov
Copy link
Contributor

(For more context see the parent issue #2351)
(To run the browser with enabled NetworkService use --enable-features=NetworkService)

The component updater problem is rooted at BraveSystemNetworkDelegate. Here we do some hardcoded URL rewrites. It seems that BraveSystemNetworkDelegate is not going to be refactored in the parent issue and should be treated separately. Probably, the way to fix the problem is to make yet another custom URLLoader and/or URLLoaderFactory

@iefremov iefremov added priority/P1 A very extremely bad problem. We might push a hotfix for it. feature/updater labels Jun 21, 2019
@btlechowski
Copy link

Reproduced on

Brave 0.67.111 Chromium: 75.0.3770.100 (Official Build) beta (64-bit)
Revision cd0b15c8b6a4e70c44e27f35c37a4029bad3e3b0-refs/branch-heads/3770@{#1033}
OS Windows 7 Service Pack 1 (Build 7601.24494)

The tor binary is not downloaded with NetworkService flag enabled

@kjozwiak
Copy link
Member

Reproduced on macOS 10.14.5 x64 using the following build:

Brave 0.67.115 Chromium: 76.0.3809.62 (Official Build) beta (64-bit)
Revision 7b77856b3aa34d72f246d12340fc1ded8b2c0e83-refs/branch-heads/3809@{#798}
OS Mac OS X

STR:

  • launch brave using --enable-features=NetworkService
  • open a Tor window and you'll notice that the component isn't being downloaded

Screen Shot 2019-07-24 at 4 45 15 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/updater priority/P1 A very extremely bad problem. We might push a hotfix for it. QA/Test-Plan-Specified QA/Yes
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants