Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ads] Double delay for backoff timers #42537

Closed
5 tasks done
tmancey opened this issue Nov 26, 2024 · 0 comments · Fixed by brave/brave-core#26759
Closed
5 tasks done

[ads] Double delay for backoff timers #42537

tmancey opened this issue Nov 26, 2024 · 0 comments · Fixed by brave/brave-core#26759
Assignees
Labels

Comments

@tmancey
Copy link
Contributor

tmancey commented Nov 26, 2024

Description

Following server requests are affected:

  • Catalog (catalogs would have been fetched every 2 to 6 hours, rather than the expected 1 to 3 hours)
  • Issuers (issuers would have been fetched every 2 to 6 hours, rather than the expected 1 to 3 hours)
  • Confirmation token redemption (only affects retries)
  • Refill confirmation tokens (only affects retries)
  • Geo targeting (subdivision would have been fetched every 1 to 3 days, rather than the expected 0.5 to 1.5 days)

This does not only affect exponential backoffs, it also affects the initial delay when starting the above timers to fetch after a period of time.

@tmancey tmancey added feature/ads OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA/Yes regression release-notes/exclude labels Nov 26, 2024
@tmancey tmancey self-assigned this Nov 26, 2024
@tmancey tmancey added this to Ads Nov 26, 2024
@github-project-automation github-project-automation bot moved this to New issues in Ads Nov 26, 2024
@tmancey tmancey moved this from New issues to In progress in Ads Nov 26, 2024
@tmancey tmancey moved this from In progress to Review in Ads Nov 26, 2024
@tmancey tmancey changed the title [ads] Double delay for backoff timers after initial fetch [ads] Double delay for backoff timers Nov 26, 2024
@github-project-automation github-project-automation bot moved this from Review to Done in Ads Nov 27, 2024
@brave-builds brave-builds added this to the 1.75.x - Nightly milestone Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants