Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ads] Fixes double delay for backoff timers #26759

Merged
merged 1 commit into from
Nov 27, 2024
Merged

[ads] Fixes double delay for backoff timers #26759

merged 1 commit into from
Nov 27, 2024

Conversation

tmancey
Copy link
Collaborator

@tmancey tmancey commented Nov 26, 2024

Resolves brave/brave-browser#42537

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

Confirm catalog fetches occur on browser launch and then between 1 and 3 hours. Issuers fetches occur on browser launch and then between 1 and 3 hours. Geo is fetched on launch and then between 0.5 and 1.5 days.

@tmancey tmancey self-assigned this Nov 26, 2024
@tmancey tmancey requested a review from a team as a code owner November 26, 2024 21:26
@tmancey tmancey enabled auto-merge November 26, 2024 22:09
@tmancey tmancey merged commit 56d3103 into master Nov 27, 2024
18 checks passed
@tmancey tmancey deleted the issues/42537 branch November 27, 2024 13:30
@github-actions github-actions bot added this to the 1.75.x - Nightly milestone Nov 27, 2024
brave-builds added a commit that referenced this pull request Nov 27, 2024
@brave-builds
Copy link
Collaborator

Released in v1.75.56

@btlechowski
Copy link

Verified with

Brave 1.75.84 Chromium: 132.0.6834.33 (Official Build) nightly (64-bit)
Revision 80cd29f
OS Windows 10 Version 22H2 (Build 19045.5131)

subdivision

Verified downloaded on browser launch

[3760:3240:1208/215002.060:VERBOSE1:subdivision.cc(76)] Initialize subdivision URL request
[3760:3240:1208/215002.060:VERBOSE1:subdivision_url_request.cc(58)] Fetch subdivision
[3760:3240:1208/215002.060:VERBOSE6:subdivision_url_request.cc(64)] URL Request:
  URL: https://geo.ads.brave.com/v1/getstate
  Method: kGet
[3760:3240:1208/215002.060:VERBOSE7:subdivision_url_request.cc(65)]   Headers:

Verified downloaded every 0.5 and 1.5 days

	Line  212: [3760:3240:1208/215002.154:VERBOSE1:subdivision_url_request.cc(104)] Fetch subdivision in 17 hours, 28 minutes, 18 seconds at 15:18:20.360
	Line 1129: [3760:3240:1209/151820.418:VERBOSE1:subdivision_url_request.cc(104)] Fetch subdivision on Tuesday, December 10, 2024 at 3:41:40 PM

issuers

Verified downloaded on browser launch

	Line  81: [3760:3240:1208/215002.060:VERBOSE1:issuers_url_request.cc(60)] Fetch issuers

Verified downloaded every 1 and 3 hours

	Line 194: [3760:3240:1208/215002.138:VERBOSE1:issuers_url_request.cc(127)] Fetch issuers in 1 hour, 4 minutes, 54 seconds at 22:54:56.224
	Line 303: [3760:3240:1208/225456.260:VERBOSE1:issuers_url_request.cc(127)] Fetch issuers in 2 hours, 7 minutes, 54 seconds at 01:02:50.702
	Line 374: [3760:3240:1209/010250.726:VERBOSE1:issuers_url_request.cc(127)] Fetch issuers in 2 hours, 20 minutes, 50 seconds at 03:23:40.415
	Line 511: [3760:3240:1209/032340.488:VERBOSE1:issuers_url_request.cc(127)] Fetch issuers in 1 hour, 54 minutes, 2 seconds at 05:17:42.639
	Line 609: [3760:3240:1209/051742.946:VERBOSE1:issuers_url_request.cc(127)] Fetch issuers in 2 hours, 53 minutes, 52 seconds at 08:11:35.049
	Line 710: [3760:3240:1209/081135.309:VERBOSE1:issuers_url_request.cc(127)] Fetch issuers in 2 hours, 13 minutes, 31 seconds at 10:25:06.274
	Line 797: [3760:3240:1209/102506.386:VERBOSE1:issuers_url_request.cc(127)] Fetch issuers in 1 hour, 21 minutes, 46 seconds at 11:46:52.518
	Line 884: [3760:3240:1209/114652.892:VERBOSE1:issuers_url_request.cc(127)] Fetch issuers in 2 hours, 10 minutes, 17 seconds at 13:57:09.471
	Line 966: [3760:3240:1209/135709.590:VERBOSE1:issuers_url_request.cc(127)] Fetch issuers in 1 hour, 24 minutes, 52 seconds at 15:22:01.858

catalog

Verified downloaded on browser launch

[3760:3240:1208/215002.060:VERBOSE1:catalog.cc(83)] Initialize catalog URL request
[3760:3240:1208/215002.060:VERBOSE1:catalog_url_request.cc(62)] Fetch catalog
[3760:3240:1208/215002.060:VERBOSE6:catalog_url_request.cc(68)] URL Request:
  URL: https://static.ads.brave.com/v9/catalog
  Method: kGet
[3760:3240:1208/215002.060:VERBOSE7:catalog_url_request.cc(69)]   Headers:

Verified downloaded every 1 and 3 hours

	Line 167: [3760:3240:1208/215002.138:VERBOSE1:catalog_url_request.cc(121)] Fetch catalog in 1 hour, 2 minutes, 13 seconds at 22:52:14.946
	Line 270: [3760:3240:1208/225215.051:VERBOSE1:catalog_url_request.cc(121)] Fetch catalog in 2 hours, 8 minutes, 1 second at 01:00:16.548
	Line 341: [3760:3240:1209/010016.654:VERBOSE1:catalog_url_request.cc(121)] Fetch catalog in 2 hours, 10 minutes, 32 seconds at 03:10:48.382
	Line 472: [3760:3240:1209/031048.707:VERBOSE1:catalog_url_request.cc(121)] Fetch catalog in 1 hour, 25 minutes, 46 seconds at 04:36:35.135
	Line 567: [3760:3240:1209/043635.256:VERBOSE1:catalog_url_request.cc(121)] Fetch catalog in 2 hours, 53 minutes, 44 seconds at 07:30:18.972
	Line 668: [3760:3240:1209/073019.106:VERBOSE1:catalog_url_request.cc(121)] Fetch catalog in 1 hour, 40 minutes, 36 seconds at 09:10:55.416
	Line 755: [3760:3240:1209/091055.556:VERBOSE1:catalog_url_request.cc(121)] Fetch catalog in 1 hour, 48 minutes, 46 seconds at 10:59:41.808
	Line 845: [3760:3240:1209/105941.944:VERBOSE1:catalog_url_request.cc(121)] Fetch catalog in 2 hours, 9 minutes, 25 seconds at 13:09:06.808
	Line 924: [3760:3240:1209/130908.873:VERBOSE1:catalog_url_request.cc(121)] Fetch catalog in 2 hours, 6 minutes, 20 seconds at 15:15:29.229

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ads] Double delay for backoff timers
4 participants