Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hangouts extension should be off by default #39664

Closed
3 of 6 tasks
ShivanKaul opened this issue Jul 10, 2024 · 3 comments · Fixed by brave/brave-core#24583
Closed
3 of 6 tasks

Hangouts extension should be off by default #39664

ShivanKaul opened this issue Jul 10, 2024 · 3 comments · Fixed by brave/brave-core#24583
Assignees
Labels

Comments

@ShivanKaul
Copy link
Collaborator

ShivanKaul commented Jul 10, 2024

Test plan

See brave/brave-core#24583

Description

While we explore removing the Hangouts extension completely in #39660, we should at least disable the extension by default for users who haven't touched the extension.

Steps to reproduce

  1. Never having touched the Hangouts toggle...
  2. Go to brave://settings/extensions
  3. See Hangouts toggle

Actual result

It's on (by default)

Expected result

It should be off

As a corollary, we should not touch the toggle for users who have touched the toggle.

Reproduces how often

Easily reproduced

Desktop Brave version (brave://version info)

all

Android device

all

Channel information

  • release (stable)
  • beta
  • nightly

Reproducibility

  • with Brave Shields disabled
  • with Brave Rewards disabled
  • in the latest version of Chrome

Miscellaneous information

I think we want to disable in Nightly first and have it ride the trains.

@bsclifton
Copy link
Member

Removed OS/Android - this should be desktop only (Android would require some work to support extensions).

bsclifton added a commit to brave/brave-core that referenced this issue Jul 10, 2024
Fixes brave/brave-browser#39664

Disabling will add the extension to a block list.
This won't affect people who have toggled the setting - for example,
someone who manually enabled or disabled.

Google Meet seems to work great with this extension blocked.

First step towards fixing brave/brave-browser#39660

Long term goal would be to remove the extension code:
https://source.chromium.org/chromium/chromium/src/+/main:chrome/browser/resources/hangout_services/manifest_v3.json;l=24-30
@rebron rebron added this to General Jul 10, 2024
@rebron rebron added the priority/P2 A bad problem. We might uplift this to the next planned release. label Jul 10, 2024
@github-project-automation github-project-automation bot moved this to Completed in General Jul 10, 2024
@brave-builds brave-builds added this to the 1.69.x - Nightly milestone Jul 10, 2024
@rebron rebron removed this from General Jul 10, 2024
@rebron rebron moved this to Completed in Settings Jul 10, 2024
@kjozwiak
Copy link
Member

The above requires 1.67.133 or higher for 1.67.x verification 👍

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Jul 17, 2024

Verification PASSED on

Brave | 1.67.134 Chromium: 126.0.6478.186 (Official Build) (64-bit)
-- | --
Revision | e27c9744a0ed98bfa60e287af7e5eaffde15bd57
OS | Windows 10 Version 22H2 (Build 19045.4651)

Clean profile

  • Confirmed that the extension Hangouts is disabled by default via brave://settings/extensions
    image

Case 1: Upgrade, default - PASSED

  1. installed 1.67.123
  2. launched Brave (release)
  3. opened brave://settings/extensions
  4. confirmed Hangouts is toggled On/Enabled
  5. upgraded to 1.67.134 by renaming Brave-Browser profile to Brave-Browser-Nightly
  6. installed launched Brave 1.67.134
  7. opened brave://settings/extensions

Confirmed Hangouts is toggled Off/Disabled

1.67.123 1.67.134
image image

Case 2: Upgrade, user-modified setting - PASSED

  1. installed and launched 1.67.123 (release)
  2. opened brave://settings/extensions
  3. toggled Hangouts from its default of Enabled to Disabled, and then finally toggled back to Enabled/On
  4. installed 1.67.134
  5. launched Brave
  6. opened brave://settings/extensions
  7. looked at the value for the Hangouts preference

Confirmed Hangouts was still set to Enabled/On

1.67.123 1.67.134
image image

Case 3: Disabling the pref disables the extension - PASSED

Steps:

  1. installed 1.67.123
  2. launched Brave
  3. opened brave://settings/extensions
  4. confirmed Hangouts is set to Disabled/Off
  5. opened brave://extensions-internals
  6. grepped for DISABLE_BLOCKED_BY_DEFAULT
  7. confirmed disable_reasons for the Hangouts extension ID nkeimhogjdpnpccoofpliimaahmaaome was set to the above
  8. loaded google.com
  9. opened the Developer Tools' Console
  10. pasted the following snippet:
chrome.runtime.sendMessage(
  "nkeimhogjdpnpccoofpliimaahmaaome",
  { method: "cpu.getInfo" },
  (response) => {
    console.log(JSON.stringify(response, null, 2));
  },
);
  1. confirmed I got the following error: Uncaught TypeError: Cannot read properties of undefined (reading "sendMessage") at <anonymous>:1:16
brave://settings/extensions brave://extensions-internals Google.com w/ Dev Console
image image image

Case 4: Enabling the pref allows the extension - PASSED

Steps:

  1. installed 1.67.134
  2. launched Brave
  3. opened brave://settings/extensions
  4. toggled Hangouts to Enabled/On
  5. opened brave://extensions-internals
  6. grepped for DISABLE_BLOCKED_BY_DEFAULT
  7. confirmed disable_reasons is NOT present for the Hangouts extension ID nkeimhogjdpnpccoofpliimaahmaaome
  8. loaded google.com
  9. opened the Developer Tools' Console
  10. pasted the following snippet:
chrome.runtime.sendMessage(
  "nkeimhogjdpnpccoofpliimaahmaaome",
  { method: "cpu.getInfo" },
  (response) => {
    console.log(JSON.stringify(response, null, 2));
  },
);
  1. confirmed I got the following output, without errors:
 {
        "usage": {
          "idle": 1704610468750,
          "kernel": 14425000000,
          "total": 1757872812500,
          "user": 38837343750
        }
      }
brave://settings/extensions brave://extensions-internals Google.com w/ Dev Console
image image image

@rebron rebron removed this from Settings Jul 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants