Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update label in brave://settings/newTab #29524

Closed
simonhong opened this issue Apr 5, 2023 · 2 comments · Fixed by brave/brave-core#17935
Closed

Update label in brave://settings/newTab #29524

simonhong opened this issue Apr 5, 2023 · 2 comments · Fixed by brave/brave-core#17935
Assignees
@simonhong
Labels
needs-text-change This change requires some careful wording. OS/Desktop QA Pass-Win64 QA/Test-Plan-Specified QA/Yes release-notes/exclude
Milestone
1.51.x - Release

Comments

@simonhong
Copy link
Member

Change label from Customize the background image and widgets that appear on the new tab page to Customize new tab page.

Screen Shot 2023-04-04 at 11 56 00 PM
@simonhong simonhong self-assigned this Apr 5, 2023
simonhong added a commit to brave/brave-core that referenced this issue Apr 5, 2023
@simonhong
Updated label in brave://settings/newTab
4f9e925 
fix brave/brave-browser#29524
@simonhong simonhong mentioned this issue Apr 5, 2023
Merged
25 tasks
@brave-builds brave-builds added this to the 1.52.x - Nightly milestone Apr 5, 2023
@brave-builds brave-builds mentioned this issue Apr 12, 2023
Merged
7 tasks
@kjozwiak
Copy link
Member

The above requires 1.51.87 or higher for 1.51.x verification 👍

@stephendonner
Copy link

Verified PASSED using

Brave 1.51.87 Chromium: 112.0.5615.49 (Official Build) beta (64-bit)
Revision bd2a7bcb881c11e8cfe3078709382934e3916914-refs/branch-heads/5615@{#936}
OS Windows 10 Version 22H2 (Build 19045.2846)

Confirmed the new string reads Customize new tab page on brave://settings/newTab

image

@rebron rebron added the needs-text-change This change requires some careful wording. label Apr 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@simonhong simonhong

Labels
needs-text-change This change requires some careful wording. OS/Desktop QA Pass-Win64 QA/Test-Plan-Specified QA/Yes release-notes/exclude
Projects
None yet
Milestone
1.51.x - Release
Development

Successfully merging a pull request may close this issue.

Updated label in brave://settings/newTab brave/brave-core
5 participants
@stephendonner @kjozwiak @rebron @simonhong @brave-builds