Use vertical Tabs + Tab Scrolling flag = Brave doesn't open

[ghost]

Description

@sangwoo108 Brave doesn't open/breaks when when Tab Scrolling brave://flags/#scrollable-tabstrip flag is enabled and Use vertical tabs is on.
This doesn't happen when using normal horizontal tabs, so the only workaround is to switch to horizontal tabs before closing the browser, if not, then the easiest solution would be to edit the Local State file to disable the flag or edit Preferences file to disable Use vertical tabs.

Steps to Reproduce

1. Enable brave://flags/#scrollable-tabstrip
2. Enable Use vertical tabs
3. Restart
4. Brave doesn't open.

Brave version (brave://version info)

1.51.2 Chromium: 111.0.5563.50 (Official Build) nightly (64-bit)

[sangwoo108]

Thanks for reporting. I'll take a look ASAP.

[Ayern12]

##how can i do it... Pada Jum, 3 Mac 2023, 18:33 Sangwoo Ko ***@***.***> menulis:

…

Thanks for reporting. I'll take a look ASAP. — Reply to this email directly, view it on GitHub <#28877 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AVINGPZ6OWLPFJQOLS3YGVDW2HCIHANCNFSM6AAAAAAVONHNDY> . You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>

[sangwoo108]

Sorry for the inconvinience. I made a patch so that you can open browser. But scrollable tab strip flag is not fully supported yet under vertical tab strip 😥 Will take a look soonish.

[sangwoo108]

The follow-up issue is here: #28906

[ghost]

Thanks for the quick fix and your work @sangwoo108.

PS. I love the new Shared pinned tab feature. Great work there too and Vertical tabs. 😁👌

[stephendonner]

Verified PASSED using

Brave	1.51.85 Chromium: 112.0.5615.49 (Official Build) beta (x86_64)
Revision	bd2a7bcb881c11e8cfe3078709382934e3916914-refs/branch-heads/5615@{#936}
OS	macOS Version 11.7.6 (Build 20G1231)

Steps:

1. installed 1.51.85
2. launched Brave
3. opened brave://flags
4. confirmed default for brave://flags/#brave-vertical-tabs
5. confirmed default for brave://flags/#scrollable-tabstrip
6. enabled both of the above
7. clicked Relaunch
8. loaded msnbc.com
9. context-clicked and chose Use vertical tabs
10. confirmed no crash
11. loaded a few other sites and continued to use vertical tabs

Confirmed that vertical-tab scrolling, when enabled, no longer breaks Brave (it's known that it needs work, still)

example	example	example	example	example	example