Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shields button text isn't translated in German #26216

Closed
stephendonner opened this issue Oct 24, 2022 · 4 comments · Fixed by brave/brave-core#16100
Closed

Shields button text isn't translated in German #26216

stephendonner opened this issue Oct 24, 2022 · 4 comments · Fixed by brave/brave-core#16100
Assignees

Comments

@stephendonner
Copy link

Description

Shields button text isn't translated in German

Found while testing #22550

Steps to Reproduce

  1. install 1.47.14
  2. launched Brave (in English)
  3. loaded cnn.com
  4. set German as the primary language, via Apple -> System Preferences -> `Language & Region
  5. clicked on the Shields icon in the URL bar
  6. expanded the dialog
  7. clicked on the Blocked-cookies count
  8. looked at the translated string for Shields

Actual result:

Bildschirmfoto 2022-10-24 um 2 15 19 PM

Expected result:

Shields should be translated into German

Reproduces how often:

Brave 1.47.14 Chromium: 107.0.5304.62 (Official Build) nightly (x86_64)
Revision 1eec40d3a5764881c92085aaee66d25075c159aa-refs/branch-heads/5304@{#942}
OS macOS Version 11.7 (Build 20G817)

Brave version (brave://version info)

Version/Channel Information:

  • Can you reproduce this issue with the current release?
  • Can you reproduce this issue with the beta channel?
  • Can you reproduce this issue with the nightly channel?

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

cc @GeetaSarvadnya @rebron @mkarolin

@rebron
Copy link
Collaborator

rebron commented Nov 1, 2022

To double check that this will get fixed in next Transifex request.

@mkarolin
Copy link
Contributor

Fixed via brave/brave-core#16100

@kjozwiak
Copy link
Member

The above requires 1.46.130 or higher for 1.46.x verification 👍

@GeetaSarvadnya
Copy link

Verification PASSED on


Brave | 1.46.130 Chromium: 108.0.5359.62 (Offizieller Build) (64-Bit)
-- | --
Überarbeitung | 041930a89a990cfab0315a2d9f20d6429a4a67cf-refs/branch-heads/5359@{#938}
Betriebssystem | Windows 10 Version 21H2 (Build 19044.2251)

Ensured that Shields text in the shield panel is translated to German locale
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants