"Shields" text in Trackers and ads panel is not translated

[GeetaSarvadnya]

Description

Found while testing #22514
Shields text in Trackers and ads panel is not translated in other locales

Steps to Reproduce

1. Set OS locale to France/Germany/Hindi/Kannada
2. Clean profile 1.38.x
3. Open any site and click on trackers and ads count
4. Shields text in Trackers and ads panel is not translated in other locales

Actual result:

Shields text in Trackers and ads panel is not translated in other locales

Expected result:

Shields text in Trackers and ads panel should be translated to other locales

Reproduces how often:

Easy

Brave version (brave://version info)

Brave	1.38.106 Chromium: 101.0.4951.41 (Offizieller Build) (64-Bit)
Überarbeitung	93c720db8323b3ec10d056025ab95c23a31997c9-refs/branch-heads/4951@{#904}
Betriebssystem	Windows 10 Version 21H2 (Build 19044.1645)

Version/Channel Information:

• Can you reproduce this issue with the current release? No
• Can you reproduce this issue with the beta channel? Yes
• Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

• Does the issue resolve itself when disabling Brave Shields? NA
• Does the issue resolve itself when disabling Brave Rewards? NA
• Is the issue reproducible on the latest version of Chrome? NA

Miscellaneous Information:

cc: @brave/qa-team @rebron @mkarolin

[mkarolin]

I am not sure if this is intentional, but that string (IDS_BRAVE_SHIELDS in components/resources/brave_shields_strings.grdp) is marked as translateable="false". Maybe because we are trying to get Brave out of that string in brave/components/brave_shields/resources/panel/components/tree-list/index.tsx:

{getLocale('braveShields').replace('Brave ', '').trim()}

So this is not a missing translation issue. This needs to get addressed in code.

cc: @nullhook

[btlechowski]

Reproduced in Polish PL locale, for ads and trackers and for scripts blocked

Brave	1.38.107 Chromium: 101.0.4951.41 (Official Build) (64-bit)
Revision	93c720db8323b3ec10d056025ab95c23a31997c9-refs/branch-heads/4951@{#904}
OS	Ubuntu 18.04 LTS

[nullhook]

"Shields" is part of the product name and I'm not sure we should translate this.
Previous shield had "Back" as the button label I believe

[mkarolin]

According to the style guide:

Brave feature names are uppercase, and we always translate (or transliterate) them into other languages. The only exception is the Brave name itself—this should never be translated.

cc: @rmcfadden3 to confirm

[rmcfadden3]

@mkarolin — thx for checking. So, yes, this was the rule. But @laurentiugruia is overseeing localization strategy now, and I'm not sure if that rule has changed. @laurentiugruia — wdyt on this one?

[laurentiugruia]

Confirming the rule from the style guide has not changed.

[petemill]

@laurentiugruia @rmcfadden3 As per my comment at brave/brave-core#14768 (review), is it therefore logical to only have the product name translated (e.g. "Shields") and we prefix the word "Brave" ourselves in the UI? Would Brave always precede the translated product name, in all languages?

[laurentiugruia]

@petemill In some languages Brave precedes the translated "Shields", in other languages it comes after so I think the solution would be to have "Brave Shields" as the string to translate.
Translators will then only translate "Shields" per the Style Guide and handle this situation.

[stephendonner]

Verified PASSED using

Brave	1.46.76 Chromium: 107.0.5304.62 (Official Build) beta (x86_64)
Revision	1eec40d3a5764881c92085aaee66d25075c159aa-refs/branch-heads/5304@{#942}
OS	macOS Version 11.7 (Build 20G817)

Steps:

1. installed 1.46.76
2. launched Brave (in English)
3. loaded cnn.com
4. set respective languages as the primary one, below, via Apple -> System Preferences -> Language & Region
5. clicked on the Shields icon in the URL bar
6. clicked on the Blocked-cookies count
7. looked at the translated string for Shields

Confirmed all were translated, except for German, which I'll spin-off as a separate issue and cross-reference, here.

French	German(*)	Hindi	Kannada	Polish

[stephendonner]

Logged #26216