-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Better wording for Copy Clean URL
context menu item
#25621
Comments
@pes10k @ShivanKaul thoughts welcome too. |
@fmarier and I discussed this a couple weeks back, and arrived at the "Copy clean link (only main URL)" string after much back-and-forth. I'm good with it. |
as a novice user, im not sure i'd know what "only main URL" means (im not sure i know what it means a non-novice user!). Why not just "Copy link address (clean)" or similar, so its clearly related to but distinct option from the existing "Copy link address" option? |
that seems extremely confusing to me (and the wrong piece of UI) to define a term in a dropdown menu I'm also surprised that i didn't see this option when i right click on a link. Is that intended? |
@pes10k — I'm definitely open to shifting. Some options off top of my head:
Any other ideas? |
I dont think URL only works for any of these. Query parameters are part of the URL. I'm happy to hold my peace if folks feel otherwise, but I still don't understand the concern around "clean". It captures the feature (both technically and literally), and a "clean" URL seems at least as understandable as what a "main" URL is. Strong vote against "link" though too. Its definitely not a link :) Anyway, i'll sit on my hands for a bit, but thats my 2c |
Agree that 'clean' without qualification seems fine - I think we should have documentation/support article/wiki/blog post explaining what exactly we mean by 'clean', but we don't need to make this confusing for users. |
Per sidebar w/ @rebron , our latest idea for this string is:
|
what is meant by (address only)? The whole thing is the address
(regardless of weather there or some, a lot, or no query parameters), and
there are many query parameters we won't remove
…On Wed, Oct 5, 2022 at 4:00 PM rmcfadden3 ***@***.***> wrote:
Per sidebar w/ @rebron <https://github.com/rebron> , our latest idea for
this string is:
Copy clean URL (address only)
—
Reply to this email directly, view it on GitHub
<#25621 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAASV3WJWPKVGQAM47VICNDWBXT6XANCNFSM6AAAAAAQWBXJSM>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
So seeing this for the first time I had absolutely no idea what "Copy clean link" meant and adding "only main URL" made it even more confusing. I had to go back to the original issue to see what this feature does. "clean" meant absolutely nothing to me and did not provide any additional useful information to understand what it does. "Copy link and strip trackers"? I don't know if that will be meaningful to users, but it would have been a lot more meaningful to me than "clean" which meant absolutely nothing to me. |
Labelling as |
Description
When solving the feature #23315 with brave/brave-core#14763 we have (on the context menu),
Copy clean link (only main URL)
It might be better as
Copy clean link (remove tracking elements)
orCopy clean link (strip query suffix)
(something like this)When fixed, would need uplift to 1.45
cc: @rmcfadden3 @rebron can you help with wording on this?
The text was updated successfully, but these errors were encountered: