Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better wording for Copy Clean URL context menu item #25621

Closed
bsclifton opened this issue Sep 26, 2022 · 15 comments · Fixed by brave/brave-core#15518
Closed

Better wording for Copy Clean URL context menu item #25621

bsclifton opened this issue Sep 26, 2022 · 15 comments · Fixed by brave/brave-core#15518
Labels
copy-clean-link l10n needs-text-change This change requires some careful wording. OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA/No release-notes/exclude

Comments

@bsclifton
Copy link
Member

bsclifton commented Sep 26, 2022

Description

When solving the feature #23315 with brave/brave-core#14763 we have (on the context menu), Copy clean link (only main URL)
image

It might be better as Copy clean link (remove tracking elements) or Copy clean link (strip query suffix) (something like this)

When fixed, would need uplift to 1.45

cc: @rmcfadden3 @rebron can you help with wording on this?

@bsclifton bsclifton added needs-text-change This change requires some careful wording. OS/Desktop labels Sep 26, 2022
@rebron rebron added the priority/P3 The next thing for us to work on. It'll ride the trains. label Sep 26, 2022
@BrendanEich
Copy link
Member

@pes10k @ShivanKaul thoughts welcome too.

@rmcfadden3
Copy link

@fmarier and I discussed this a couple weeks back, and arrived at the "Copy clean link (only main URL)" string after much back-and-forth. I'm good with it.

@rmcfadden3 rmcfadden3 removed their assignment Sep 26, 2022
@pes10k
Copy link
Contributor

pes10k commented Sep 26, 2022

as a novice user, im not sure i'd know what "only main URL" means (im not sure i know what it means a non-novice user!). Why not just "Copy link address (clean)" or similar, so its clearly related to but distinct option from the existing "Copy link address" option?

@rmcfadden3
Copy link

@pes10k@fmarier and I chose not to go that route, because the word "clean" is likely not universally understood by novice users. So we chose to "brand" the term as "clean", but then give a very short parenthetical definition of what "clean" means, too.

@pes10k
Copy link
Contributor

pes10k commented Sep 26, 2022

that seems extremely confusing to me (and the wrong piece of UI) to define a term in a dropdown menu

I'm also surprised that i didn't see this option when i right click on a link. Is that intended?

@bsclifton
Copy link
Member Author

bsclifton commented Sep 26, 2022

I'm also surprised that i didn't see this option when i right click on a link. Is that intended?

@pes10k yes - that wasn't in scope for the MVP in original spec by @fmarier. I've captured that here #25625

@rmcfadden3
Copy link

@pes10k — I'm definitely open to shifting. Some options off top of my head:

  • Copy clean link (URL only)
  • Copy clean link address (URL only)
  • Copy link address (URL only)

Any other ideas?

@pes10k
Copy link
Contributor

pes10k commented Sep 26, 2022

I dont think URL only works for any of these. Query parameters are part of the URL. I'm happy to hold my peace if folks feel otherwise, but I still don't understand the concern around "clean". It captures the feature (both technically and literally), and a "clean" URL seems at least as understandable as what a "main" URL is.

Strong vote against "link" though too. Its definitely not a link :)

Anyway, i'll sit on my hands for a bit, but thats my 2c

@ShivanKaul
Copy link
Collaborator

Agree that 'clean' without qualification seems fine - I think we should have documentation/support article/wiki/blog post explaining what exactly we mean by 'clean', but we don't need to make this confusing for users.

@rmcfadden3
Copy link

Per sidebar w/ @rebron , our latest idea for this string is:

Copy clean URL (address only)

@pes10k
Copy link
Contributor

pes10k commented Oct 5, 2022 via email

@bridiver
Copy link
Contributor

bridiver commented Oct 13, 2022

So seeing this for the first time I had absolutely no idea what "Copy clean link" meant and adding "only main URL" made it even more confusing. I had to go back to the original issue to see what this feature does. "clean" meant absolutely nothing to me and did not provide any additional useful information to understand what it does. "Copy link and strip trackers"? I don't know if that will be meaningful to users, but it would have been a lot more meaningful to me than "clean" which meant absolutely nothing to me.

@rebron
Copy link
Collaborator

rebron commented Oct 18, 2022

Some additional suggestions. What it will look like from Share menu.

  1. Copy clean URL No further description

Screenshot 2022-10-17 at 6 31 34 PM

  1. Copy clean link No further description. Relying on clean to differentiate from Copy link

Screenshot 2022-10-17 at 6 30 13 PM

  1. Copy clean link for sharing

Screenshot 2022-10-17 at 6 30 59 PM

@rebron
Copy link
Collaborator

rebron commented Oct 18, 2022

Right click context menu from the url bar.

  1. Copy clean URL No further description

Screenshot 2022-10-17 at 7 21 07 PM

  1. Copy clean link No further description. Relying on clean to differentiate from Copy link

Screenshot 2022-10-17 at 7 21 20 PM

  1. Copy clean link for sharing

Screenshot 2022-10-17 at 7 21 56 PM

@kjozwiak
Copy link
Member

Labelling as QA/No in favour of #26106 which we'll be used to verify brave/brave-core#15518. CCing @rebron @bsclifton

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
copy-clean-link l10n needs-text-change This change requires some careful wording. OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA/No release-notes/exclude
Projects
None yet
Development

Successfully merging a pull request may close this issue.

10 participants