-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace the Muli font with Poppins #25527
Comments
@brave/qa-team spot check sections listed in #25527 (comment). @rebron could someone from design team give this a more thorough check with a trained eye? |
Verified
|
Brave | 1.46.76 Chromium: 107.0.5304.62 (Official Build) beta (x86_64) |
---|---|
Revision | 1eec40d3a5764881c92085aaee66d25075c159aa-refs/branch-heads/5304@{#942} |
OS | macOS Version 11.7 (Build 20G817) |
Welcome page
- right click on any element in the page
- select
Inspect
- click
Computed
tab inDeveloper
tools - scroll down to view the rendered fonts for the page
Confirmed Poppins
font rendered
Brave Talk
- open NTP
- click on
Brave Talk
to switch to the widget - right click on any element in the page
- select
Inspect
- click
Computed
tab inDeveloper tools
- scroll down to view the rendered fonts for the page
Confirmed Poppins
font rendered
Rewards Settings page
Verified with
Welcome page - PASSED
Confirmed
|
@aguscruiz if the places mentioned in #25527 (comment) need to be addressed, please open a new issue for it, thanks! |
Yes, please; helps us keep scope down considerably <3 |
No problem! Will do, here is the new issue #27081 |
We have decided to stop using Muli, which we mainly used for body content. Uses should be replaced with Poppins. When replacing, we generally have to dial down the font-weight a little (e.g. from
600
to500
).This requires changes in brave-core and brave-ui (where there are theme variables and shared styles from components).
Places:
Test Plan
Screenshots (old on right, new on left)
Notes
If you really want to verify which font is being used, you can inspect the element, switch to the "computed" tab and scroll right to the bottom. DevTools will report which font is being used to actually render.
The text was updated successfully, but these errors were encountered: