Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove device modal text needs to be aligned correctly #2526

Closed
srirambv opened this issue Dec 13, 2018 · 3 comments · Fixed by brave/brave-core#1095
Closed

Remove device modal text needs to be aligned correctly #2526

srirambv opened this issue Dec 13, 2018 · 3 comments · Fixed by brave/brave-core#1095
Assignees
Labels
about-pages/sync design A design change, especially one which needs input from the design team OS/Linux priority/P5 Not scheduled. Don't anticipate work on this any time soon. QA Pass-Linux QA/Test-Plan-Specified QA/Yes release/not-blocking release-notes/exclude

Comments

@srirambv
Copy link
Contributor

Description

Remove device modal text needs to be aligned correctly

Steps to Reproduce

  1. Install 0.58.12
  2. Enable sync and add a device
  3. Remove the device added in step 2, modal popup shows up with incorrect text alignment

Actual result:

image

Expected result:

All text should be left aligned

Reproduces how often:

Easy

Brave version (brave://version info)

Brave 0.58.12 Chromium: 71.0.3578.80 (Official Build) (64-bit)
Revision 2ac50e7249fbd55e6f517a28131605c9fb9fe897-refs/branch-heads/3578@{#860}
OS Linux

Reproducible on current release:

  • Does it reproduce on brave-browser dev/beta builds?
    No, Beta/Dev doesnt have V2 UI

Website problems only:

  • Does the issue resolve itself when disabling Brave Shields?
    NA
  • Is the issue reproducible on the latest version of Chrome?
    NA

Additional Information

cc: @brave/legacy_qa to verify on other platforms

@srirambv srirambv added design A design change, especially one which needs input from the design team OS/Linux priority/P5 Not scheduled. Don't anticipate work on this any time soon. release/not-blocking about-pages/sync QA/Yes release-notes/exclude QA/Test-Plan-Specified labels Dec 13, 2018
@srirambv srirambv added this to the 1.x Backlog milestone Dec 13, 2018
@cezaraugusto
Copy link
Contributor

@srirambv per your video you seem to be using sync v1. could you please check with the new version?

@srirambv
Copy link
Contributor Author

@cezaraugusto not sure which video you are referring to ?

@kjozwiak
Copy link
Member

Verification PASSED on Ubuntu 18.04.1 x64 using the following build:

Brave 0.58.14 Chromium: 71.0.3578.98 (Official Build) (64-bit)
Revision 15234034d19b85dcd9a03b164ae89d04145d8368-refs/branch-heads/3578@{#897}
OS Linux

screen shot 2018-12-18 at 2 17 13 am

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
about-pages/sync design A design change, especially one which needs input from the design team OS/Linux priority/P5 Not scheduled. Don't anticipate work on this any time soon. QA Pass-Linux QA/Test-Plan-Specified QA/Yes release/not-blocking release-notes/exclude
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants