Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Debian-based installation instructions should use a custom trusted.gpg file #2508

Closed
fmarier opened this issue Dec 12, 2018 · 0 comments
Closed

Debian-based installation instructions should use a custom trusted.gpg file #2508

fmarier opened this issue Dec 12, 2018 · 0 comments
Assignees
@fmarier
Labels
OS/Linux
Milestone
Closed / Dupe / I...

Comments

@fmarier
Copy link
Member

fmarier commented Dec 12, 2018

Description

Right now, the installation instructions for Ubuntu/Mint put the brave apt repository in a separate .list file, but the signing key gets imported into the global keyring:

curl -s https://brave-browser-apt-release.s3.brave.com/brave-core.asc | sudo apt-key add -

A much better option would be to put the key into its own keyring:

curl -s https://brave-browser-apt-release.s3.brave.com/brave-core.asc | sudo apt-key --keyring /etc/apt/trusted.gpg.d/brave-browser-release.gpg add -
fmarier added a commit to fmarier/brave-browser that referenced this issue Dec 12, 2018
@fmarier
Use a separate keyring for the apt signing keys (closes brave#2508)
a57acf6
@NejcZdovc NejcZdovc added this to the 1.x Backlog milestone Jan 2, 2019
@fmarier fmarier self-assigned this Jan 14, 2019
fmarier added a commit that referenced this issue Jan 29, 2019
@fmarier
Merge pull request #2509 from fmarier/issue2508
7d12938 
Use a separate keyring for the apt signing keys (closes #2508)
@bbondy bbondy added this to the Closed / Invalid milestone Jun 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fmarier fmarier

Labels
OS/Linux
Projects
None yet
Milestone
Closed / Dupe / Invalid
Development

No branches or pull requests
3 participants
@fmarier @bbondy @NejcZdovc