Set default search engine bug

[ghost]

Issue was when I go to create a new profile in brave it shows me the welcome window (brave://welcome/) as usual after continuing to the fifth step of Set default search engine for suppose I choose google as default search engine and then I click Set default NOT Done. My screen goes blank for no reason.

I discovered this bug on my Mac running MacOS Monterey and running this in the latest update.[Version 1.42.88 Chromium: 104.0.5112.81].

Thanks :)

[GeetaSarvadnya]

Looks like it's UI bug, click on Set Default is setting the default SE via Onboarding flow, only problem is it's showing up the empty page after setting default SE. The issue is reproducible from 1.36.x to 1.42.x versions. The issue got introduced starting from the version when Rewards slide is removed from the onboarding flow in the version 1.35.x.

In 1.42.x, when the user select the SE from the drop down and click on Set Default button, the empty page appears with the Next-> button, which is incorrect instead of Next-> button it should show Done button as SE is the last slide in the onboarding flow.

The version 1.35.x has 5 slides in onboarding flow (lets go, import bookmarks, p3a, default search engine and rewards) In 1.36.x the rewards slide is been removed from the onboarding flow. Looks like issue got introduced after that.

1.35.x - Working as expected

1.42.x - Not working

[rebron]

cc: @zenparsing

[stephendonner]

Verified PASSED using

Brave	1.44.71 Chromium: 105.0.5195.68 (Oficjalna wersja) dev (x86_64)
Wersja	ad13e82529051bac6a0e65f455e6d7a1e5fd7938-refs/branch-heads/5195@{#903}
System operacyjny	macOS Wersja 13.0 (kompilacja 22A5331f)

Prerequisite: set my OS language and region to Polish/Poland (to trigger the offering of the search-engine choice)

Steps:

1. installed 1.44.71
2. launched Brave
3. clicked through the onboarding-carousel dots
4. chose Google/DuckDuckGo from the list, and clicked on the button
5. confirmed search-engine choice in brave://settings/search

Confirmed it replaced the brave://welcome tab with a new-tab page, with background image, etc.

1.44.71

example	example

example	example	example

Reproduced the issue using 1.42.88

1.42.88

example	example

[LaurenWags]

Labelling as QA/Blocked until this is uplifted to 1.43.x for the maintenance release

[kjozwiak]

The above requires 1.43.91 for 1.43.x verification 👍 Removing QA/Blocked.

[kjozwiak]

Removing the QA Pass-macOS label as the above will need to be rechecked once we get a new 1.43.x build. Used #24635 (comment) as the verification to get brave/brave-core#15005 uplifted into 1.43.x.

[LaurenWags]

Verified with

Brave | 1.43.91 Chromium: 105.0.5195.102 (Official Build) (x86_64)
-- | --
Revision | 4c16f5ffcc2da70ee2600d5db77bed423ac03a5a-refs/branch-heads/5195_55@{#4}
OS | macOS Version 12.5.1 (Build 21G83)

Pre-req: be set to a region which contains the SE panel in onboarding, I used Belgium.

Reproduced issue using scenario from #24635 (comment) and 1.43.88 Chromium: 105.0.5195.68. After clicking "Set default", saw the blank panel as described:

Example	Example

Verified when using 1.43.91 (and Belgium region), after clicking "Set default" on SE selection panel, the NTP was displayed. Confirmed SE selection in brave://settings/search.

Example	Example	Example

[MadhaviSeelam]

Verification PASSED using

Brave | 1.43.91 Chromium: 105.0.5195.102 (Official Build) (64-bit)
-- | --
Revision | 4c16f5ffcc2da70ee2600d5db77bed423ac03a5a-refs/branch-heads/5195_55@{#4}
OS | Windows 11 Version 21H2 (Build 22000.856)

Pre-req: Set to a country/region which contains the SE panel in onboarding, I used India .

Reproduced using 1.43.89

Ex1	Ex2

Verification Steps:

1. installed 1.43.91
2. launched Brave
3. clicked through the onboarding-carousel dots
4. chose Bing from the list, and clicked on the button
5. confirmed search-engine choice in brave://settings/search

Confirmed after clicking "Set default" on SE selection panel, the NTP was displayed.

step 4	NTP	step 5

[btlechowski]

Verification passed on

Brave	1.43.92 Chromium: 105.0.5195.102 (Official Build) (64-bit)
Revision	4c16f5ffcc2da70ee2600d5db77bed423ac03a5a-refs/branch-heads/5195_55@{#4}
OS	Ubuntu 18.04 LTS

Pre-req: Set to a country/region which contains the SE panel in onboarding, I used PL.

Reproduced using 1.43.88

Ex1	Ex2

Verification Steps:

1. installed 1.43.92
2. launched Brave
3. clicked through the onboarding-carousel dots
4. chose Bing from the list, and clicked on the button
5. confirmed search-engine choice in brave://settings/search

Confirmed after clicking "Set default" on SE selection panel, the NTP was displayed.

step 4	NTP	step 5