Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Brave translate icon on URL bar to replace Chromium default #24150

Closed
aguscruiz opened this issue Jul 20, 2022 · 4 comments · Fixed by brave/brave-core#14566
Closed

Update Brave translate icon on URL bar to replace Chromium default #24150

aguscruiz opened this issue Jul 20, 2022 · 4 comments · Fixed by brave/brave-core#14566
Assignees
Labels
OS/Android Fixes related to Android browser functionality OS/Desktop polish Nice to have — usually related to front-end/visual tasks priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass - Android ARM QA Pass - Android Tab QA Pass-macOS QA/Test-Plan-Specified QA/Yes release-notes/exclude

Comments

@aguscruiz
Copy link

Description

Currently, Brave translate shows an icon in the URL bar to offer translations. Desktop browser has chromium's default, and Android has a custom one that doesn't scale too well to be used in Desktop. So we're going to provide a new one that works for both versions.

Related Android ticket: #23770

Steps to Reproduce

Desktop browser

  1. On nightly, open https://www.heise.de/
  2. See icon for translation

Actual result:

image

Expected result:

New icon will be provided when it's defined

Desktop Brave version:

Nightly

@aguscruiz aguscruiz added OS/Android Fixes related to Android browser functionality OS/Desktop labels Jul 20, 2022
@rebron rebron added priority/P3 The next thing for us to work on. It'll ride the trains. QA/Yes release-notes/exclude labels Jul 20, 2022
@aguscruiz
Copy link
Author

aguscruiz commented Jul 21, 2022

@rebron Updated icon available here:
Light mode: https://www.figma.com/file/tLXWGCpNoiJxDZDdpfordj/Desktop-Settings?node-id=2625%3A70968
Dark mode: https://www.figma.com/file/tLXWGCpNoiJxDZDdpfordj/Desktop-Settings?node-id=2625%3A71522

image

image

@stephendonner
Copy link

stephendonner commented Aug 15, 2022

Verification PASSED using

Brave 1.43.70 Chromium: 104.0.5112.81 (Official Build) beta (x86_64)
Revision 5b7b76419d50f583022568b6764b630f6ddc9208-refs/branch-heads/5112@{#1309}
OS macOS Version 11.6.8 (Build 20G730)

Used the reference icons from #24150 (comment)

Steps:

  1. installed 1.43.70
  2. launched Brave
  3. loaded https://www.spiegel.de/
  4. confirmed new icon asset in both Light and Dark modes
Light Dark
Screen Shot 2022-08-15 at 11 48 10 AM Screen Shot 2022-08-15 at 11 48 24 AM

@Uni-verse
Copy link
Contributor

Uni-verse commented Aug 17, 2022

Verified on Samsung GS 21 running Android 12 using

Brave	1.43.71 Chromium: 104.0.5112.81 (Official Build) beta (64-bit) 
Revision	5b7b76419d50f583022568b6764b630f6ddc9208-refs/branch-heads/5112@{#1309}
OS	Android 12; Build/SP1A.210812.016

Specs: https://docs.google.com/document/d/1LBmoyUveZaMcnycpRqg91lhzZFjDx_19zM3x6ulNpHg/edit?usp=sharing

Preconditions:

  1. Enable Brave Translate-go flag
  2. Enable Chromium translate flag
  3. Relaunch browser
  • Verified translation icon is updated to spec and is displayed in the translate bar
  • Verified new translate asset in the menu in light and dark mode.
  • Verified translate icon placement under find in page
Dark Mode Light Mode
screenshot-1660773572831 screenshot-1660773609548
screenshot-1660773849296 screenshot-1660773835504

@Uni-verse
Copy link
Contributor

Verified on Samsung Galaxy Tab S7 running Android 12 using

Brave	1.43.71 Chromium: 104.0.5112.81 (Official Build) beta (64-bit) 
Revision	5b7b76419d50f583022568b6764b630f6ddc9208-refs/branch-heads/5112@{#1309}
OS	Android 12; Build/SP1A.210812.016

Specs: https://docs.google.com/document/d/1LBmoyUveZaMcnycpRqg91lhzZFjDx_19zM3x6ulNpHg/edit?usp=sharing

Preconditions:

  1. Enable Brave Translate-go flag
  2. Enable Chromium translate flag
  3. Relaunch browser
  • Verified translation icon is updated to spec and is displayed in the translate bar
  • Verified new translate asset in the menu in light and dark mode.
  • Verified translate icon placement under find in page
Dark Mode Light Mode
screenshot-1660774424220 screenshot-1660774404468

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OS/Android Fixes related to Android browser functionality OS/Desktop polish Nice to have — usually related to front-end/visual tasks priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass - Android ARM QA Pass - Android Tab QA Pass-macOS QA/Test-Plan-Specified QA/Yes release-notes/exclude
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants