Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade from Chromium 103 to Chromium 104. #23092

Closed
mkarolin opened this issue May 26, 2022 · 3 comments · Fixed by brave/brave-core#13498
Closed

Upgrade from Chromium 103 to Chromium 104. #23092

mkarolin opened this issue May 26, 2022 · 3 comments · Fixed by brave/brave-core#13498

Comments

@mkarolin
Copy link
Contributor

mkarolin commented May 26, 2022

Upgrade from Chromium 103 to Chromium 104.

https://chromium.googlesource.com/chromium/src/+log/103.0.5060.24..104.0.5112.29/?pretty=fuller&n=10000

QA tests:
This is a major Chromium version bump, please do full passes.

Desktop Affected areas:

  • History page has correct style
  • Translate bubble works correct with/without brave://flags/#brave-translate-go feature
  • Hardware concurrency farbling works as expected
  • DeAmp and Speedreader work as expected
  • Settings UI and style works/looks correctly

Android Affected areas:

  • Top toolbar UI (with disabled bottom toolbar)
  • NTP UI
  • Password settings
  • Saving and using passwords
  • Send tab to device
  • Most visited sites
@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Jul 25, 2022

Verification PASSED on

Brave | 1.43.43 Chromium: 104.0.5112.57 (Official Build) nightly (64-bit)
-- | --
Revision | 212fd173a0da1e0a024f328295bb56a2529190bb-refs/branch-heads/5112@{#1042}
OS | Windows 10 Version 21H2 (Build 19044.1826)

History page has correct style_PASSED
  • Confirmed that history page has the correct style and controls on the history page works as expected
  • Confirmed browser history is shown as expected on brave://history page
    image
Translate bubble_PASSED

Disable - #brave-translate-go

  • Confirmed translate bubble is shown when non english site is visited
  • Confirmed translate extension can be installed without any issues
  • Confirmed that non english site can be translated in intended language
Example Example Example Example
image image image image

Enable - #brave-translate-go

  • Confirmed translate bubble is shown when non english site is visited
  • Confirmed that click on Translate options shows the list of options listed below:
    1. Choose another language
    2. Always translate German
    3. Never translate German
    4. Never trsalate this site
    5. Page is not in German
  • Confirmed that Choose another language options opens up the list of languages
  • Confirmed that another language can be selected from Choose another language options and page gets translated in selected language successfully
  • Reset option under Language to translate into popup isn't functioning, logged Reset option under Language to translate into popup isn't functioning when #brave-translate-go is enabled #24266
Example Example Example Example
image image image image
Hardware concurrency farbling works as expected_PASSED

Disucussed with @mkarolin, verified the issue #10808

  • open any site
  • open dev tool->console
  • enter window.navigator.hardwareConcurrency in console
  • verify the value for both Block fingerprinting and Aggressively block fingerprinting in the shields.

[Note: the value should be between 2 and your actual processors count]

Default/Block fingerprinting

image

Aggressively block fingerprinting

image

DeAmp and Speedreader work as expected_PASSED
DeAmp_PASSED

(Refer the issue - #22228, discussed with @mkarolin )

de-AMP Disabled

  • ensured that Auto-redirect AMP pages was disabled via brave://settings/shields
  • Loaded https://www.google.com and then searched for Top Stories
  • inspected the first article via DevTools and ensured that jsaction attribute appeared in the anchor link
  • clicked on the link and ensured that the AMP version of the website/news article was being loaded
  • validated with google.com as well and results were same as expected
Example Example Example
image (3) image (4) image (5)

de-AMP Enabled

  • ensured that Auto-redirect AMP pages was enabled via brave://settings/shields
  • loaded https://www.google.com and then searched for Top Stories
  • inspected the first article via DevTools and ensured that jsaction attribute didn't appear in the anchor link
  • clicked on the link and ensured that the de-AMP version of the website/news article was being loaded
  • validated with google.com as well and results were same as expected
Example Example Example
image image (1) image (2)
Speedreader_PASSED
  • Confirmed that able to enable/disable the Speedreader feature correctly from the speedreader icon via URL bar
  • Disable the global speedreader settings from brave://settings/appearance and open a article https://metro.co.uk/news/ click on the reader mode icon and ensured article goes into the reader mode, click again on the reader mode icon exit the reader mode as expected
  • Enable the global speedreader settings via brave://settings/appearance and open an article and ensured article is opened in reader mode.

Issue encountered:
#23853
#23418
#21872

Settings UI and style works/looks correctly_PASSED
  • Confirmed that settings UI looks good and click on each settings redirected to the intended pages
  • Confirmed that no new brave://settings are added as part of CR104
  • Confirmed that no new brave://settings/content settings are added as part of CR104
  • Confirmed that there is a new settings added in brave://settings/system as part of Brave

brave://settings/system
image


Settings comparison

  • Confirmed that no new brave://settings are added as part of CR104
  • Confirmed that no new brave://settings/content settings are added as part of CR104
  • Confirmed that there is a new settings added in brave://settings/system as part of Brave

brave://settings/system
image

Components updater

  • No new componnets are added as part of CR104
  • Components are updates successfully without any error
1.40.100 Chromium: 103.0.5060.134 1.43.43 Chromium: 104.0.5112.57
image image

Brave startup calls

  • Confirmed that only brave domains are listed in the Charles when the nightly build is launched with a clean profile
  • Confirmed no calls to google, gstatic, etc domains when the nightly build is launched with a clean profile

@Uni-verse
Copy link
Contributor

Uni-verse commented Jul 26, 2022

Verification PASSED for Android ARM using

Brave	1.43.48 Chromium: 104.0.5112.57 (Official Build) canary (64-bit) 
Revision	212fd173a0da1e0a024f328295bb56a2529190bb-refs/branch-heads/5112@{#1042}
OS	Android 12; Build/SP1A.210812.01

Devices: Samsung GS 21 & Samsung G Tab S7

Performed checks for the Android affected areas mentioned in #23092 (comment) on nightly channel.

  • Top toolbar UI (with disabled bottom toolbar)
  • NTP UI
  • Password settings
  • Saving and using passwords
  • Send tab to device
  • Most visited sites
  • Checked brave://components for errors
Mobile Tablet
screenshot-1658861443424 screenshot-1658856279624
screenshot-1658860958784 screenshot-1658861478588

@kjozwiak
Copy link
Member

Labelling as QA/No & release-notes/exclude in favour of #24291. We'll also need to check the affected areas mentioned above on both Linux & macOS as per #24291 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants