-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Widevine prompt needs to be more obvious to the user #1940
Comments
widevine related issue? |
@rebron confirmed it's a widevine issue. I didn't notice it in the URL bar. Why doesn't Widevine come pre-installed? |
@karenkliu I think the disclaimer does a fair job explaining why it's not bundled by default - maybe we should make the need for this component more obvious than just a puzzle piece? |
@bradleyrichter @bsclifton I don't think it's obvious at all to the user why Widevine doesn't come bundled with Brave. Why does Brave "discourage" it? Is there an impact to user privacy by enabling it? Why would there be "damages or losses" by using it? Damages to what? Loss of what? The wikipedia page https://en.wikipedia.org/wiki/Widevine describing it just makes it seem like it's a benign thing to enforce licensing and make sure creators + the platforms get paid for the content. It's a huge product problem if Brave users can't figure out how to make Amazon Video, BBC, Hulu, Netflix and Spotify work in Brave and don't understand why we're making it harder for them to stream from these huge content platforms. @bbondy moving this discussion to Github from Slack so that it's tracked with an issue. |
Per Slack. We discourage it because it's a closed source CDM and because we decided as a company not to promote DRM.
Yes.
Yes, we don't know what it does, or if it does more than what it says.
Yep, so let's figure out a better UI for it, but we can't include it by default. |
I think we could just open the flyout by default so that people would notice it better. |
I agree with @bbondy; this seems to be an issue of helping the user discover that the problem is widevine and install it smoothly as opposed to a problem of bundling widevine by default. Once widevine is installed, they won't run into this issue in the future. (unlike Flash, widevine doesn't prompt anymore once it's installed) |
@bbondy we should have this dialogue come out when Widevine needs to be installed |
Adding example of the current flow that was added into #1634 which I closed as duplicate as this one has more activity: |
@rebron @tomlowenthal can we do something like this:
|
+1 on the bubble notification. If user ignores this it can still be run from the URL slide notification. |
@karenkliu there is no need to prompt users to run widevine if it's already installed. the only case we would show a prompt is if widevine is needed but not installed. this matches the browser-laptop behavior. therefore the prompt should say 'install widevine' or something to make it clear that clicking the affirmative option will install new software. |
@diracdeltas when @tomlowenthal looked at it with me he mentioned that the prompt makes it seem like it's not installed, but from the speed at which the page was able to play correctly after clicking install, he made the assumption that it was actually already installed in the browser and clicking install made it run instead of downloading new software and installing it. If that's not true then yes, of course we should change the prompt to "install widevine" instead of "run" and only show it when it's not already installed. |
@karenkliu the intended behavior is that widevine only prompts if it's not installed. if it's already installed and still prompting, we should remove those prompts. not sure about tom's assumption since i haven't verified it. |
+1 from Twitter: https://twitter.com/porteneuve/status/1075049456133906432?s=09 |
Is it possible to popup if not installed and then popup with |
@angezanetti we have no ability right now for a per run permission prompt. I'm not opposed to the idea, please post another issue for that since this one is tracking just the ability for users to see an install prompt. |
@mkarolin: Only change from that screen is we're going with "Install Widevine" instead of "Run Widevine" |
Need to check |
Verification passed on
Used test plan from brave/brave-core#1772 Verified passed with
Verification passed on
Used test plan from brave/brave-core#1772 |
Description
When I try to view a video on Hulu e.g. Rick and Morty S2E1, the page won't load. Hulu shows me an error page with this text "Error playing this video. Sorry, we encountered an error playing this video. Please ensure your browser is supported. Error code: 3001"
Same problem on Netflix - gives me a "Missing Component" error"
Seems to affect all sites that need Widevine - Amazon Video, BBC, Hulu, Netflix and Spotify
Steps to Reproduce
Actual result:
Expected result:
Video should play
Reproduces how often:
Easily reproduced (always)
Brave version (brave://version info)
Version 0.55.22 Chromium: 70.0.3538.77 (Official Build) (64-bit)
Reproducible on current release:
Yes.
Website problems only:
No.
No. It plays correctly in Chrome.
Additional Information
The text was updated successfully, but these errors were encountered: