Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto Contribute enabled by default #17892

Closed
UjCbFwtBayFM opened this issue Sep 6, 2021 · 4 comments
Closed

Auto Contribute enabled by default #17892

UjCbFwtBayFM opened this issue Sep 6, 2021 · 4 comments

Comments

@UjCbFwtBayFM
Copy link

UjCbFwtBayFM commented Sep 6, 2021

Description

Brave Rewards auto-contribute is enabled by default. The Rewards onboarding assistant only asks the user for the amount per month, no option to not enable it. This would prevent people from discovering some of their BAT was lost due to AC being on.

Steps to Reproduce

  1. Install Brave
  2. Enable Rewards

Actual result:

Onboarding assistant asks for how many ads max per hour you want to see, and how much BAT you want to allocate for monthly auto-tipping.

Expected result:

Brave should explicitly asks users if they want to enable auto-contribute. It also only gives a 1-5 ads per hour despite 10 ads/hour being available.
It should also clearly mention that, regardless to how many ads you've set, the actual number of ads you will see will likely vary.

Reproduces how often:

Every single time.

Brave version (brave://version info)

Brave | 1.31.23 Chromium: 93.0.4577.63 (Build officiel) nightly (64 bits)
Revision | ff5c0da2ec0adeaed5550e6c7e98417dac77d98a-refs/branch-heads/4577@{#1135}
Operating system | Windows 10 OS Version 2004 (Build 19041.1165)

Version/Channel Information:

  • Can you reproduce this issue with the current release? yes
  • Can you reproduce this issue with the beta channel? yes
  • Can you reproduce this issue with the nightly channel? yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? N/A
  • Does the issue resolve itself when disabling Brave Rewards? No
  • Is the issue reproducible on the latest version of Chrome? N/A

Miscellaneous Information:

@Ayern12
Copy link

Ayern12 commented Sep 6, 2021 via email

@bsclifton
Copy link
Member

cc: @Miyayes

@Miyayes
Copy link
Collaborator

Miyayes commented Sep 8, 2021

This was an intentional product decision, and should essentially be resolved with #15308.

@Miyayes Miyayes closed this as completed Sep 8, 2021
@UjCbFwtBayFM
Copy link
Author

UjCbFwtBayFM commented Sep 9, 2021

No, it is not related. Feels like you didn't even read my post. Users should have the option to disable it when they first set up Brave.
My proposed changed would give the ability to users to disable auto contributions when they set up Brave, yours would ask users to confirm they want to auto-contribute right before they are processed.
Mine is a better solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants