Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

default browser dialog (first run dialog) doesn't show on Chromium 93 versions of Nightly #17667

Closed
LaurenWags opened this issue Aug 24, 2021 · 4 comments · Fixed by brave/brave-core#9849
Closed

default browser dialog (first run dialog) doesn't show on Chromium 93 versions of Nightly #17667

LaurenWags opened this issue Aug 24, 2021 · 4 comments · Fixed by brave/brave-core#9849
Assignees
@simonhong
Labels
intermittent-issue OS/Desktop OS/Linux OS/macOS priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-Linux QA Pass-macOS QA/Yes regression release-notes/exclude
Milestone
1.29.x - Release

Comments

@LaurenWags
Copy link
Member

Description

Chromium 93 versions of Brave Nightly do not show the default browser dialog on first run. The prompt is still shown on 3rd and 20th open, but not the first open.

This worked in 1.30.31 (Chromium 92) and stopped working when Chromium 93 was merged.

Steps to Reproduce

  1. Clean install 1.30.x w/ Chromium 93 (be sure you don't have any existing Nightly profile)
  2. Install app
  3. Launch app

Actual result:

Browser opens, no default browser dialog prompt / first run dialog box

Expected result:

Screen Shot 2021-08-24 at 12 50 44 PM

Reproduces how often:

Brave version (brave://version info)

Brave 1.30.44 Chromium: 93.0.4577.51 (Official Build) nightly (x86_64)
Revision 762d21050e2da59930c784c09b134d0b0b148188-refs/branch-heads/4577@{#915}
OS macOS Version 10.15.7 (Build 19H1323)

Version/Channel Information:

  • Can you reproduce this issue with the current release? no, 1.28.x
  • Can you reproduce this issue with the beta channel? no, 1.29.x
  • Can you reproduce this issue with the nightly channel? yes with Chromium 93 versions (chromium 92 versions work as expected)

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

cc @mkarolin @rebron @brave/legacy_qa
@LaurenWags
Copy link
Member Author

LaurenWags commented Aug 24, 2021 •
edited
Loading

I finally just got this prompt after a bunch of installs (~15). Then I tried again after I got it, and didn't receive the prompt 😞

@simonhong simonhong self-assigned this Aug 24, 2021
@simonhong
Copy link
Member

This is upstream issue - filed https://bugs.chromium.org/p/chromium/issues/detail?id=1243221

@simonhong simonhong mentioned this issue Aug 25, 2021
Merged
24 tasks
simonhong added a commit to brave/brave-core that referenced this issue Aug 25, 2021
@simonhong
Fixed first-run dialog is not launched
6ef17f9 
fix brave/brave-browser#17667

With https://bugs.chromium.org/p/chromium/issues/detail?id=1243221,
Local State file is created at the startup.
When, "Local State" file is already existed ShouldShowFirstRunDialog().
Due to this, dialog is launched ramdomly only when this file is not
stored in FS becfore calling ShouldShowFirstRunDialog().
Browser only tries to run this dialog when first_run::IsChromeFirstRun()
is true. Checking "Local State" file again is redundant. Removed this
checking.
@simonhong simonhong added this to the 1.30.x - Nightly milestone Aug 25, 2021
This was referenced Aug 25, 2021
Merged
Merged
@rebron rebron added the priority/P2 A bad problem. We might uplift this to the next planned release. label Aug 25, 2021
@LaurenWags
Copy link
Member Author

LaurenWags commented Aug 27, 2021 •
edited
Loading

Verified passed on macOS x64 10.15.7 with

Brave | 1.29.74 Chromium: 93.0.4577.58 (Official Build) (x86_64)
-- | --
Revision | c4410ece044414ea42fa4ba328d08195e818a99c-refs/branch-heads/4577@{#1076}
OS | macOS Version 10.15.7 (Build 19H1323)

Ran through 10+ fresh installs of the version above, confirmed each time I received the expected default browser prompt:

Catalina

Verified passed on macOS x64 11.5.2 with

Brave | 1.29.74 Chromium: 93.0.4577.58 (Official Build) (x86_64)
-- | --
Revision | c4410ece044414ea42fa4ba328d08195e818a99c-refs/branch-heads/4577@{#1076}
OS | macOS Version 11.5.2 (Build 20G95)

Ran through 10+ fresh installs of the version above, confirmed each time I received the expected default browser prompt:

Big Sur

Verified passed on macOS arm64 11.5.1 with

Brave	1.29.74 Chromium: 93.0.4577.58 (Official Build) (arm64)
Revision	c4410ece044414ea42fa4ba328d08195e818a99c-refs/branch-heads/4577@{#1076}
OS	macOS Version 11.5.1 (Build 20G80)

Ran through 10+ fresh installs of the version above, confirmed each time I received the expected default browser prompt:

M1

@stephendonner
Copy link

stephendonner commented Aug 27, 2021 •
edited
Loading

Ran through fresh installs 20+ times and confirmed the default-browser prompt appeared correctly for each, using macOS-Intel on Big Sur 11.5.2.

Brave 1.29.74 Chromium: 93.0.4577.58 (Official Build) (x86_64)
Revision c4410ece044414ea42fa4ba328d08195e818a99c-refs/branch-heads/4577@{#1076}
OS macOS Version 11.5.2 (Build 20G95)

and

Brave 1.29.74 Chromium: 93.0.4577.58 (Official Build) (64-bit)
Revision c4410ece044414ea42fa4ba328d08195e818a99c-refs/branch-heads/4577@{#1076}
OS Linux

Screen Shot 2021-08-27 at 3 33 18 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@simonhong simonhong

Labels
intermittent-issue OS/Desktop OS/Linux OS/macOS priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-Linux QA Pass-macOS QA/Yes regression release-notes/exclude
Projects
None yet
Milestone
1.29.x - Release
Development

Successfully merging a pull request may close this issue.

Fixed first-run dialog is not launched brave/brave-core
5 participants
@stephendonner @kjozwiak @rebron @simonhong @LaurenWags