Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

combine 2 strings into 1 string in BR-Off panel text #1723

Closed
bradleyrichter opened this issue Oct 18, 2018 · 1 comment · Fixed by brave/brave-core#721
Closed

combine 2 strings into 1 string in BR-Off panel text #1723

bradleyrichter opened this issue Oct 18, 2018 · 1 comment · Fixed by brave/brave-core#721
Assignees
@ryanml
Labels
feature/rewards QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/exclude
Milestone
0.56.x - Release ...

Comments

@bradleyrichter
Copy link

This was a hack to avoid breaking the page with missing content in a string.

Please combine the 2 strings into one paragraph here:

image
@bradleyrichter bradleyrichter added this to the 0.57.x - Dev milestone Oct 18, 2018
@NejcZdovc NejcZdovc assigned ryanml and unassigned NejcZdovc Oct 22, 2018
This was referenced Oct 22, 2018
Closed
Merged
@NejcZdovc NejcZdovc mentioned this issue Oct 24, 2018
Merged
18 tasks
NejcZdovc added a commit to brave/brave-core that referenced this issue Oct 24, 2018
@NejcZdovc
Updated brave-ui
e1bda6c 
Resolves brave/brave-browser#1723
Resolves brave/brave-browser#1556
@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Oct 26, 2018 •
edited by srirambv
Loading

Verification Passed on

Brave 0.57.3 Chromium: 70.0.3538.67 (Official Build) dev (64-bit)
Revision 9ab0cfab84ded083718d3a4ff830726efd38869f-refs/branch-heads/3538@{#1002}
OS Windows

Verified passed with

Brave 0.56.7 Chromium: 70.0.3538.77 (Official Build) beta(64-bit)
Revision 0f6ce0b0cd63a12cb4eccea3637b1bc9a29148d9-refs/branch-heads/3538@{#1039}
OS Mac OS X

Verification Passed on

Brave 0.56.8 Chromium: 70.0.3538.77 (Official Build) (64-bit)
Revision 0f6ce0b0cd63a12cb4eccea3637b1bc9a29148d9-refs/branch-heads/3538@{#1039}
OS Linux

@kjozwiak kjozwiak added QA/Yes and removed QA/No labels Oct 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ryanml ryanml

Labels
feature/rewards QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/exclude
Projects
None yet
Milestone
0.56.x - Release (Release Channel)
Development

Successfully merging a pull request may close this issue.

Adds captcha error flow brave/brave-core
7 participants
@kjozwiak @ryanml @NejcZdovc @bradleyrichter @srirambv @LaurenWags @GeetaSarvadnya