Support procedural cosmetic filtering #16935

antonok-edm · 2021-07-13T22:21:39Z

Procedural cosmetic filtering is useful for the most evasive kinds of in-content sponsored/promoted material. It'd be great to implement this and tie it to aggressive shields settings, to handle the last few examples of cosmetic items slipping through on Reddit, YouTube, Facebook, etc.

See also:

Reddit promoted content on mobile Reddit inline ads are not blocked on Android when shields are set to aggressive #16789
Facebook sponsored items Facebook Ad Content Evades Aggressive Mode #15869
YouTube empty video slots YouTube Ads in Video Grid #11955
Washington Post anti-adblock Anti-adblock on washingtonpost.com #21212

antonok-edm · 2022-04-12T17:38:59Z

Another use/test case: sponsored posts on stuff.co.nz

Should be handled by stuff.co.nz##[itemprop]:has(.sponsored-flag)

intrnl · 2022-04-12T20:40:44Z

How many filters makes use of other procedural selector? (e.g. :has-text)
I'd imagine Chrome's upcoming support for :has is going to make this slightly less necessary.

antonok-edm · 2022-04-12T21:26:20Z

How many filters makes use of other procedural selector? (e.g. :has-text)

I did a survey of procedural filter operator counts in Brave's default lists a few days ago:

:has
    164
:has-text
    336
:matches-css
    15
:matches-css-before
    19
:matches-css-after
    2
:matches-path
    12
:not
    165
:upward
    239
:xpath
    49

It's not an exact metric since some filters can contain multiple chained operators, and :not is a special case since it's also a valid CSS pseudo-class, but this list still gives a good idea of how important each is. has-text in particular would be great to support.

I'd imagine Chrome's upcoming support for :has is going to make this slightly less necessary.

The recent efforts on :has are commendable, but it actually has a really long history and who knows what else may delay the implementation. Plus, support procedural cosmetic filters in general should make :has fairly simple anyways.

edit: 172 occurrences of has-text, or roughly half, are actually from HTML filters (with a ##^ separator in the rule). That uses a totally separate system from procedural filtering, even though the rules look similar. I haven't seen any other procedural filters used for HTML filtering.

edit again: :has is actually implemented now! So just the other procedural filters are left now.

dharnil · 2024-03-06T09:50:59Z

Hi Braver, Is there any update on this open ticket. I happy to contribute.

MadhaviSeelam · 2024-10-18T19:41:30Z

Verification PASSED using

Brave | 1.72.83 Chromium: 130.0.6723.58 (Official Build) beta (arm64)
-- | --
Revision | b49615851cd2dc4b1c3f5f13d3207d3c032bfd8d
OS | macOS Version 14.6.1 (Build 23G93)

Installed 1.72.83
launched Brave
opened brave://settings/shields/filters in a new tab
added https://antonok.com/tmp/procedural-filter-tests/test-extended-css-rules.txt to Custom lists
visited https://antonok.com/tmp/procedural-filter-tests/index.html in a new tab

Confirmed following numbered test cases are passed

  - 1,2.3
  - 6,7,8,9
  - 20,21
  - 24
  - 26
  - 28,29

step 4	step 5a	step 5b

MadhaviSeelam · 2024-10-24T18:20:11Z

Verification PASSED using

Brave | 1.72.85 Chromium: 130.0.6723.58 (Official Build) beta (64-bit)
-- | --
Revision | 2c872aa4d2694bc73ec58e3b14538a4008a6381e
OS | Windows 11 Version 23H2 (Build 22631.4391)

Installed 1.72.85
launched Brave
opened brave://settings/shields/filters in a new tab
added https://antonok.com/tmp/procedural-filter-tests/test-extended-css-rules.txt to Custom lists
visited https://antonok.com/tmp/procedural-filter-tests/index.html in a new tab

Confirmed following numbered test cases are passed

  - 1,2.3
  - 6,7,8,9
  - 20,21
  - 24
  - 26
  - 28,29

step 4	step 5a	step 5b

Uni-verse · 2024-10-31T21:09:32Z

Verified on Samsung Galaxy S21 using the following version(s):

Brave	1.72.90 Chromium: 130.0.6723.70 (Official Build) beta (64-bit) 
Revision	5f14a2225ebf4fcd654e064bde93e77fcc5d8f39
OS	Android 13; Build/TP1A.220624.014; 33; REL

Using test plan in brave/brave-core#24688 (comment)

Ensured the following test case numbers are passing on https://antonok.com/tmp/procedural-filter-tests/index.html after adding https://antonok.com/tmp/procedural-filter-tests/test-extended-css-rules.txt to custom filter list
- 1, 2, 3
- 6, 7, 8, 9
- 20, 21, 24
- 26, 28, 29

`example`	`example`	`example`

Uni-verse · 2024-11-01T15:31:21Z

Verified on Samsung Galaxy Tab S7 using the following version(s):

Brave	1.72.93 Chromium: 131.0.6778.14 (Official Build) beta (64-bit) 
Revision	69e5dc20ca483a13316632df5bcd9279bb2a3cb7
OS	Android 13; Build/TP1A.220624.014; 33; REL

Using test plan in brave/brave-core#24688 (comment)

Ensured the following test case numbers are passing on https://antonok.com/tmp/procedural-filter-tests/index.html after adding https://antonok.com/tmp/procedural-filter-tests/test-extended-css-rules.txt to custom filter list
- 1, 2, 3
- 6, 7, 8, 9
- 20, 21, 24
- 26, 28, 29

`example`	`example`	`example`

MadhaviSeelam · 2024-11-06T20:26:56Z

Verification PASSED using

Brave	1.72.95 Chromium: 131.0.6778.24 (Official Build) beta (64-bit) 
Revision	006619fbaf6013cb3495b90fc3885eda343087e5
OS	Linux

Installed 1.72.95
launched Brave
opened brave://settings/shields/filters in a new tab
added https://antonok.com/tmp/procedural-filter-tests/test-extended-css-rules.txt to Custom lists
visited https://antonok.com/tmp/procedural-filter-tests/index.html in a new tab

Confirmed following numbered test cases are passed

  - 1,2.3
  - 6,7,8,9
  - 20,21
  - 24
  - 26
  - 28,29

step 4	step 5a	step 5b

hffvld · 2024-11-15T19:31:40Z

Verified on iPhone 14 and iPad Mini (6th gen) using version(s):

Device/OS: 
- iPhone 14 / iOS 17.7.1
- iPad Mini (6th gen) / iPadOS 18.0.1
Brave build: 1.73 (89)
BraveCore: 1.73.89 (131.0.6778.69)

Observed the issue #40771 which is not a blocker according to @antonok-edm

STEPS:

Launch Brave
Settings > Shields & Privacy
Content Filtering > Add Filter By URL
Add https://antonok.com/tmp/procedural-filter-tests/test-extended-css-rules.txt > Tap Update Lists
Disable all filters in Default filter lists > Tap Update Lists
Close the settings and navigate to https://antonok.com/tmp/procedural-filter-tests/index.html
Verify

ACTUAL RESULTS:

Verified that the following numbered test cases are passed
- 1, 2, 3
- 6, 7, 8, 9
- 20, 21
- 24
- 26
- 28, 29

iPhone 14

1	2	3	4

iPad Mini (6th gen)

1	2	3	4

antonok-edm added OS/Android Fixes related to Android browser functionality OS/Desktop labels Jul 13, 2021

antonok-edm self-assigned this Jul 13, 2021

antonok-edm added feature/shields/adblock Blocking ads & trackers with Shields features/shields/cosmetic-filtering uBO-parity labels Jul 13, 2021

ryanbr mentioned this issue Jul 13, 2021

Reddit inline ads are not blocked on Android when shields are set to aggressive #16789

Closed

antonok-edm mentioned this issue Dec 8, 2022

Ads on YouTube Search #26037

Closed

ryanbr mentioned this issue Jan 11, 2023

First video missing on youtube home page when signed in [iPad] brave/brave-ios#6666

Closed

antonok-edm mentioned this issue Jan 18, 2023

Support :has pseudoclass in cosmetic filters #27874

Closed

antonok-edm mentioned this issue Jan 25, 2023

uBO mode #8478

Closed

3 tasks

ShivanKaul mentioned this issue May 2, 2024

Renderer-side changes for improved performance related to adblocking #38029

Closed

ShivanKaul added the priority/P2 A bad problem. We might uplift this to the next planned release. label May 9, 2024

antonok-edm mentioned this issue Jul 16, 2024

procedural filtering brave/brave-core#24688

Merged

24 tasks

midnight-wonderer mentioned this issue Jul 27, 2024

Remove Shopee inline ads easylist-thailand/easylist-thailand#73

Closed

antonok-edm mentioned this issue Aug 27, 2024

Brave content filter doesn't work on content come from ajax request #40659

Closed

6 tasks

antonok-edm closed this as completed in brave/brave-core#24688 Sep 18, 2024

brave-builds added this to the 1.72.x - Nightly milestone Sep 18, 2024

antonok-edm added QA/Yes release-notes/include OS/iOS Fixes related to iOS browser functionality labels Sep 20, 2024

LaurenWags added the QA/Test-All-Platforms label Oct 18, 2024

MadhaviSeelam added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Oct 18, 2024

MadhaviSeelam added OS/macOS-arm64 and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Oct 18, 2024

MadhaviSeelam added QA Pass-macOS-arm64 and removed OS/macOS-arm64 labels Oct 18, 2024

MadhaviSeelam added the QA Pass-Win64 label Oct 24, 2024

Uni-verse added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Oct 31, 2024

Uni-verse added QA Pass - Android ARM and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Nov 1, 2024

Uni-verse added the QA Pass - Android Tab label Nov 1, 2024

MadhaviSeelam added the QA Pass-Linux label Nov 6, 2024

LaurenWags mentioned this issue Nov 11, 2024

Desktop Release Notes for 1.73.x Release #42210

Closed

hffvld mentioned this issue Nov 11, 2024

Android Release Notes for 1.73.x - Release #42218

Closed

hffvld added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Nov 15, 2024

hffvld added QA Pass - iPhone QA Pass - iPad and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Nov 15, 2024

kjozwiak mentioned this issue Nov 18, 2024

Pending verification's/Release Notes from previous 1.73.x milestones (formally 1.72.x) #42335

Open

18 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Support procedural cosmetic filtering #16935

Support procedural cosmetic filtering #16935

antonok-edm commented Jul 13, 2021 •

edited

Loading

antonok-edm commented Apr 12, 2022

intrnl commented Apr 12, 2022 •

edited

Loading

antonok-edm commented Apr 12, 2022 •

edited

Loading

dharnil commented Mar 6, 2024

MadhaviSeelam commented Oct 18, 2024 •

edited

Loading

MadhaviSeelam commented Oct 24, 2024

Uni-verse commented Oct 31, 2024 •

edited

Loading

Uni-verse commented Nov 1, 2024

MadhaviSeelam commented Nov 6, 2024

hffvld commented Nov 15, 2024

Support procedural cosmetic filtering #16935

Support procedural cosmetic filtering #16935

Comments

antonok-edm commented Jul 13, 2021 • edited Loading

antonok-edm commented Apr 12, 2022

intrnl commented Apr 12, 2022 • edited Loading

antonok-edm commented Apr 12, 2022 • edited Loading

dharnil commented Mar 6, 2024

MadhaviSeelam commented Oct 18, 2024 • edited Loading

Confirmed following numbered test cases are passed

MadhaviSeelam commented Oct 24, 2024

Confirmed following numbered test cases are passed

Uni-verse commented Oct 31, 2024 • edited Loading

Uni-verse commented Nov 1, 2024

MadhaviSeelam commented Nov 6, 2024

Confirmed following numbered test cases are passed

hffvld commented Nov 15, 2024

Observed the issue #40771 which is not a blocker according to @antonok-edm

antonok-edm commented Jul 13, 2021 •

edited

Loading

intrnl commented Apr 12, 2022 •

edited

Loading

antonok-edm commented Apr 12, 2022 •

edited

Loading

MadhaviSeelam commented Oct 18, 2024 •

edited

Loading

Uni-verse commented Oct 31, 2024 •

edited

Loading