Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reddit inline ads are not blocked on Android when shields are set to aggressive #16789

Closed
urbenlegend opened this issue Jul 6, 2021 · 5 comments
Assignees
Labels
closed/duplicate Issue has already been reported feature/shields/adblock Blocking ads & trackers with Shields OS/Android Fixes related to Android browser functionality

Comments

@urbenlegend
Copy link

Description

Unlike the desktop Brave browser, Reddit inline ads are not blocked on Android when shields are set to aggressive.

Steps to reproduce

  1. Launch Brave on Android
  2. Set Brave shields to aggressive
  3. Go to reddit.com
  4. Notice that an inline ad usually shows up as the second post in the feed.

Actual result

image

Expected result

No inline ads are shown when Brave shields are set to aggressive.

Issue reproduces how often

Every time

Version/Channel Information:

  • Can you reproduce this issue with the current Play Store version? Yes
  • Can you reproduce this issue with the current Play Store Beta version? Not tested
  • Can you reproduce this issue with the current Play Store Nightly version? Not tested

Device details

  • Install type (ARM, x86): ARM
  • Device type (Phone, Tablet, Phablet): Pixel 5
  • Android version: Android 12 Beta

Brave version

1.26.74

Website problems only

  • Does the issue resolve itself when disabling Brave Shields? No
  • Does the issue resolve itself when disabling Brave Rewards? No
  • Is the issue reproducible on the latest version of Chrome? N/A

Additional information

@urbenlegend urbenlegend added the OS/Android Fixes related to Android browser functionality label Jul 6, 2021
@lazymonkey2
Copy link

yes please block promoted ads!

@ryanbr
Copy link

ryanbr commented Jul 13, 2021

Hey @urbenlegend

Is fixed via reddit.com##.size-compact.Post:has([class*="promoted"]) in uBO. We currently don't support procedural filters (Like :has)

Reference ticket for procedural filters #16935

@lazymonkey2
Copy link

but on desktop the reddit promoted ads are already blocked.
does this means that the ad blocking engine on android is not the same as the one on desktop?

@lazymonkey2
Copy link

any news on this?

@antonok-edm
Copy link
Collaborator

antonok-edm commented Jan 24, 2023

I think we can close this as of #27874. I confirmed I wasn't able to find any promoted content on Reddit's mobile website in Nightly (1.49.x).

@antonok-edm antonok-edm added closed/duplicate Issue has already been reported feature/shields/adblock Blocking ads & trackers with Shields labels Jan 24, 2023
@antonok-edm antonok-edm added this to the Closed / Dupe / Invalid milestone Jan 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closed/duplicate Issue has already been reported feature/shields/adblock Blocking ads & trackers with Shields OS/Android Fixes related to Android browser functionality
Projects
None yet
Development

No branches or pull requests

4 participants