Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use error modals in Brave Rewards settings page instead of error notifications for linking-related errors (convert these notifications to error modals) #16652

Closed
Miyayes opened this issue Jun 28, 2021 · 5 comments · Fixed by brave/brave-core#10469
Assignees
Labels
feature/rewards OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-macOS QA/Yes release-notes/include

Comments

@Miyayes
Copy link
Collaborator

Miyayes commented Jun 28, 2021

Description

Due to some Uphold-specific states, some additional errors/modals will need to be shown in the Uphold case in order to best resolve #16468 per Szilard's comment here: brave/brave-core#9212 (comment).

@Miyayes Miyayes added feature/rewards OS/Android Fixes related to Android browser functionality OS/Desktop labels Jun 28, 2021
@Miyayes Miyayes changed the title Create specific error modals and notifications for Uphold case: "wallet verify fails because user tries verifying 2 different accounts with same custodian against same Wallet ID" Use error modals in Brave Rewards settings page instead of error notifications for linking-related errors (convert these notifications to error modals) Aug 18, 2021
@zenparsing zenparsing added the priority/P3 The next thing for us to work on. It'll ride the trains. label Aug 18, 2021
@Miyayes Miyayes added priority/P2 A bad problem. We might uplift this to the next planned release. and removed priority/P3 The next thing for us to work on. It'll ride the trains. labels Sep 28, 2021
@Miyayes
Copy link
Collaborator Author

Miyayes commented Sep 28, 2021

Increased priority to make sure error messages can be surfaced to users with the new Rewards panel 2.0 UI.

@szilardszaloki
Copy link
Contributor

Showing modals on the Rewards page is not yet implemented on Android. Should we remove the OS/Android tag and create a separate issue for Android?
cc: @Miyayes @deeppandya

@deeppandya
Copy link

Showing modals on the Rewards page is not yet implemented on Android. Should we remove the OS/Android tag and create a separate issue for Android?
cc: @Miyayes @deeppandya

I would prefer to have a separate issue for Android.

@LaurenWags
Copy link
Member

Per #16652 (comment), removed OS/Android label and logged #19246.

@LaurenWags LaurenWags removed the OS/Android Fixes related to Android browser functionality label Nov 5, 2021
@LaurenWags
Copy link
Member

LaurenWags commented Nov 8, 2021

Verified passed with

Brave	1.33.69 Chromium: 96.0.4664.35 (Official Build) nightly (x86_64)
Revision	8df3babf8da8faa8aacb78f4848ef66a93b4944b-refs/branch-heads/4664@{#680}
OS	macOS Version 11.6.1 (Build 20G224)
Uphold Notifications - PASSED
upholdBATNotAllowedModal-PASSED

Used Charles Proxy to simulate BAT not being available in my region.
Confirmed modal notification shown, not panel notification.
Confirmed "Learn More" linked to https://support.uphold.com/hc/en-us/articles/360033020351-Brave-BAT-and-US-availability as per PR.
Confirmed "Close" button closed the modal.

BAT unavailable modal
upholdBlockedUserModal-PASSED

Used Charles Proxy to simulate status = blocked.
Confirmed modal notification shown, not panel notification.
Confirmed "Learn More" linked to https://support.uphold.com/hc/en-us/articles/360045765351-Why-we-block-or-restrict-accounts-and-how-to-reduce-the-risk as per PR.
Confirmed "Close" button closed the modal.

blocked
upholdPendingUserModal-PASSED

Used Charles Proxy to simulate status = pending.
Confirmed modal notification shown, not panel notification.
Confirmed "Learn More" linked to https://support.uphold.com/hc/en-us/articles/206695986-How-do-I-sign-up-for-Uphold-Web- as per PR.
Confirmed "Close" button closed the modal.

pending
upholdRestrictedUserModal-PASSED

Used Charles Proxy to simulate status = restricted.
Confirmed modal notification shown, not panel notification.
Confirmed "Learn More" linked to https://support.uphold.com/hc/en-us/articles/360045765351-Why-we-block-or-restrict-accounts-and-how-to-reduce-the-risk as per PR.
Confirmed "Close" button closed the modal.

restricted
kycRequiredModal-PASSED

Confirmed modal notification shown, not panel notification.
Confirmed no "Learn More" link.
Confirmed "Close" button closed the modal.

KYCreqd
mismatchedProviderAccountsModal-PASSED

Confirmed modal notification shown, not panel notification.
Confirmed "Learn More" linked to https://support.brave.com/hc/en-us/articles/360034841711-What-is-a-verified-wallet- as per PR.
Confirmed "Close" button closed the modal.

2accts
Brave | 1.33.83 Chromium: 96.0.4664.45 (Official Build) beta (x86_64)
-- | --
Revision | 76e4c1bb2ab4671b8beba3444e61c0f17584b2fc-refs/branch-heads/4664@{#947}
OS | macOS Version 11.6.1 (Build 20G224)
bitFlyer Notifications - PASSED but follow up issue logged
kycRequiredModal-FAILED

Confirmed modal notification shown, not panel notification.
Confirmed no "Learn More" link.
Confirmed "Close" button closed the modal.
However, notification text does not match brave/brave-core#10469 (comment). It is the same as 1.32.x for this scenario. Logged follow up issue #19572 per discussion with @Miyayes.

bF-noKYC
mismatchedProviderAccountsModal-PASSED

Confirmed modal notification shown, not panel notification.
Confirmed "Learn More" linked to https://support.brave.com/hc/en-us/articles/360034841711-What-is-a-verified-wallet- as per PR.
Confirmed "Close" button closed the modal.

bF-mismatch
Gemini Notifications - PASSED
kycRequiredModal-PASSED

Confirmed modal notification shown, not panel notification.
Confirmed no "Learn More" link.
Confirmed "Close" button closed the modal.

gemini-kycreq
mismatchedProviderAccountsModal-PASSED

Confirmed modal notification shown, not panel notification.
Confirmed "Learn More" linked to https://support.brave.com/hc/en-us/articles/360034841711-What-is-a-verified-wallet- as per PR.
Confirmed "Close" button closed the modal.

gemini-2accts
Brave | 1.33.85 Chromium: 96.0.4664.45 (Official Build) beta (x86_64)
-- | --
Revision | 76e4c1bb2ab4671b8beba3444e61c0f17584b2fc-refs/branch-heads/4664@{#947}
OS | macOS Version 11.6.1 (Build 20G224)
Uphold deviceLimitReachedModal-PASSED

Confirmed modal notification shown, not panel notification.
Confirmed "Learn More" linked to https://support.brave.com/hc/en-us/articles/360056508071 as per PR.
Confirmed "Close" button closed the modal.

uphold-devicelimit
bitFlyer deviceLimitReachedModal-PASSED

Confirmed modal notification shown, not panel notification.
Confirmed "Learn More" linked to https://support.brave.com/hc/en-us/articles/360056508071 as per PR.
Confirmed "Close" button closed the modal.

bitflyer-devicelimit
Gemini deviceLimitReachedModal-PASSED

Confirmed modal notification shown, not panel notification.
Confirmed "Learn More" linked to https://support.brave.com/hc/en-us/articles/360056508071 as per PR.
Confirmed "Close" button closed the modal.

gemini-devicelimit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/rewards OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-macOS QA/Yes release-notes/include
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants