-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use error modals in Brave Rewards settings page instead of error notifications for linking-related errors (convert these notifications to error modals) #16652
Comments
Increased priority to make sure error messages can be surfaced to users with the new Rewards panel 2.0 UI. |
Showing modals on the Rewards page is not yet implemented on Android. Should we remove the |
I would prefer to have a separate issue for Android. |
Per #16652 (comment), removed |
Verified passed with
Uphold Notifications - PASSEDupholdBATNotAllowedModal-PASSEDUsed Charles Proxy to simulate BAT not being available in my region. upholdBlockedUserModal-PASSEDUsed Charles Proxy to simulate status = blocked. upholdPendingUserModal-PASSEDUsed Charles Proxy to simulate status = pending. upholdRestrictedUserModal-PASSEDUsed Charles Proxy to simulate status = restricted.
bitFlyer Notifications - PASSED but follow up issue loggedkycRequiredModal-FAILEDConfirmed modal notification shown, not panel notification. Gemini Notifications - PASSED
Uphold deviceLimitReachedModal-PASSEDConfirmed modal notification shown, not panel notification. |
Description
Due to some Uphold-specific states, some additional errors/modals will need to be shown in the Uphold case in order to best resolve #16468 per Szilard's comment here: brave/brave-core#9212 (comment).
The text was updated successfully, but these errors were encountered: