Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Side bar show always doesn't work properly #15958

Closed
srirambv opened this issue May 19, 2021 · 1 comment · Fixed by brave/brave-core#8878
Closed

Side bar show always doesn't work properly #15958

srirambv opened this issue May 19, 2021 · 1 comment · Fixed by brave/brave-core#8878

Comments

@srirambv
Copy link
Contributor

Description

Side bar show always doesn't work properly

Steps to Reproduce

  1. Update to nightly
  2. Enable side bar flag
  3. Set it to show on hover, works as expected
  4. Set it show always
  5. Move cursor away from sidebar, hides again
  6. Select show always, sticks properly

Actual result:

Sidebar

Expected result:

Setting should work the first time

Reproduces how often:

Easy

Brave version (brave://version info)

Brave 1.26.24 Chromium: 91.0.4472.57 (Official Build) nightly (64-bit)
Revision e3443317fa07f1e9997e4a9c738eddfefc3c0292-refs/branch-heads/4472_54@{#6}
OS Windows 10 OS Version 2009 (Build 19042.985)

Version/Channel Information:

  • Can you reproduce this issue with the current release? NA
  • Can you reproduce this issue with the beta channel? NA
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards? NA
  • Is the issue reproducible on the latest version of Chrome? NA

Miscellaneous Information:

cc: @simonhong @rebron

@simonhong simonhong self-assigned this May 20, 2021
@simonhong simonhong added the feature/sidebar Relating to Brave's Sidebar feature label May 20, 2021
simonhong added a commit to brave/brave-core that referenced this issue May 20, 2021
fix brave/brave-browser#15958
When sidebar show option context menu gets visible or hidden,
view's mouse entered/exited callback is called even if mouse is still
in the view. Because of this, newly changed option is not applied
well.
simonhong added a commit to brave/brave-core that referenced this issue May 20, 2021
fix brave/brave-browser#15958
When sidebar show option context menu gets visible or hidden,
view's mouse entered/exited callback is called even if mouse is still
in the view. Because of this, newly changed option is not applied well.
@simonhong simonhong added this to the 1.27.x - Nightly milestone May 20, 2021
@stephendonner
Copy link

Verified FIXED using the inline steps with build

Brave 1.27.25 Chromium: 91.0.4472.77 (Official Build) nightly (x86_64)
Revision 1cecd5c8a856bc2a5adda436e7b84d8d21b339b6-refs/branch-heads/4472@{#1246}
OS macOS Version 11.4 (Build 20F71)

Steps:

  1. new profile, launched Brave
  2. enabled sidebar flag
  3. set it to Show on mouseover, works as expected
  4. set it Show always
  5. moved cursor away from sidebar, it remained, as expected

sidebar-hover

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants