-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add QR code generator to the URL bar #15900
Labels
OS/Desktop
priority/P3
The next thing for us to work on. It'll ride the trains.
QA Pass-macOS
QA Pass-Win64
QA/Yes
release-notes/include
Milestone
Comments
bsclifton
added a commit
to brave/brave-core
that referenced
this issue
May 17, 2021
Fixes brave/brave-browser#15900 Also includes cleanup; removes obsolete flags added with #5435 (this experiment was removed and enabled by default with Chromium 91)
24 tasks
rebron
added
the
priority/P3
The next thing for us to work on. It'll ride the trains.
label
May 17, 2021
bsclifton
added a commit
to brave/brave-core
that referenced
this issue
May 18, 2021
Fixes brave/brave-browser#15900 Also includes cleanup; removes obsolete flags added with #5435 (this experiment was removed and enabled by default with Chromium 91)
7 tasks
stephendonner
added
the
QA/In-Progress
Indicates that QA is currently in progress for that particular issue
label
May 18, 2021
Verified
Steps:
Verification PASSED on
|
stephendonner
added
QA Pass-macOS
and removed
QA/In-Progress
Indicates that QA is currently in progress for that particular issue
labels
May 18, 2021
This was referenced Jun 1, 2021
rebron
changed the title
Re-enable sharing-qr-code-generator feature
Add QR code generator to URL bar
Jun 21, 2021
rebron
changed the title
Add QR code generator to URL bar
Add QR code generator to the URL bar
Jun 21, 2021
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
OS/Desktop
priority/P3
The next thing for us to work on. It'll ride the trains.
QA Pass-macOS
QA Pass-Win64
QA/Yes
release-notes/include
Test plan
Description
QR code sharing disabled with #15008 in browser version 1.23
Security review for this feature was recently done and was approved:
https://github.com/brave/security/issues/450
No calls are being made to Google (or elsewhere) to generate the code OR for the URL generated (ex: it's not using a redirect link)
The text was updated successfully, but these errors were encountered: