Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

maximum_promoted_content_ads_per_hour and maximum_promoted_content_ads_per_day are not respected #15076

Closed
btlechowski opened this issue Apr 1, 2021 · 3 comments

Comments

@btlechowski
Copy link

btlechowski commented Apr 1, 2021

Follow up to #14341.
Promoted content ads views are not limited by maximum_promoted_content_ads_per_hour (default 4) and maximum_promoted_content_ads_per_day (default 20).

Currently, promoted content ads are always shown, but user is paid only once per ad.

Steps to Reproduce

  1. Follow Brave Ads maximum promoted content ads per hour - 1 per hour from https://github.com/brave/internal/issues/759
    Or
  2. Follow Brave Ads maximum promoted content ads per day - 1 per day from https://github.com/brave/internal/issues/759

Actual result:

Promoted content ads are always shown
Promoted content ads are not limited by maximum_promoted_content_ads_per_hour (default 4) and maximum_promoted_content_ads_per_day (default 20).
User is paid only once per ad.

Expected result:

Promoted content ads are limited by maximum_promoted_content_ads_per_hour and maximum_promoted_content_ads_per_day.

Reproduces how often:

Easily reproduced

Brave version (brave://version info)

Brave 1.23.53 Chromium: 89.0.4389.105 (Official Build) beta (64-bit)
Revision 14f44e21a9d539cd49c72468a29bfca4fa43f710-refs/branch-heads/4389_90@{#7}
OS Linux

cc @tmancey @moritzhaller @jsecretan @mattmcalister @brave/legacy_qa

@tmancey
Copy link
Contributor

tmancey commented Apr 23, 2021

@btlechowski Promoted content ads can be shown unlimited times however users will be rewarded based upon the ads per hour/day settings.

@tmancey
Copy link
Contributor

tmancey commented Apr 23, 2021

Closing issue as working as expected. Thanks

@tmancey tmancey closed this as completed Apr 23, 2021
@btlechowski
Copy link
Author

Verification passed on

Brave 1.26.53 Chromium: 91.0.4472.77 (Official Build) beta (64-bit)
Revision 1cecd5c8a856bc2a5adda436e7b84d8d21b339b6-refs/branch-heads/4472@{#1246}
OS Ubuntu 18.04 LTS

promoted content ads per day

First ad shown and paid for:

[16559:16559:0611/184853.689081:VERBOSE6:promoted_content_ad_event_viewed.cc(32)] Successfully logged promoted content ad viewed event
[16559:16559:0611/184854.793517:VERBOSE1:confirmations.cc(271)] Added 1 unblinded payment token with an estimated redemption value of 0.025 BAT, you now have 1 unblinded payment tokens

2nd ad blocked:

[16559:16559:0611/184920.558648:VERBOSE2:permission_rule_util.cc(23)] You have exceeded the allowed promoted content ads per day
[16559:16559:0611/184920.558690:VERBOSE1:promoted_content_ad.cc(123)] Promoted content ad: Not allowed

promoted content ads per hour

First ad shown and paid for:

[17901:17901:0611/190112.066317:VERBOSE6:promoted_content_ad_event_viewed.cc(32)] Successfully logged promoted content ad viewed event

2nd ad blocked:

[17901:17901:0611/190335.772546:VERBOSE2:permission_rule_util.cc(23)] You have exceeded the allowed promoted content ads per hour
[17901:17901:0611/190335.772628:VERBOSE1:promoted_content_ad.cc(123)] Promoted content ad: Not allowed

@tmancey tmancey added feature/brave-news formerly brave-today and removed feature/ads labels Sep 21, 2021
@tmancey tmancey reopened this Sep 21, 2021
@tmancey tmancey closed this as completed Sep 21, 2021
@tmancey tmancey added this to Ads Jun 10, 2024
@tmancey tmancey moved this to Done in Ads Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

No branches or pull requests

2 participants