Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure ad serving via variations service #14341

Closed
tmancey opened this issue Feb 24, 2021 · 1 comment · Fixed by brave/brave-core#8067
Closed

Configure ad serving via variations service #14341

tmancey opened this issue Feb 24, 2021 · 1 comment · Fixed by brave/brave-core#8067

Comments

@tmancey
Copy link
Contributor

tmancey commented Feb 24, 2021

No description provided.

@tmancey tmancey self-assigned this Feb 24, 2021
@tmancey tmancey added this to the 1.23.x - Nightly milestone Feb 25, 2021
@btlechowski btlechowski added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Mar 24, 2021
@btlechowski
Copy link

btlechowski commented Mar 30, 2021

Verification passed on

Brave 1.23.53 Chromium: 89.0.4389.105 (Official Build) beta (64-bit)
Revision 14f44e21a9d539cd49c72468a29bfca4fa43f710-refs/branch-heads/4389_90@{#7}
OS Ubuntu 18.04 LTS

Verified relevant test cases from https://github.com/brave/internal/issues/759

Brave Ads maximum ad notifications per day - 1 per day
Second ad was not shown:

[6733:6733:0330/033947.373014:VERBOSE2:permission_rule_util.cc(23)] You have exceeded the allowed ads per day
[6733:6733:0330/033947.373102:VERBOSE1:ad_notification_serving.cc(137)] Ad notification not served: Not allowed
[6733:6733:0330/033947.373177:VERBOSE1:ad_notification_serving.cc(85)] Ad notification not delivered

Brave Ads maximum new tab page ads per hour - 1 per hour
First ad shown:

[8323:8323:0330/032321.451668:VERBOSE3:new_tab_page_ad_event_viewed.cc(24)] Viewed new tab page ad with uuid a4d373b8-cfff-463d-a7be-fd4cff7d8b7e and creative instance id 5b4cb3f4-5285-4597-87c5-3082fe37938a

Second ad not shown:

[8323:8323:0330/032342.315339:VERBOSE2:permission_rule_util.cc(23)] You have exceeded the allowed new tab page ads per hour
[8323:8323:0330/032342.315402:VERBOSE1:new_tab_page_ad.cc(119)] New tab page ad: Not allowed

Brave Ads maximum new tab page ads per day - 1 per day
First ad shown:

[9653:9653:0330/034132.160485:VERBOSE3:new_tab_page_ad_event_viewed.cc(24)] Viewed new tab page ad with uuid 3a929f64-da42-4cec-bd6f-b7b54344d083 and creative instance id 5b4cb3f4-5285-4597-87c5-3082fe37938a

Second ad not shown:

[9653:9653:0330/034216.212754:VERBOSE2:permission_rule_util.cc(23)] You have exceeded the allowed new tab page ads per day
[9653:9653:0330/034216.213725:VERBOSE1:new_tab_page_ad.cc(119)] New tab page ad: Not allowed

Brave Ads maximum promoted content ads per hour - 1 per hour
First ad shown:

[16515:16515:0330/045837.848869:VERBOSE3:promoted_content_ad_event_viewed.cc(24)] Viewed promoted content ad with uuid 7370c10c8c28878793ad7b6adc2a93a79882e7878f934f172d7cfa33b8cfabc4 and creative instance id 40a69fa9-3814-4ec4-bee8-a176c8fb4690

Same ad shown the second time:

[16515:16515:0330/050137.703977:VERBOSE2:exclusion_rule_util.h(26)] uuid 7370c10c8c28878793ad7b6adc2a93a79882e7878f934f172d7cfa33b8cfabc4 has exceeded the frequency capping for new tab page ad
[16515:16515:0330/050137.704062:VERBOSE1:promoted_content_ad.cc(122)] Promoted content ad: Not allowed

Brave Ads maximum promoted content ads per day - 1 per day
Same ad shown the second time:

[21110:21110:0330/055057.214363:VERBOSE2:exclusion_rule_util.h(26)] uuid 7370c10c8c28878793ad7b6adc2a93a79882e7878f934f172d7cfa33b8cfabc4 has exceeded the frequency capping for new tab page ad
[21110:21110:0330/055057.214431:VERBOSE1:promoted_content_ad.cc(122)] Promoted content ad: Not allowed

@btlechowski btlechowski added QA Pass-Linux and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Mar 30, 2021
@tmancey tmancey added this to Ads Jun 10, 2024
@tmancey tmancey moved this to Done in Ads Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants