-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Twitch VODs aren't displaying in Auto Contribute panel correctly #1492
Comments
cc @NejcZdovc not sure if we can get this into 0.55.x. if we don't, I don't know how contributions will go with multiple VODs listed for same creator. |
@srirambv were the bottom 3 VODs or live? live streams display as expected. |
@LaurenWags yes all the 4 listed ones are live streams. The one with |
@srirambv hanryang1125 is vod and not live stream as far as I can tell. Did it switch to vod maybe? |
@NejcZdovc sorry my bad. Yes hanryan1125 is a vod. |
based on that I already have a fix for this in another PR |
@srirambv I don't think it's related to non-english characters being in the name... I can reproduce this with a brand new profile using the following VOD: The title of the video is
Awesome 👍 |
Resolves brave/brave-browser#968 Resolves brave/brave-browser#1492 Resolves brave/brave-browser#1493
Verified passed with
Verification Passed with
Verification Passed on
|
Description
If you visit a Twitch VOD, it is not being displayed in the Auto Contribute panel correctly. Each VOD is listed individually instead of under one creator.
Steps to Reproduce
Actual result:
VODs are listed individually instead of grouped under one creator as they were on b-l:
Expected result:
VODs for same creator should be listed once. So in the above example they should be grouped under something like
adam13531 on Twitch
Reproduces how often:
easy
Brave version (chrome://version info)
Reproducible on current release:
Website problems only:
Additional Information
reproduced by by @kjozwiak on macOS
The text was updated successfully, but these errors were encountered: