conversion date in the logs is always 0 hours 0 minutes 0 seconds

[btlechowski]

Not sure if this is actual bug or the date was added by mistake,

Steps to Reproduce

Follow test case: Notification ad - same set from https://github.com/brave/internal/issues/758

Actual result:

conversion date in the logs is always 0 hours 0 minutes 0 seconds
Example:

[11707:11707:0317/143919.998869:VERBOSE1:conversions.cc(116)] Checking URL for conversions
[11707:11707:0317/143920.120764:VERBOSE1:conversions.cc(224)] Conversion for campaign id d4d0474c-277a-4714-b25d-7b484cdb580a, creative set id 0a697a3b-233a-44bc-a337-e2441fb277a7, creative instance id 30ecd70f-f56d-4745-a457-4035fcab54b6 and advertiser id  in 0 hours, 0 minutes, 0 seconds at 2:39 PM
[11707:11707:0317/143920.127668:VERBOSE6:conversions.cc(275)] Successfully logged conversion event
[11707:11707:0317/143920.136028:VERBOSE3:conversions.cc(295)] Successfully appended conversion to queue

Important: ad conversion confirmation is scheduled later:

[11707:11707:0317/143920.140678:VERBOSE1:conversions.cc(399)] Convert campaign id d4d0474c-277a-4714-b25d-7b484cdb580a, creative set id 0a697a3b-233a-44bc-a337-e2441fb277a7, creative instance id 30ecd70f-f56d-4745-a457-4035fcab54b6 and advertiser id  in 0 hours, 18 minutes, 23 seconds at 2:57 PM

Expected result:

TBD

Reproduces how often:

100% repro rate

Brave version (brave://version info)

Brave	1.22.62 Chromium: 89.0.4389.90 (Official Build) beta (64-bit)
Revision	62eb262cdaae9ef819aadd778193781455ec7a49-refs/branch-heads/4389@{#1534}
OS	Ubuntu 18.04 LTS

cc @tmancey @moritzhaller @jsecretan @rebron @brave/legacy_qa

[moritzhaller]

It looks correct to me since the timestamp is still logged, just the "time until" formatting of the message makes it seem odd. Random delay for actually transmitting the confirmation is important and you mentioned it works @btlechowski. Maybe @tmancey can confirm also.

[tmancey]

Agreed @moritzhaller we just need to fix the time formatting.

[btlechowski]

Verification passed on

Brave	1.24.16 Chromium: 89.0.4389.105 (Official Build) nightly (64-bit)
Revision	14f44e21a9d539cd49c72468a29bfca4fa43f710-refs/branch-heads/4389_90@{#7}
OS	Ubuntu 18.04 LTS

Verified test plan from the description, using v7 of the catalog.
Verified conversion is triggered and full date is shown:

[30077:30077:0324/232941.438356:VERBOSE1:conversions.cc(289)] Conversion for campaign id 0d01425b-c970-4a25-b2d0-ccf748cfaf6e, creative set id c7e7a381-4c74-4dd9-9b6d-4edf9330454b, creative instance id 54592ab6-5a8e-42e6-8e11-9e9c04e9eecb and advertiser id ecbcc833-8b1d-4867-98f7-ad2341396ce8 on Wednesday, March 24, 2021 at 11:29:41 PM
[30077:30077:0324/232941.452205:VERBOSE6:conversions.cc(342)] Successfully logged conversion event
[30077:30077:0324/232941.459234:VERBOSE3:conversions.cc(365)] Successfully appended conversion to queue
[30077:30077:0324/232941.460927:VERBOSE1:conversions.cc(470)] Convert campaign id 0d01425b-c970-4a25-b2d0-ccf748cfaf6e, creative set id c7e7a381-4c74-4dd9-9b6d-4edf9330454b, creative instance id 54592ab6-5a8e-42e6-8e11-9e9c04e9eecb and advertiser id ecbcc833-8b1d-4867-98f7-ad2341396ce8 in 0 hours, 5 minutes, 11 seconds at 11:34 PM

Verified conversion was successful:

[30077:30077:0324/233452.438665:VERBOSE1:conversions.cc(411)] Successfully converted ad with campaign id 0d01425b-c970-4a25-b2d0-ccf748cfaf6e, creative set id c7e7a381-4c74-4dd9-9b6d-4edf9330454b, creative instance id 54592ab6-5a8e-42e6-8e11-9e9c04e9eecb and advertiser id ecbcc833-8b1d-4867-98f7-ad2341396ce8 on Wednesday, March 24, 2021 at 11:34:52 PM
[30077:30077:0324/233452.438731:VERBOSE1:confirmations.cc(89)] Confirming conversion ad for creative instance id 54592ab6-5a8e-42e6-8e11-9e9c04e9eecb