Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android] Crash on closing tab with Tab Groups enabled #14491

Closed
samartnik opened this issue Mar 5, 2021 · 2 comments · Fixed by brave/brave-core#8138
Closed

[Android] Crash on closing tab with Tab Groups enabled #14491

samartnik opened this issue Mar 5, 2021 · 2 comments · Fixed by brave/brave-core#8138

Comments

@samartnik
Copy link
Contributor

Description

There is a crash on closing tab with Tab Groups enabled.

Steps to reproduce

  1. Go to brave://flags
  2. Enable Tab Groups and relaunch app twice to apply changes.
  3. Try to close tab, it will crash.

Actual result

Crash

Expected result

No crash

Issue reproduces how often

Easily reproduced

Version/Channel Information:

  • Can you reproduce this issue with the current Play Store version?
  • Can you reproduce this issue with the current Play Store Beta version?
  • Can you reproduce this issue with the current Play Store Nightly version?

Device details

  • Install type (ARM, x86):
  • Device type (Phone, Tablet, Phablet):
  • Android version:

Brave version

1.21.x

Website problems only

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Additional information

@kjozwiak
Copy link
Member

kjozwiak commented Mar 6, 2021

Verification PASSED on Samsung S10+ running Android 11 using the following build:

1.21.74 CR: 89.0.4389.72
  • reproduced the original issue via 1.21.73 CR: 89.0.4389.72 by enabling Tab Groups as per the STR/Cases from [Android] Crash on closing tab with Tab Groups enabled #14491 (comment)
  • enabled Tab Groups via brave://flags using 1.21.73 CR: 89.0.4389.72 and ensured that updating to 1.21.74 CR: 89.0.4389.72 fixes the crash
  • enabled Tab Groups via brave://flags on a new 1.21.74 CR: 89.0.4389.72 install and ensured Brave wasn't crashing when closing tabs.

@kjozwiak
Copy link
Member

kjozwiak commented Mar 6, 2021

Couldn't reproduce the above using a tablet using 1.21.73 CR: 89.0.4389.72. Looks like Tab Groups under brave://flags specifically mentions this is a phone feature. Adding android-phone-specific.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants