Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add site button is not shown by default. Only shows when hovered over #14480

Closed
srirambv opened this issue Mar 5, 2021 · 1 comment · Fixed by brave/brave-core#8163
Closed

Add site button is not shown by default. Only shows when hovered over #14480

srirambv opened this issue Mar 5, 2021 · 1 comment · Fixed by brave/brave-core#8163
Assignees
@simonhong
Labels
bug feature/new-tab OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-macOS QA/Yes release-notes/exclude
Milestone
1.23.x - Release

Comments

@srirambv
Copy link
Contributor

srirambv commented Mar 5, 2021

Description

Add site button is not shown by default. Only shows when hovered over

Steps to Reproduce

  1. Install nightly
  2. Set toptiles to be favourites
  3. No Add site button is shown until you hover under the stats

Actual result:

Top.Tiles.Hover.mp4

Expected result:

Should show the add site by default so user knows its there rather than letting the user guess where it will be

Reproduces how often:

Easy

Brave version (brave://version info)

Brave 1.23.19 Chromium: 89.0.4389.72 (Official Build) nightly (64-bit)
Revision 3f345f156bfd157bd1bea06310e55f3fb2490359-refs/branch-heads/4389@{#1393}
OS Linux

Version/Channel Information:

  • Can you reproduce this issue with the current release? NA
  • Can you reproduce this issue with the beta channel? NA
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards? NA
  • Is the issue reproducible on the latest version of Chrome? NA

Miscellaneous Information:

cc: @simonhong @rebron @karenkliu
@rebron rebron added the priority/P3 The next thing for us to work on. It'll ride the trains. label Mar 5, 2021
@simonhong simonhong mentioned this issue Mar 6, 2021
Merged
24 tasks
simonhong added a commit to brave/brave-core that referenced this issue Mar 6, 2021
@simonhong
Shows addSite tile by default on topSites favorites mode
35ef458 
fix: brave/brave-browser#14480

It's only hidden when user dragging other tiles because it is moving by
other tile's dragging although it's position is not changed at the end.
There is an issue for it.
 (see clauderic/react-sortable-hoc#648)
@simonhong simonhong added this to the 1.23.x - Nightly milestone Mar 9, 2021
@stephendonner stephendonner added QA/In-Progress Indicates that QA is currently in progress for that particular issue and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Mar 9, 2021
@stephendonner
Copy link

Verified PASSED on nightly using build

Brave 1.23.25 Chromium: 89.0.4389.86 (Official Build) nightly (x86_64)
Revision 0c2dac31bc21e806a791641316e99920f84ea52c-refs/branch-heads/4389@{#1472}
OS macOS Version 11.2.3 (Build 20D91)

Verified that when Favorites is selected under Show Top Sites, the Add site icon and text appears when there aren't any sites shown (and when there are, as before).

Example Example
Screen Shot 2021-03-09 at 10 53 02 AM Screen Shot 2021-03-09 at 10 51 08 AM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@simonhong simonhong

Labels
bug feature/new-tab OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-macOS QA/Yes release-notes/exclude
Projects
None yet
Milestone
1.23.x - Release
Development

Successfully merging a pull request may close this issue.

Shows addSite tile by default on topSites favorites mode brave/brave-core
4 participants
@stephendonner @rebron @simonhong @srirambv