Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

blacklist Chromium PDF Viewer #1386

Closed
LaurenWags opened this issue Oct 1, 2018 · 3 comments · Fixed by brave/brave-core#539
Closed

blacklist Chromium PDF Viewer #1386

LaurenWags opened this issue Oct 1, 2018 · 3 comments · Fixed by brave/brave-core#539

Comments

@LaurenWags
Copy link
Member

Description

Per #1375 (comment) Chromium PDF Viewer should be blacklisted.

Steps to Reproduce

  1. Remove any profile data.
  2. Launch beta version with/Applications/Brave\ Browser\ Beta.app/Contents/MacOS/Brave\ Browser\ Beta --show-component-extension-options
  3. Navigate to chrome://extensions

Actual result:

Chromium PDF Viewer is displayed
screen shot 2018-10-01 at 5 47 41 pm

Expected result:

Chromium PDF Viewer should not be used

Reproduces how often:

easily

Brave version (chrome://version info)

Brave 0.55.10 Chromium: 70.0.3538.22 (Official Build) beta(64-bit)
Revision ac9418ba9c3bd7f6baaffa0b055dfe147e0f8364-refs/branch-heads/3538@{#468}
OS Mac OS X

Reproducible on current release:

  • Does it reproduce on brave-browser dev/beta builds? n/a
  • Does it reproduce on browser-laptop? n/a

Website problems only:

  • Does the issue resolve itself when disabling Brave Shields? n/a
  • Is the issue reproducible on the latest version of Chrome? n/a

Additional Information

#1375
#1376

@bbondy
Copy link
Member

bbondy commented Oct 2, 2018

Note when QA'ing this, it will show in the list but you can't turn it on. It will be blacklisted / turned off.

bbondy added a commit to brave/brave-core that referenced this issue Oct 2, 2018
@kjozwiak
Copy link
Member

kjozwiak commented Oct 2, 2018

Thanks for the quick fix @bbondy 👍

@LaurenWags
Copy link
Member Author

LaurenWags commented Oct 8, 2018

Verified passed with

Brave 0.55.11 Chromium: 70.0.3538.35 (Official Build) beta(64-bit)
Revision 28dcb499844fa40c28d5f62e337876cb936f79f5-refs/branch-heads/3538@{#678}
OS Mac OS X

Verification passed on

Brave 0.55.11 Chromium: 70.0.3538.35 (Official Build) beta (64-bit)
Revision 28dcb499844fa40c28d5f62e337876cb936f79f5-refs/branch-heads/3538@{#678}
OS Windows 7

Verification Passed on

Brave 0.55.12 Chromium: 70.0.3538.45 (Official Build) beta (64-bit)
Revision cbdc32e4334458954e9def214d7e5fa1ca1960eb-refs/branch-heads/3538@{#830}
OS Linux

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants