Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Transition Brave Ads conversions queue from JSON to a database table #13697

Closed
tmancey opened this issue Jan 21, 2021 · 1 comment · Fixed by brave/brave-core#7961
Closed

Transition Brave Ads conversions queue from JSON to a database table #13697

tmancey opened this issue Jan 21, 2021 · 1 comment · Fixed by brave/brave-core#7961
Assignees
@tmancey
Labels
enhancement feature/ads OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-All-Platforms QA/Yes release-notes/exclude
Milestone
1.22.x - Release

Comments

@tmancey
Copy link
Contributor

tmancey commented Jan 21, 2021

Transition Brave Ads conversions queue from JSON to a database table and add campaign_id and advertiser_id to unblock #13368 for @moritzhaller
@tmancey tmancey self-assigned this Jan 21, 2021
@tmancey tmancey mentioned this issue Feb 15, 2021
Merged
23 tasks
@tmancey tmancey added this to the 1.22.x - Nightly milestone Feb 19, 2021
@btlechowski btlechowski added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Mar 3, 2021
@btlechowski btlechowski removed the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Mar 17, 2021
@btlechowski
Copy link

btlechowski commented Mar 17, 2021 •
edited by LaurenWags
Loading

Verification passed on

Brave 1.22.62 Chromium: 89.0.4389.90 (Official Build) beta (64-bit)
Revision 62eb262cdaae9ef819aadd778193781455ec7a49-refs/branch-heads/4389@{#1534}
OS Ubuntu 18.04 LTS

Verified test plan from:

postview verification

postview

Notification ad - same set
Verified conversion was triggered

[11707:11707:0317/143919.998869:VERBOSE1:conversions.cc(116)] Checking URL for conversions
[11707:11707:0317/143920.120764:VERBOSE1:conversions.cc(224)] Conversion for campaign id d4d0474c-277a-4714-b25d-7b484cdb580a, creative set id 0a697a3b-233a-44bc-a337-e2441fb277a7, creative instance id 30ecd70f-f56d-4745-a457-4035fcab54b6 and advertiser id  in 0 hours, 0 minutes, 0 seconds at 2:39 PM
[11707:11707:0317/143920.127668:VERBOSE6:conversions.cc(275)] Successfully logged conversion event
[11707:11707:0317/143920.136028:VERBOSE3:conversions.cc(295)] Successfully appended conversion to queue
[11707:11707:0317/143920.140678:VERBOSE1:conversions.cc(399)] Convert campaign id d4d0474c-277a-4714-b25d-7b484cdb580a, creative set id 0a697a3b-233a-44bc-a337-e2441fb277a7, creative instance id 30ecd70f-f56d-4745-a457-4035fcab54b6 and advertiser id  in 0 hours, 18 minutes, 23 seconds at 2:57 PM

Verified conversion was successful:

[11707:11707:0317/145743.170399:VERBOSE1:conversions.cc(340)] Successfully converted ad with campaign id d4d0474c-277a-4714-b25d-7b484cdb580a, creative set id 0a697a3b-233a-44bc-a337-e2441fb277a7, creative instance id 30ecd70f-f56d-4745-a457-4035fcab54b6 and advertiser id  on Wednesday, March 17, 2021 at 2:57:43 PM
[11707:11707:0317/145743.170460:VERBOSE1:confirmations.cc(87)] Confirming conversion ad for creative instance id 30ecd70f-f56d-4745-a457-4035fcab54b6
[11707:11707:0317/145743.179430:VERBOSE3:conversions.cc(310)] Successfully removed conversion from queue

Notification ad - same set - frequency capping
Verified unable to show the ad
Verified frequency capping for converted ad was triggered

[8268:8268:0317/142808.647072:VERBOSE2:exclusion_rule_util.h(26)] creativeSetId 0a697a3b-233a-44bc-a337-e2441fb277a7 has exceeded the frequency capping for conversions

Notification ad - same set - browser restart
Verified conversion was triggered:

[10744:10744:0317/144310.715843:VERBOSE1:conversions.cc(116)] Checking URL for conversions
[10744:10744:0317/144310.861386:VERBOSE1:conversions.cc(224)] Conversion for campaign id d4d0474c-277a-4714-b25d-7b484cdb580a, creative set id 0a697a3b-233a-44bc-a337-e2441fb277a7, creative instance id 30ecd70f-f56d-4745-a457-4035fcab54b6 and advertiser id  in 0 hours, 0 minutes, 0 seconds at 2:43 PM
[10744:10744:0317/144310.867987:VERBOSE6:conversions.cc(275)] Successfully logged conversion event
[10744:10744:0317/144310.875757:VERBOSE3:conversions.cc(295)] Successfully appended conversion to queue
[10744:10744:0317/144310.881072:VERBOSE1:conversions.cc(399)] Convert campaign id d4d0474c-277a-4714-b25d-7b484cdb580a, creative set id 0a697a3b-233a-44bc-a337-e2441fb277a7, creative instance id 30ecd70f-f56d-4745-a457-4035fcab54b6 and advertiser id  in 0 hours, 13 minutes, 57 seconds at 2:57 PM

Verified conversion was successful

[11170:11170:0317/150338.045557:VERBOSE1:conversions.cc(340)] Successfully converted ad with campaign id d4d0474c-277a-4714-b25d-7b484cdb580a, creative set id 0a697a3b-233a-44bc-a337-e2441fb277a7, creative instance id 30ecd70f-f56d-4745-a457-4035fcab54b6 and advertiser id  on Wednesday, March 17, 2021 at 2:57:07 PM

Notification ad - same set - observation window
Verified ad was not converted

[13985:13985:0318/150703.519242:VERBOSE1:conversions.cc(205)] No conversions found for visited URL

Notification ad - same set - campaign removed from catalog
Verified conversion was triggered:

[16152:16152:0317/153239.679625:VERBOSE1:conversions.cc(224)] Conversion for campaign id d4d0474c-277a-4714-b25d-7b484cdb580a, creative set id 0a697a3b-233a-44bc-a337-e2441fb277a7, creative instance id 30ecd70f-f56d-4745-a457-4035fcab54b6 and advertiser id  in 0 hours, 0 minutes, 0 seconds at 3:32 PM

Notification ad - same set - expired campaign
Verified conversion was triggered:

[18326:18326:0317/192337.799257:VERBOSE1:conversions.cc(224)] Conversion for campaign id d4d0474c-277a-4714-b25d-7b484cdb580a, creative set id 0a697a3b-233a-44bc-a337-e2441fb277a7, creative instance id 30ecd70f-f56d-4745-a457-4035fcab54b6 and advertiser id  in 0 hours, 0 minutes, 0 seconds at 7:23 PM```

Notification ad - same set - upgrade - trigger conversion
Verified conversion was triggered after upgrade:

[20710:20710:0317/164007.564376:VERBOSE1:conversions.cc(224)] Conversion for campaign id d4d0474c-277a-4714-b25d-7b484cdb580a, creative set id 0a697a3b-233a-44bc-a337-e2441fb277a7, creative instance id 30ecd70f-f56d-4745-a457-4035fcab54b6 and advertiser id  in 0 hours, 0 minutes, 0 seconds at 4:40 PM

Notification ad - same set - upgrade - successful conversion
Verified conversion was successful after upgrade:

[23431:23431:0317/184815.254602:VERBOSE1:conversions.cc(340)] Successfully converted ad with campaign id , creative set id 0a697a3b-233a-44bc-a337-e2441fb277a7, creative instance id ed6c467a-8643-42eb-a7cd-32e878fa3cd4 and advertiser id  on Wednesday, March 17, 2021 at 6:02:02 PM
[23431:23431:0317/184815.254664:VERBOSE1:confirmations.cc(87)] Confirming conversion ad for creative instance id ed6c467a-8643-42eb-a7cd-32e878fa3cd4

Notification ad - different set
Verified both conversions were triggered:

[25544:25544:0317/173851.444528:VERBOSE1:conversions.cc(224)] Conversion for campaign id d4d0474c-277a-4714-b25d-7b484cdb580a, creative set id 0a697a3b-233a-44bc-a337-e2441fb277a7, creative instance id 30ecd70f-f56d-4745-a457-4035fcab54b6 and advertiser id  in 0 hours, 0 minutes, 0 seconds at 5:38 PM
[25544:25544:0317/173851.444660:VERBOSE1:conversions.cc(224)] Conversion for campaign id d4d0474c-277a-4714-b25d-7b484cdb580a, creative set id a9f0b49c-3298-4c1b-a8b5-76a71e8d7332, creative instance id ed6c467a-8643-42eb-a7cd-32e878fa3cd4 and advertiser id  in 0 hours, 0 minutes, 0 seconds at 5:38 PM

Notification ad - different campaigns
Verified both conversions were triggered:

[26763:26763:0317/175657.967259:VERBOSE1:conversions.cc(224)] Conversion for campaign id d4d0474c-277a-4714-b25d-7b484cdb580a, creative set id 0a697a3b-233a-44bc-a337-e2441fb277a7, creative instance id 30ecd70f-f56d-4745-a457-4035fcab54b6 and advertiser id  in 0 hours, 0 minutes, 0 seconds at 5:56 PM
[26763:26763:0317/175657.969964:VERBOSE1:conversions.cc(224)] Conversion for campaign id 0e70c893-b0c0-4dab-860d-7e65446f0f0f, creative set id a9f0b49c-3298-4c1b-a8b5-76a71e8d7332, creative instance id ed6c467a-8643-42eb-a7cd-32e878fa3cd4 and advertiser id  in 0 hours, 0 minutes, 0 seconds at 5:56 PM

NTP SI ad
Verified NTP SI was successfully viewed:

[31075:31075:0317/184957.703726:VERBOSE3:new_tab_page_ad_event_viewed.cc(24)] Viewed new tab page ad with uuid 2e4b2111-7a52-45a9-b600-7ca79d12e97b and creative instance id ed6c467a-8643-42eb-a7cd-32e878fa3cd4
[31075:31075:0317/184957.758344:VERBOSE6:new_tab_page_ad_event_viewed.cc(32)] Successfully logged new tab page ad viewed event

Verified conversion was triggered:

[31075:31075:0317/185045.618158:VERBOSE1:conversions.cc(116)] Checking URL for conversions
[31075:31075:0317/185045.618303:VERBOSE1:purchase_intent_processor.cc(95)] No purchase intent matches found for visited URL
[31075:31075:0317/185045.781582:VERBOSE1:text_classification_processor.cc(62)] Classified text with the top segment as technology & computing-software
[31075:31075:0317/185045.787502:VERBOSE1:conversions.cc(224)] Conversion for campaign id d4d0474c-277a-4714-b25d-7b484cdb580a, creative set id 0a697a3b-233a-44bc-a337-e2441fb277a7, creative instance id ed6c467a-8643-42eb-a7cd-32e878fa3cd4 and advertiser id  in 0 hours, 0 minutes, 0 seconds at 6:50 PM
[31075:31075:0317/185045.796521:VERBOSE6:conversions.cc(275)] Successfully logged conversion event
[31075:31075:0317/185045.801651:VERBOSE3:conversions.cc(295)] Successfully appended conversion to queue
[31075:31075:0317/185045.802633:VERBOSE1:conversions.cc(399)] Convert campaign id d4d0474c-277a-4714-b25d-7b484cdb580a, creative set id 0a697a3b-233a-44bc-a337-e2441fb277a7, creative instance id ed6c467a-8643-42eb-a7cd-32e878fa3cd4 and advertiser id  in 0 hours, 16 minutes, 11 seconds at 7:06 PM

Verified conversion was successful:

[31541:31541:0317/192331.812870:VERBOSE1:conversions.cc(340)] Successfully converted ad with campaign id d4d0474c-277a-4714-b25d-7b484cdb580a, creative set id 0a697a3b-233a-44bc-a337-e2441fb277a7, creative instance id ed6c467a-8643-42eb-a7cd-32e878fa3cd4 and advertiser id  on Wednesday, March 17, 2021 at 7:06:56 PM
[31541:31541:0317/192331.812964:VERBOSE1:confirmations.cc(87)] Confirming conversion ad for creative instance id ed6c467a-8643-42eb-a7cd-32e878fa3cd4

Verified conversion token was redeemed:

[31541:31541:0317/192332.593919:VERBOSE1:confirmations.cc(228)] Successfully redeemed unblinded token with confirmation id 8b764173-eb72-4602-80e9-59822ed9f953, creative instance id ed6c467a-8643-42eb-a7cd-32e878fa3cd4 and conversion

NTP SI ad - upgrade - trigger conversion
Verified the ad on old Brave (1.21.77) was shown:

[32722:32722:0317/194820.823784:VERBOSE6:new_tab_page_ad_event_viewed.cc(33)] Successfully logged new tab page ad viewed event
[32722:32722:0317/194821.830284:VERBOSE1:confirmations.cc(245)] Added 1 unblinded payment token with an estimated redemption value of 0.025 BAT, you now have 1 unblinded payment tokens

Verified conversion was triggered after upgrade:

[681:681:0317/195215.935646:VERBOSE1:conversions.cc(224)] Conversion for campaign id d4d0474c-277a-4714-b25d-7b484cdb580a, creative set id 0a697a3b-233a-44bc-a337-e2441fb277a7, creative instance id ed6c467a-8643-42eb-a7cd-32e878fa3cd4 and advertiser id  in 0 hours, 0 minutes, 0 seconds at 7:52 PM

NTP SI ad - upgrade - successful conversion
Verified the ad on old Brave (1.21.77) was shown and conversion was triggered:

[2646:2646:0317/200243.856224:VERBOSE3:new_tab_page_ad_event_viewed.cc(24)] Viewed new tab page ad with uuid a7b27145-60fa-4916-bdd5-a5536373e5dd and creative instance id ed6c467a-8643-42eb-a7cd-32e878fa3cd4
[2646:2646:0317/200257.053708:VERBOSE1:conversions.cc(230)] Conversion for creative set id 0a697a3b-233a-44bc-a337-e2441fb277a7 and new_tab_page_ad
[2646:2646:0317/200257.053940:VERBOSE1:conversions.cc(396)] Convert creative instance id ed6c467a-8643-42eb-a7cd-32e878fa3cd4 and creative set id 0a697a3b-233a-44bc-a337-e2441fb277a7 in 0 hours, 22 minutes, 8 seconds at 8:25 PM
[2646:2646:0317/200257.063934:VERBOSE6:conversions.cc(290)] Successfully logged conversion event

Verified ad was converted successfully after upgrade

[3115:3115:0317/203508.656571:VERBOSE1:conversions.cc(340)] Successfully converted ad with campaign id , creative set id 0a697a3b-233a-44bc-a337-e2441fb277a7, creative instance id ed6c467a-8643-42eb-a7cd-32e878fa3cd4 and advertiser id  on Wednesday, March 17, 2021 at 8:25:05 PM
[3115:3115:0317/203508.656893:VERBOSE1:confirmations.cc(87)] Confirming conversion ad for creative instance id ed6c467a-8643-42eb-a7cd-32e878fa3cd4
[3115:3115:0317/203508.668069:VERBOSE3:conversions.cc(310)] Successfully removed conversion from queue

Promoted Content ad
Verified ad was shown and user was paid for it

[5918:5918:0317/202932.838585:VERBOSE6:promoted_content_ad_event_viewed.cc(32)] Successfully logged promoted content ad viewed event
[5918:5918:0317/202933.951484:VERBOSE1:confirmations.cc(228)] Successfully redeemed unblinded token with confirmation id a3b9deeb-9f37-4b9f-8cfe-847be10f816b, creative instance id 40a69fa9-3814-4ec4-bee8-a176c8fb4690 and view
[5918:5918:0317/202933.951902:VERBOSE1:confirmations.cc(251)] Added 1 unblinded payment token with an estimated redemption value of 0.025 BAT, you now have 1 unblinded payment tokens

Verified conversion was triggered

[5918:5918:0317/203137.466567:VERBOSE1:conversions.cc(224)] Conversion for campaign id 84dd294c-f4c1-4bc0-a232-499c5310ef4c, creative set id f6230b39-ff52-440a-b827-b9db9d06444a, creative instance id 40a69fa9-3814-4ec4-bee8-a176c8fb4690 and advertiser id  in 0 hours, 0 minutes, 0 seconds at 8:31 PM
[5918:5918:0317/203137.474247:VERBOSE6:conversions.cc(275)] Successfully logged conversion event
[5918:5918:0317/203137.477170:VERBOSE3:conversions.cc(295)] Successfully appended conversion to queue
[5918:5918:0317/203137.478237:VERBOSE1:conversions.cc(399)] Convert campaign id 84dd294c-f4c1-4bc0-a232-499c5310ef4c, creative set id f6230b39-ff52-440a-b827-b9db9d06444a, creative instance id 40a69fa9-3814-4ec4-bee8-a176c8fb4690 and advertiser id  in 0 hours, 7 minutes, 30 seconds at 8:39 PM

Verified conversion was successful

[5918:5918:0317/203907.470069:VERBOSE1:conversions.cc(340)] Successfully converted ad with campaign id 84dd294c-f4c1-4bc0-a232-499c5310ef4c, creative set id f6230b39-ff52-440a-b827-b9db9d06444a, creative instance id 40a69fa9-3814-4ec4-bee8-a176c8fb4690 and advertiser id  on Wednesday, March 17, 2021 at 8:39:07 PM
[5918:5918:0317/203907.470136:VERBOSE1:confirmations.cc(87)] Confirming conversion ad for creative instance id 40a69fa9-3814-4ec4-bee8-a176c8fb4690
postclick verification ### postclick

postclick - notification ad - before click
Conversion triggered without actual click. Logged #14795
image

[7038:7038:0317/210935.410238:VERBOSE1:conversions.cc(224)] Conversion for campaign id d4d0474c-277a-4714-b25d-7b484cdb580a, creative set id 0a697a3b-233a-44bc-a337-e2441fb277a7, creative instance id 30ecd70f-f56d-4745-a457-4035fcab54b6 and advertiser id  in 0 hours, 0 minutes, 0 seconds at 9:09 PM
[7038:7038:0317/210935.418435:VERBOSE6:conversions.cc(275)] Successfully logged conversion event

postclick - notification ad - after click
Verified click event was recorded:

[8057:8057:0317/213349.113211:VERBOSE1:ad_notification_event_clicked.cc(35)] Successfully logged ad notification clicked event

Verified conversion was triggered:

[8057:8057:0317/213430.544060:VERBOSE1:conversions.cc(224)] Conversion for campaign id d4d0474c-277a-4714-b25d-7b484cdb580a, creative set id 0a697a3b-233a-44bc-a337-e2441fb277a7, creative instance id 30ecd70f-f56d-4745-a457-4035fcab54b6 and advertiser id  in 0 hours, 0 minutes, 0 seconds at 9:34 PM

postclick - notification ad - upgrade
Verified the ad on old Brave (1.21.77) was clicked:

[10025:10025:0317/222424.852964:VERBOSE1:ad_notification_event_clicked.cc(36)] Successfully logged ad notification clicked event

image
Verified conversion was triggered after upgrade:

[11505:11505:0317/223106.790821:VERBOSE1:conversions.cc(224)] Conversion for campaign id d4d0474c-277a-4714-b25d-7b484cdb580a, creative set id 0a697a3b-233a-44bc-a337-e2441fb277a7, creative instance id ed6c467a-8643-42eb-a7cd-32e878fa3cd4 and advertiser id  in 0 hours, 0 minutes, 0 seconds at 10:31 PM

postclick - NTP SI ad - before click
Verified the ad was shown:

[14973:14973:0317/225802.347251:VERBOSE6:new_tab_page_ad_event_viewed.cc(32)] Successfully logged new tab page ad viewed event

The conversion was triggered after a view event. Logged #14795

[14973:14973:0317/225829.249135:VERBOSE1:conversions.cc(224)] Conversion for campaign id d4d0474c-277a-4714-b25d-7b484cdb580a, creative set id 0a697a3b-233a-44bc-a337-e2441fb277a7, creative instance id ed6c467a-8643-42eb-a7cd-32e878fa3cd4 and advertiser id  in 0 hours, 0 minutes, 0 seconds at 10:58 PM
[14973:14973:0317/225829.263312:VERBOSE6:conversions.cc(275)] Successfully logged conversion event
[14973:14973:0317/225829.284768:VERBOSE3:conversions.cc(295)] Successfully appended conversion to queue
[14973:14973:0317/225829.285722:VERBOSE1:conversions.cc(399)] Convert campaign id d4d0474c-277a-4714-b25d-7b484cdb580a, creative set id 0a697a3b-233a-44bc-a337-e2441fb277a7, creative instance id ed6c467a-8643-42eb-a7cd-32e878fa3cd4 and advertiser id  in 0 hours, 5 minutes, 10 seconds at 11:03 PM

postclick - NTP SI ad - after click
Verified click event was recorded:
image

[16197:16197:0317/230652.128219:VERBOSE6:new_tab_page_ad_event_clicked.cc(33)] Successfully logged new tab page ad clicked event

Verified conversion was triggered:

[16197:16197:0317/230717.129077:VERBOSE1:conversions.cc(224)] Conversion for campaign id d4d0474c-277a-4714-b25d-7b484cdb580a, creative set id 0a697a3b-233a-44bc-a337-e2441fb277a7, creative instance id ed6c467a-8643-42eb-a7cd-32e878fa3cd4 and advertiser id  in 0 hours, 0 minutes, 0 seconds at 11:07 PM
[16197:16197:0317/230717.136045:VERBOSE6:conversions.cc(275)] Successfully logged conversion event
[16197:16197:0317/230717.146408:VERBOSE3:conversions.cc(295)] Successfully appended conversion to queue
[16197:16197:0317/230717.147283:VERBOSE1:conversions.cc(399)] Convert campaign id d4d0474c-277a-4714-b25d-7b484cdb580a, creative set id 0a697a3b-233a-44bc-a337-e2441fb277a7, creative instance id ed6c467a-8643-42eb-a7cd-32e878fa3cd4 and advertiser id  in 0 hours, 10 minutes, 13 seconds at 11:17 PM

postclick - notification ad - upgrade
Verified the ad on old Brave (1.21.77) was clicked:

[17499:17499:0317/232229.981902:VERBOSE6:new_tab_page_ad_event_clicked.cc(34)] Successfully logged new tab page ad clicked event

Verified conversion was triggered after upgrade:

[17889:17889:0317/232454.825745:VERBOSE1:conversions.cc(224)] Conversion for campaign id d4d0474c-277a-4714-b25d-7b484cdb580a, creative set id 0a697a3b-233a-44bc-a337-e2441fb277a7, creative instance id ed6c467a-8643-42eb-a7cd-32e878fa3cd4 and advertiser id  in 0 hours, 0 minutes, 0 seconds at 11:24 PM
[17889:17889:0317/232454.833620:VERBOSE6:conversions.cc(275)] Successfully logged conversion event
[17889:17889:0317/232454.842566:VERBOSE3:conversions.cc(295)] Successfully appended conversion to queue
[17889:17889:0317/232454.844956:VERBOSE1:conversions.cc(399)] Convert campaign id d4d0474c-277a-4714-b25d-7b484cdb580a, creative set id 0a697a3b-233a-44bc-a337-e2441fb277a7, creative instance id ed6c467a-8643-42eb-a7cd-32e878fa3cd4 and advertiser id  in 0 hours, 7 minutes, 56 seconds at 11:32 PM

postclick - promoted content - before click
Verified ad was viewed:

[18936:18936:0317/233144.172783:VERBOSE3:promoted_content_ad_event_viewed.cc(24)] Viewed promoted content ad with uuid e426ece0e0877914dda33b76922bcf443e211995b4c7d347e01d2ec2641293da and creative instance id 40a69fa9-3814-4ec4-bee8-a176c8fb4690
[18936:18936:0317/233144.182363:VERBOSE6:promoted_content_ad_event_viewed.cc(32)] Successfully logged promoted content ad viewed event

Conversion was triggered. Logged #14795

[18936:18936:0317/233209.888879:VERBOSE1:conversions.cc(224)] Conversion for campaign id 84dd294c-f4c1-4bc0-a232-499c5310ef4c, creative set id f6230b39-ff52-440a-b827-b9db9d06444a, creative instance id 40a69fa9-3814-4ec4-bee8-a176c8fb4690 and advertiser id  in 0 hours, 0 minutes, 0 seconds at 11:32 PM
[18936:18936:0317/233209.894258:VERBOSE6:conversions.cc(275)] Successfully logged conversion event
[18936:18936:0317/233209.898576:VERBOSE3:conversions.cc(295)] Successfully appended conversion to queue
[18936:18936:0317/233209.899808:VERBOSE1:conversions.cc(399)] Convert campaign id 84dd294c-f4c1-4bc0-a232-499c5310ef4c, creative set id f6230b39-ff52-440a-b827-b9db9d06444a, creative instance id 40a69fa9-3814-4ec4-bee8-a176c8fb4690 and advertiser id  in 0 hours, 9 minutes, 56 seconds at 11:42 PM

postclick - promoted content - after click
Due to #14420 view event was not triggered.
Verified ad was clicked:

[20299:20299:0317/234059.126500:VERBOSE3:promoted_content_ad_event_clicked.cc(24)] Clicked promoted content ad with uuid e426ece0e0877914dda33b76922bcf443e211995b4c7d347e01d2ec2641293da and creative instance id 40a69fa9-3814-4ec4-bee8-a176c8fb4690
[20299:20299:0317/234059.237901:VERBOSE6:promoted_content_ad_event_clicked.cc(32)] Successfully logged promoted content ad clicked event

Verified conversion was triggered:

[20299:20299:0317/234120.570780:VERBOSE1:conversions.cc(224)] Conversion for campaign id 84dd294c-f4c1-4bc0-a232-499c5310ef4c, creative set id f6230b39-ff52-440a-b827-b9db9d06444a, creative instance id 40a69fa9-3814-4ec4-bee8-a176c8fb4690 and advertiser id  in 0 hours, 0 minutes, 0 seconds at 11:41 PM
[20299:20299:0317/234120.583846:VERBOSE6:conversions.cc(275)] Successfully logged conversion event
[20299:20299:0317/234120.588534:VERBOSE3:conversions.cc(295)] Successfully appended conversion to queue
[20299:20299:0317/234120.591120:VERBOSE1:conversions.cc(399)] Convert campaign id 84dd294c-f4c1-4bc0-a232-499c5310ef4c, creative set id f6230b39-ff52-440a-b827-b9db9d06444a, creative instance id 40a69fa9-3814-4ec4-bee8-a176c8fb4690 and advertiser id  in 0 hours, 5 minutes, 25 seconds at 11:46 PM

postclick - promoted content - upgrade
Verified the ad on old Brave (1.21.77) was clicked:

[21459:21459:0317/235846.313855:VERBOSE6:promoted_content_ad_event_clicked.cc(33)] Successfully logged promoted content ad clicked event

Verified conversion was triggered after upgrade:

[21904:21904:0318/000012.101310:VERBOSE1:conversions.cc(224)] Conversion for campaign id 84dd294c-f4c1-4bc0-a232-499c5310ef4c, creative set id f6230b39-ff52-440a-b827-b9db9d06444a, creative instance id 40a69fa9-3814-4ec4-bee8-a176c8fb4690 and advertiser id  in 0 hours, 0 minutes, 0 seconds at 12:00 AM
[21904:21904:0318/000012.110375:VERBOSE6:conversions.cc(275)] Successfully logged conversion event
[21904:21904:0318/000012.118800:VERBOSE3:conversions.cc(295)] Successfully appended conversion to queue
[21904:21904:0318/000012.120116:VERBOSE1:conversions.cc(399)] Convert campaign id 84dd294c-f4c1-4bc0-a232-499c5310ef4c, creative set id f6230b39-ff52-440a-b827-b9db9d06444a, creative instance id 40a69fa9-3814-4ec4-bee8-a176c8fb4690 and advertiser id  in 0 hours, 8 minutes, 46 seconds at 12:08 AM

Verification passed on


Brave | 1.22.63 Chromium: 89.0.4389.90 (Official Build) dev (64-bit)
-- | --
Revision | 62eb262cdaae9ef819aadd778193781455ec7a49-refs/branch-heads/4389@{#1534}
OS | Windows 10 OS Version 2004 (Build 19041.867)
Notification ad - different campaigns

Verified conversion was triggered:

[8320:20672:0318/211339.686:VERBOSE1:conversions.cc(224)] Conversion for campaign id d4d0474c-277a-4714-b25d-7b484cdb580a, creative set id 0a697a3b-233a-44bc-a337-e2441fb277a7, creative instance id 30ecd70f-f56d-4745-a457-4035fcab54b6 and advertiser id  in 0 hours, 0 minutes, 0 seconds at 9:13 PM
[8320:20672:0318/211339.686:VERBOSE1:conversions.cc(224)] Conversion for campaign id 0e70c893-b0c0-4dab-860d-7e65446f0f0f, creative set id a9f0b49c-3298-4c1b-a8b5-76a71e8d7332, creative instance id ed6c467a-8643-42eb-a7cd-32e878fa3cd4 and advertiser id  in 0 hours, 0 minutes, 0 seconds at 9:13 PM

Brave | 1.22.64 Chromium: 89.0.4389.90 (Official Build) (64-bit)
-- | --
Revision | 62eb262cdaae9ef819aadd778193781455ec7a49-refs/branch-heads/4389@{#1534}
OS | Windows 10 OS Version 2004 (Build 19041.867)
NTP SI ad

Verified conversion was triggered:

[20328:7060:0319/152515.824:VERBOSE1:conversions.cc(396)] Convert creative instance id ed6c467a-8643-42eb-a7cd-32e878fa3cd4 and creative set id 0a697a3b-233a-44bc-a337-e2441fb277a7 in 0 hours, 5 minutes, 30 seconds at 3:30 PM
[20328:7060:0319/152515.832:VERBOSE6:conversions.cc(290)] Successfully logged conversion event

Verified conversion was successful:

[20264:21416:0319/153917.411:VERBOSE1:conversions.cc(354)] Successfully converted ad with creative instance id ed6c467a-8643-42eb-a7cd-32e878fa3cd4 and creative set id 0a697a3b-233a-44bc-a337-e2441fb277a7 in 0 hours, -8 minutes, -31 seconds at 3:30 PM
[20264:21416:0319/153924.257:VERBOSE1:confirmations.cc(90)] Confirming conversion ad for creative instance id ed6c467a-8643-42eb-a7cd-32e878fa3cd4
NTP SI ad - upgrade - trigger conversion Verified conversion is triggered in an upgraded profile `1.22.64` 
[17844:22724:0319/155947.421:VERBOSE1:conversions.cc(224)] Conversion for campaign id d4d0474c-277a-4714-b25d-7b484cdb580a, creative set id 0a697a3b-233a-44bc-a337-e2441fb277a7, creative instance id ed6c467a-8643-42eb-a7cd-32e878fa3cd4 and advertiser id  in 0 hours, 0 minutes, 0 seconds at 3:59 PM
[17844:22724:0319/155947.428:VERBOSE6:conversions.cc(275)] Successfully logged conversion event
NTP SI ad - upgrade - successful conversion

Verified conversion was triggered in 1.21.77

[3572:17676:0319/161054.563:VERBOSE1:conversions.cc(396)] Convert creative instance id 30ecd70f-f56d-4745-a457-4035fcab54b6 and creative set id 0a697a3b-233a-44bc-a337-e2441fb277a7 in 0 hours, 1 minute, 51 seconds at 4:12 PM
[3572:17676:0319/161054.571:VERBOSE6:conversions.cc(290)] Successfully logged conversion event

Verified conversion is successful in upgraded profile 1.22.64

[18520:21256:0319/161448.958:VERBOSE1:conversions.cc(340)] Successfully converted ad with campaign id , creative set id 0a697a3b-233a-44bc-a337-e2441fb277a7, creative instance id 30ecd70f-f56d-4745-a457-4035fcab54b6 and advertiser id  on Friday, March 19, 2021 at 4:12:46 PM
[18520:21256:0319/161448.959:VERBOSE1:confirmations.cc(87)] Confirming conversion ad for creative instance id 30ecd70f-f56d-4745-a457-4035fcab54b6
Promoted Content ad

Verified promoted AD is shown
image

Verified conversion is triggered

[18416:18752:0319/163413.865:VERBOSE1:conversions.cc(224)] Conversion for campaign id 84dd294c-f4c1-4bc0-a232-499c5310ef4c, creative set id f6230b39-ff52-440a-b827-b9db9d06444a, creative instance id 40a69fa9-3814-4ec4-bee8-a176c8fb4690 and advertiser id  in 0 hours, 0 minutes, 0 seconds at 4:34 PM
[18416:18752:0319/163413.873:VERBOSE6:conversions.cc(275)] Successfully logged conversion event

Verified conversion is successful

[18416:18752:0319/170059.875:VERBOSE1:conversions.cc(340)] Successfully converted ad with campaign id 84dd294c-f4c1-4bc0-a232-499c5310ef4c, creative set id f6230b39-ff52-440a-b827-b9db9d06444a, creative instance id 40a69fa9-3814-4ec4-bee8-a176c8fb4690 and advertiser id  on Friday, March 19, 2021 at 5:00:59 PM
[18416:18752:0319/170100.150:VERBOSE1:confirmations.cc(87)] Confirming conversion ad for creative instance id 40a69fa9-3814-4ec4-bee8-a176c8fb4690
postclick - notification ad - before click

As per the test plan, the conversion should not be triggered but the AD conversion is triggered. Encountered #14795 (comment)

[21500:21888:0319/171149.314:VERBOSE1:conversions.cc(224)] Conversion for campaign id d4d0474c-277a-4714-b25d-7b484cdb580a, creative set id 0a697a3b-233a-44bc-a337-e2441fb277a7, creative instance id ed6c467a-8643-42eb-a7cd-32e878fa3cd4 and advertiser id  in 0 hours, 0 minutes, 0 seconds at 5:11 PM
[21500:21888:0319/171149.326:VERBOSE6:conversions.cc(275)] Successfully logged conversion event
[21500:21888:0319/171149.336:VERBOSE3:conversions.cc(295)] Successfully appended conversion to queue
[21500:21888:0319/171149.337:VERBOSE1:conversions.cc(399)] Convert campaign id d4d0474c-277a-4714-b25d-7b484cdb580a, creative set id 0a697a3b-233a-44bc-a337-e2441fb277a7, creative instance id ed6c467a-8643-42eb-a7cd-32e878fa3cd4 and advertiser id  in 0 hours, 10 minutes, 40 seconds at 5:22 PM
postclick - notification ad - after click

Verified conversion is triggered after clicking on the AD

[19724:18092:0319/172229.174:VERBOSE1:conversions.cc(224)] Conversion for campaign id d4d0474c-277a-4714-b25d-7b484cdb580a, creative set id 0a697a3b-233a-44bc-a337-e2441fb277a7, creative instance id 30ecd70f-f56d-4745-a457-4035fcab54b6 and advertiser id  in 0 hours, 0 minutes, 0 seconds at 5:22 PM
[19724:18092:0319/172229.183:VERBOSE6:conversions.cc(275)] Successfully logged conversion event
postclick - notification ad - upgrade

Verified conversion is triggered

[18988:13480:0319/173833.254:VERBOSE1:conversions.cc(224)] Conversion for campaign id d4d0474c-277a-4714-b25d-7b484cdb580a, creative set id 0a697a3b-233a-44bc-a337-e2441fb277a7, creative instance id ed6c467a-8643-42eb-a7cd-32e878fa3cd4 and advertiser id  in 0 hours, 0 minutes, 0 seconds at 5:38 PM
[18988:13480:0319/173833.263:VERBOSE6:conversions.cc(275)] Successfully logged conversion event
postclick - NTP SI ad - before click

As per the test plan, the conversion should not be triggered but the AD conversion is triggered. Encountered #14795 (comment)

[18664:4792:0319/174547.439:VERBOSE1:conversions.cc(224)] Conversion for campaign id d4d0474c-277a-4714-b25d-7b484cdb580a, creative set id 0a697a3b-233a-44bc-a337-e2441fb277a7, creative instance id ed6c467a-8643-42eb-a7cd-32e878fa3cd4 and advertiser id  in 0 hours, 0 minutes, 0 seconds at 5:45 PM
[18664:4792:0319/174547.448:VERBOSE6:conversions.cc(275)] Successfully logged conversion event
postclick - NTP SI ad - after click

Verified conversion is triggered

[10544:12092:0319/175657.559:VERBOSE1:conversions.cc(224)] Conversion for campaign id d4d0474c-277a-4714-b25d-7b484cdb580a, creative set id 0a697a3b-233a-44bc-a337-e2441fb277a7, creative instance id 30ecd70f-f56d-4745-a457-4035fcab54b6 and advertiser id  in 0 hours, 0 minutes, 0 seconds at 5:56 PM
[10544:12092:0319/175657.574:VERBOSE6:conversions.cc(275)] Successfully logged conversion event
postclick - notification ad - upgrade

Verified conversion is triggered

[12944:11952:0319/180636.970:VERBOSE1:conversions.cc(224)] Conversion for campaign id d4d0474c-277a-4714-b25d-7b484cdb580a, creative set id 0a697a3b-233a-44bc-a337-e2441fb277a7, creative instance id ed6c467a-8643-42eb-a7cd-32e878fa3cd4 and advertiser id  in 0 hours, 0 minutes, 0 seconds at 6:06 PM
[12944:11952:0319/180636.978:VERBOSE6:conversions.cc(275)] Successfully logged conversion event

Verified passed with

Brave	1.22.64 Chromium: 89.0.4389.90 (Official Build) (x86_64)
Revision	62eb262cdaae9ef819aadd778193781455ec7a49-refs/branch-heads/4389@{#1534}
OS	macOS Version 10.15.7 (Build 19H524)

and

Brave	1.22.65 Chromium: 89.0.4389.90 (Official Build) (x86_64)
Revision	62eb262cdaae9ef819aadd778193781455ec7a49-refs/branch-heads/4389@{#1534}
OS	macOS Version 10.15.7 (Build 19H524)
Notification ad - same set

Verified test plan for Notification ad - same set from https://github.com/brave/internal/issues/758

Confirmed conversion triggered:

[1836:775:0318/153213.846677:VERBOSE1:conversions.cc(224)] Conversion for campaign id d4d0474c-277a-4714-b25d-7b484cdb580a, creative set id 0a697a3b-233a-44bc-a337-e2441fb277a7, creative instance id ed6c467a-8643-42eb-a7cd-32e878fa3cd4

Confirmed conversion successful:

[1836:775:0318/153811.849665:VERBOSE1:conversions.cc(340)] Successfully converted ad with campaign id d4d0474c-277a-4714-b25d-7b484cdb580a, creative set id 0a697a3b-233a-44bc-a337-e2441fb277a7, creative instance id ed6c467a-8643-42eb-a7cd-32e878fa3cd4
Notification ad - same set - upgrade - trigger conversion

Verified test plan for Notification ad - same set - upgrade - trigger conversion from https://github.com/brave/internal/issues/758

Viewed ad with 1.21.77, upgraded to 1.22.64. Navigated to www.brave.com after upgrade.

Confirmed conversion triggered after upgrade:

[5264:775:0319/093731.169600:VERBOSE1:conversions.cc(224)] Conversion for campaign id d4d0474c-277a-4714-b25d-7b484cdb580a, creative set id 0a697a3b-233a-44bc-a337-e2441fb277a7, creative instance id 30ecd70f-f56d-4745-a457-4035fcab54b6
Notification ad - same set - upgrade - successful conversion

Verified test plan for Notification ad - same set - upgrade - successful conversion from https://github.com/brave/internal/issues/758

Viewed ad with 1.21.77, navigated to www.brave.com and triggered conversion, upgraded to 1.22.65.

Confirmed conversion successful:

[5492:775:0319/101914.001820:VERBOSE1:conversions.cc(340)] Successfully converted ad with campaign id , creative set id 0a697a3b-233a-44bc-a337-e2441fb277a7, creative instance id 30ecd70f-f56d-4745-a457-4035fcab54b6
NTP SI ad

Verified test plan for NTP SI ad from https://github.com/brave/internal/issues/758

Confirmed conversion triggered:

[4702:775:0319/084504.164337:VERBOSE1:conversions.cc(224)] Conversion for campaign id d4d0474c-277a-4714-b25d-7b484cdb580a, creative set id 0a697a3b-233a-44bc-a337-e2441fb277a7, creative instance id ed6c467a-8643-42eb-a7cd-32e878fa3cd4

Confirmed conversion successful:

[4702:775:0319/084508.168857:VERBOSE1:conversions.cc(340)] Successfully converted ad with campaign id d4d0474c-277a-4714-b25d-7b484cdb580a, creative set id 0a697a3b-233a-44bc-a337-e2441fb277a7, creative instance id ed6c467a-8643-42eb-a7cd-32e878fa3cd4
Promoted Content ad

Verified test plan for Promoted Content ad from https://github.com/brave/internal/issues/758

Confirmed conversion triggered:

[5913:775:0319/110036.446371:VERBOSE1:conversions.cc(224)] Conversion for campaign id 84dd294c-f4c1-4bc0-a232-499c5310ef4c, creative set id f6230b39-ff52-440a-b827-b9db9d06444a, creative instance id 40a69fa9-3814-4ec4-bee8-a176c8fb4690

Confirmed conversion successful:

[5913:775:0319/110238.453320:VERBOSE1:conversions.cc(340)] Successfully converted ad with campaign id 84dd294c-f4c1-4bc0-a232-499c5310ef4c, creative set id f6230b39-ff52-440a-b827-b9db9d06444a, creative instance id 40a69fa9-3814-4ec4-bee8-a176c8fb4690

@tmancey tmancey added this to Ads Jun 10, 2024
@tmancey tmancey moved this to Done in Ads Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tmancey tmancey

Labels
enhancement feature/ads OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-All-Platforms QA/Yes release-notes/exclude
Projects
Ads
Archived in project
Milestone
1.22.x - Release
Development

Successfully merging a pull request may close this issue.

Transition Brave Ads conversions queue from JSON to a database table brave/brave-core
4 participants
@tmancey @LaurenWags @btlechowski @GeetaSarvadnya