Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Photographer Credit Link for Zane Lee #13207

Closed
okidokiokami opened this issue Dec 15, 2020 · 7 comments · Fixed by brave/brave-core#7522 or brave/brave-core#7528
Closed

Update Photographer Credit Link for Zane Lee #13207

okidokiokami opened this issue Dec 15, 2020 · 7 comments · Fixed by brave/brave-core#7522 or brave/brave-core#7528

Comments

@okidokiokami
Copy link

okidokiokami commented Dec 15, 2020

Description

One of our photographer links is broken (he changed his username on Unsplash)

Steps to Reproduce

  1. Open NTPs until you find the succulent image
  2. Click on photographer's name (Zane Lee)

Actual result:

404 page

Expected result:

Open's an actual link to photographer's portfolio.
https://unsplash.com/@zane404

Reproduces how often:

Always

Brave version (brave://version info)

Nightly & Beta

Version/Channel Information:

  • Can you reproduce this issue with the current release? No - photos not rolled out yet
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? No
  • Does the issue resolve itself when disabling Brave Rewards? No
  • Is the issue reproducible on the latest version of Chrome? N/A

Miscellaneous Information:

Please update Zane Lee's photographer credit link to https://unsplash.com/@zane404 (He took a 0 out of his username)

@LaurenWags
Copy link
Member

cc @rebron

@rebron
Copy link
Collaborator

rebron commented Dec 16, 2020

cc: @petemill Can you take a look?

@rebron rebron added feature/new-tab priority/P3 The next thing for us to work on. It'll ride the trains. labels Dec 16, 2020
@LaurenWags
Copy link
Member

LaurenWags commented Jan 4, 2021

@rebron do we want this fixed as part of 1.19.x with the new tab page images?

@kjozwiak
Copy link
Member

kjozwiak commented Jan 5, 2021

@rebron do we want this fixed as part of 1.19.x with the new tab page images?

Probably a good idea as we'll be going through #12508 and can quickly check if the above was fixed as well 👍 @rebron do we have resources to get this fixed quickly for 1.19.x?

@simonhong
Copy link
Member

Pushed PR(brave/brave-core#7522) for this.
PR just set brave community link as a credit link. let me know it's ok. cc @rebron

@kjozwiak
Copy link
Member

kjozwiak commented Jan 6, 2021

@simonhong proper link should be https://unsplash.com/@zane404 as per #13207 (comment). Looks like you've created brave/brave-core#7528.

I'm going to deny brave/brave-core#7527 and wait till we get an uplift for brave/brave-core#7528 which uses the correct link 👍

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Jan 7, 2021

Verification passed on


Brave | 1.19.78 Chromium: 87.0.4280.101 (Official Build) dev (64-bit)
-- | --
Revision | 9407c80213cda69c2b7abcb4fa8e3f74488f4956-refs/branch-heads/4280@{#1807}
OS | Windows 10 OS Version 2004 (Build 19041.685)


  • Ensured that the image shown in the NTP matched with the Gdrive image
    image

  • Ensured that clicking on the credit opens the website https://unsplash.com/@zane404
    image

Verification PASSED on macOS 11.1 using the following build:

Brave | 1.19.78 Chromium: 87.0.4280.101 (Official Build) dev (x86_64)
-- | --
Revision | 9407c80213cda69c2b7abcb4fa8e3f74488f4956-refs/branch-heads/4280@{#1807}
OS | macOS Version 11.1 (Build 20C69)

Example Example
Screen Shot 2021-01-07 at 12 26 04 PM Screen Shot 2021-01-07 at 12 26 11 PM

Verification passed on

Brave 1.19.78 Chromium: 87.0.4280.101 (Official Build) dev (64-bit)
Revision 9407c80213cda69c2b7abcb4fa8e3f74488f4956-refs/branch-heads/4280@{#1807}
OS Ubuntu 18.04 LTS

image
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment