Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autoplay will have ask prompt if global content setting is toggled #12795

Closed
darkdh opened this issue Nov 19, 2020 · 1 comment · Fixed by brave/brave-core#7197
Closed

Autoplay will have ask prompt if global content setting is toggled #12795

darkdh opened this issue Nov 19, 2020 · 1 comment · Fixed by brave/brave-core#7197

Comments

@darkdh
Copy link
Member

darkdh commented Nov 19, 2020

Description

Steps to Reproduce

  1. Visit brave://settings/content/autoplay
  2. Toggle the label from "Allowed"=>"Blocked" and then "Blocked"=>"Allowed
  3. Visit https://www.youtube.com/
  4. The prompt shows up

Actual result:

Screen Shot 2020-11-19 at 10 13 48

Expected result:

There shouldn't be any prompt when content setting can only be set to block or allow

Reproduces how often:

Brave version (brave://version info)

Version/Channel Information:

  • Can you reproduce this issue with the current release?
  • Can you reproduce this issue with the beta channel?
  • Can you reproduce this issue with the nightly channel?

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Dec 16, 2020

Verification passed on


Brave | 1.19.61 Chromium: 87.0.4280.101 (Official Build) dev (64-bit)
-- | --
Revision | 9407c80213cda69c2b7abcb4fa8e3f74488f4956-refs/branch-heads/4280@{#1807}
OS | Windows 10 OS Version 2004 (Build 19041.685)

  • Verified the STR from the description
  • Verified that there is no prompt when content setting is set to block or allow

Verification passed on

Brave 1.19.66 Chromium: 87.0.4280.101 (Official Build) dev (64-bit)
Revision 9407c80213cda69c2b7abcb4fa8e3f74488f4956-refs/branch-heads/4280@{#1807}
OS Ubuntu 18.04 LTS

Reproduced the issue on 1.18.x
image

  • Verified the STR from the description
  • Prompt was not shown
    image

Verification PASSED on macOS 11.1 x64 using the following build:

Brave | 1.19.81 Chromium: 87.0.4280.141 (Official Build) dev (x86_64)
--- | ---
Revision | 9f05d1d9ee7483a73e9fe91ddcb8274ebcec9d7f-refs/branch-heads/4280@{#2007}
OS  | macOS Version 11.1 (Build 20C69)

Reproduced the original issue with 1.18.78 CR: 87.0.4280.141 using the STR/Cases outlined via #12795 (comment) as per the following:

Screen Shot 2021-01-13 at 2 38 47 AM

Verified that the issue isn't occurring with 1.19.81 CR: 87.0.4280.141

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment